From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#53491: 29.0.50; Fixing use of define-keymap in gnus-registry.el Date: Sun, 23 Jan 2022 20:21:49 -0800 Message-ID: <87mtjl69wi.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2476"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) To: 53491@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 24 05:23:10 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nBqsn-0000PP-Pg for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 24 Jan 2022 05:23:09 +0100 Original-Received: from localhost ([::1]:43854 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nBqsm-0002jr-SY for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 23 Jan 2022 23:23:08 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:39870) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nBqsg-0002jg-Vp for bug-gnu-emacs@gnu.org; Sun, 23 Jan 2022 23:23:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48736) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nBqsg-0003Kz-M6 for bug-gnu-emacs@gnu.org; Sun, 23 Jan 2022 23:23:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nBqsg-0007U0-JB for bug-gnu-emacs@gnu.org; Sun, 23 Jan 2022 23:23:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Jan 2022 04:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 53491 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.164299812328670 (code B ref -1); Mon, 24 Jan 2022 04:23:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 24 Jan 2022 04:22:03 +0000 Original-Received: from localhost ([127.0.0.1]:41639 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nBqrj-0007SM-5L for submit@debbugs.gnu.org; Sun, 23 Jan 2022 23:22:03 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:44750) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nBqrh-0007Rx-4H for submit@debbugs.gnu.org; Sun, 23 Jan 2022 23:22:01 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:39800) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nBqrg-0001uB-VT for bug-gnu-emacs@gnu.org; Sun, 23 Jan 2022 23:22:00 -0500 Original-Received: from mail.ericabrahamsen.net ([52.70.2.18]:44528) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nBqrf-0003Gq-0c for bug-gnu-emacs@gnu.org; Sun, 23 Jan 2022 23:22:00 -0500 Original-Received: from localhost (c-71-197-232-41.hsd1.wa.comcast.net [71.197.232.41]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id CD651FA01F for ; Mon, 24 Jan 2022 04:21:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1642998111; bh=6Qjqe1epGBYhfIK6Uy0h5+cfCAOZ36qburMt88ZYe6k=; h=From:To:Subject:Date:From; b=o7JgBAE4TSbYyQvzuK3dd6V2appkNWo2SY+Ubdcmr44Fjh3wJHyfffw/5fWYkOoJP mYbTkeggcKs18bM5bkoP1vQZjDtRIKQjVsARfxOwbDP1G6BrHxrfo65ADlMFML6HhX QBI2UBAfDr3BN9YJxKYwyWOIYmyUOpR+DxLHnLSc= Received-SPF: pass client-ip=52.70.2.18; envelope-from=eric@ericabrahamsen.net; helo=mail.ericabrahamsen.net X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:224987 Archived-At: Commit 453db25 changes the Gnus registry's key bindings to use `define-keymap'. The problem is that the old code *added* the registry bindings to the "M" prefix in `gnus-summary-mode-map', while the new code *overrides* everything that was defined on that "M" prefix, in favor of the registry's keys. There used to be a lot of commands there. The simple solution would be to not use `define-keymap' in the registry code, and instead use `define-key' inside the loop at gnus-registry.el:959, defining each command individually on a "M " binding. Another possibility would be to explicitly name the sub-keymap that's currently hung on the "M" prefix, at gnus-sum.el:2038. Then that could be used as a :parent in the `define-keymap' call in gnus-registry.el. Or is there a way to attach a `define-keymap' to an anonymous prefixed keymap? Eric