From: Davide Masserut via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 65604@debbugs.gnu.org, jporterbugs@gmail.com, me@eshelyaron.com
Subject: bug#65604: [PATCH] Display the exit code if the last command failed in Eshell
Date: Wed, 30 Aug 2023 21:59:35 +0200 [thread overview]
Message-ID: <87msy8s344.fsf@mssdvd.com> (raw)
In-Reply-To: <83fs40fi35.fsf@gnu.org>
Eli Zaretskii <eliz@gnu.org> writes:
>> > Why do you meed :eval at all? AFAIR, having a symbol in the
>> > mode line
>> > automatically uses its current value when the mode line is
>> > redrawn.
>>
>> Wouldn't this strip the symbol of its text properties?
>
> Sorry, I don't understand: what symbol and why do we care about
> its
> text properties?
>
> What I meant is that reference to a symbol in mode-line-format
> automatically uses the value of that symbol, unless I'm confused
> or
> misremembering.
"(elisp) Mode Line Data" says:
Unless SYMBOL is marked as risky (i.e., it has a non-‘nil’
‘risky-local-variable’ property), all text properties
specified in
SYMBOL’s value are ignored. This includes the text
properties of
strings in SYMBOL’s value, as well as all ‘:eval’ and
‘:propertize’
forms in it. (The reason for this is security: non-risky
variables
could be set automatically from file variables without
prompting
the user.)
Given this code:
(defun eshell-mode-line-exit-code ()
(when (> eshell-last-command-status 0)
(propertize
(format ":[%s]" eshell-last-command-status)
'help-echo (format "Last command exited with code %s"
eshell-last-command-status)
'face 'compilation-mode-line-fail)))
(setq-local mode-line-process 'eshell-mode-line-exit-code)
Doesn't it mean that unless we mark it "risky-local-variable",
Emacs will remove the "compilation-mode-line-fail" face?
next prev parent reply other threads:[~2023-08-30 19:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-29 22:24 bug#65604: [PATCH] Display the exit code if the last command failed in Eshell Davide Masserut via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-30 1:52 ` Jim Porter
2023-08-30 9:18 ` Davide Masserut via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-30 15:26 ` Davide Masserut via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-30 15:34 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-30 16:45 ` Eli Zaretskii
2023-08-30 16:58 ` Eli Zaretskii
2023-08-30 19:02 ` Davide Masserut via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-30 19:25 ` Eli Zaretskii
2023-08-30 19:59 ` Davide Masserut via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-08-30 20:20 ` Davide Masserut via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-31 4:52 ` Eli Zaretskii
2023-08-31 9:31 ` Davide Masserut via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-02 5:17 ` Jim Porter
2023-09-02 8:47 ` Davide Masserut via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-02 18:40 ` Jim Porter
2023-09-02 18:54 ` Davide Masserut via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-02 22:46 ` Jim Porter
2023-09-10 14:44 ` Sean Whitton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87msy8s344.fsf@mssdvd.com \
--to=bug-gnu-emacs@gnu.org \
--cc=65604@debbugs.gnu.org \
--cc=dm@mssdvd.com \
--cc=eliz@gnu.org \
--cc=jporterbugs@gmail.com \
--cc=me@eshelyaron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).