From: Jim Porter <jporterbugs@gmail.com>
To: Davide Masserut <dm@mssdvd.com>, 65604@debbugs.gnu.org
Subject: bug#65604: [PATCH] Display the exit code if the last command failed in Eshell
Date: Tue, 29 Aug 2023 18:52:40 -0700 [thread overview]
Message-ID: <05108d35-d095-c975-78b8-6b00fc7e6a08@gmail.com> (raw)
In-Reply-To: <87cyz5wjtm.fsf@mssdvd.com>
On 8/29/2023 3:24 PM, Davide Masserut via Bug reports for GNU Emacs, the
Swiss army knife of text editors wrote:
> Tags: patch
>
> There are commands that fail without printing any messages, but set
> specific error codes.
>
> This patch extends the default prompt function to show the exit code of
> the previous failed command.
Thanks. I think this makes sense as an option, but I wonder if this is
the right default place to put it. Instead, what about putting the exit
status in the mode-line, like with compilation buffers? Eshell already
uses the mode-line to show when a command is running, so I think it's an
obvious enhancement to show the status of a command that just finished
running. This does mean you don't see the *history* of failed commands,
but it still provides useful feedback for users without requiring a
change to the prompt (which is a bit more in-your-face).
In the future, I hope to make it easier for people to customize the
Eshell prompt without writing (as much) Elisp, e.g. by defining it the
same way we can define the mode-line. However, I haven't finished up
that patch yet, so it's sitting on one of my pile of local branches...
next prev parent reply other threads:[~2023-08-30 1:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-29 22:24 bug#65604: [PATCH] Display the exit code if the last command failed in Eshell Davide Masserut via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-30 1:52 ` Jim Porter [this message]
2023-08-30 9:18 ` Davide Masserut via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-30 15:26 ` Davide Masserut via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-30 15:34 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-30 16:45 ` Eli Zaretskii
2023-08-30 16:58 ` Eli Zaretskii
2023-08-30 19:02 ` Davide Masserut via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-30 19:25 ` Eli Zaretskii
2023-08-30 19:59 ` Davide Masserut via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-30 20:20 ` Davide Masserut via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-31 4:52 ` Eli Zaretskii
2023-08-31 9:31 ` Davide Masserut via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-02 5:17 ` Jim Porter
2023-09-02 8:47 ` Davide Masserut via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-02 18:40 ` Jim Porter
2023-09-02 18:54 ` Davide Masserut via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-02 22:46 ` Jim Porter
2023-09-10 14:44 ` Sean Whitton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05108d35-d095-c975-78b8-6b00fc7e6a08@gmail.com \
--to=jporterbugs@gmail.com \
--cc=65604@debbugs.gnu.org \
--cc=dm@mssdvd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).