From: Eli Zaretskii <eliz@gnu.org>
To: Davide Masserut <dm@mssdvd.com>
Cc: 65604@debbugs.gnu.org, jporterbugs@gmail.com, me@eshelyaron.com
Subject: bug#65604: [PATCH] Display the exit code if the last command failed in Eshell
Date: Thu, 31 Aug 2023 07:52:16 +0300 [thread overview]
Message-ID: <83a5u7g6f3.fsf@gnu.org> (raw)
In-Reply-To: <87msy8s344.fsf@mssdvd.com> (message from Davide Masserut on Wed, 30 Aug 2023 21:59:35 +0200)
> From: Davide Masserut <dm@mssdvd.com>
> Cc: me@eshelyaron.com, 65604@debbugs.gnu.org, jporterbugs@gmail.com
> Date: Wed, 30 Aug 2023 21:59:35 +0200
>
> Unless SYMBOL is marked as risky (i.e., it has a non-‘nil’
> ‘risky-local-variable’ property), all text properties
> specified in
> SYMBOL’s value are ignored. This includes the text
> properties of
> strings in SYMBOL’s value, as well as all ‘:eval’ and
> ‘:propertize’
> forms in it. (The reason for this is security: non-risky
> variables
> could be set automatically from file variables without
> prompting
> the user.)
>
>
> Given this code:
>
> (defun eshell-mode-line-exit-code ()
> (when (> eshell-last-command-status 0)
> (propertize
> (format ":[%s]" eshell-last-command-status)
> 'help-echo (format "Last command exited with code %s"
> eshell-last-command-status)
> 'face 'compilation-mode-line-fail)))
>
> (setq-local mode-line-process 'eshell-mode-line-exit-code)
>
> Doesn't it mean that unless we mark it "risky-local-variable",
> Emacs will remove the "compilation-mode-line-fail" face?
Ah, that. Yes, the properties will be ignored. But do we really need
fancy faces on that display?
(FWIW, I personally don't like the idea of showing this on the mode
line: the mode line is already quite cramped, and OTOH Bash does show
abnormal exit codes as part of its prompt. But feel free to disregard
my opinions, as I'm not a heavy user of Eshell.)
next prev parent reply other threads:[~2023-08-31 4:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-29 22:24 bug#65604: [PATCH] Display the exit code if the last command failed in Eshell Davide Masserut via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-30 1:52 ` Jim Porter
2023-08-30 9:18 ` Davide Masserut via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-30 15:26 ` Davide Masserut via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-30 15:34 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-30 16:45 ` Eli Zaretskii
2023-08-30 16:58 ` Eli Zaretskii
2023-08-30 19:02 ` Davide Masserut via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-30 19:25 ` Eli Zaretskii
2023-08-30 19:59 ` Davide Masserut via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-30 20:20 ` Davide Masserut via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-31 4:52 ` Eli Zaretskii [this message]
2023-08-31 9:31 ` Davide Masserut via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-02 5:17 ` Jim Porter
2023-09-02 8:47 ` Davide Masserut via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-02 18:40 ` Jim Porter
2023-09-02 18:54 ` Davide Masserut via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-02 22:46 ` Jim Porter
2023-09-10 14:44 ` Sean Whitton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83a5u7g6f3.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=65604@debbugs.gnu.org \
--cc=dm@mssdvd.com \
--cc=jporterbugs@gmail.com \
--cc=me@eshelyaron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).