* bug#4738: 23.1.50; Inconsistent mouse-1 on url in rcirc
@ 2009-10-16 16:04 Leo
0 siblings, 0 replies; 7+ messages in thread
From: Leo @ 2009-10-16 16:04 UTC (permalink / raw)
To: emacs-pretest-bug
Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:
In other modes, usually I can use mouse-1 to open a url however this is
seemingly not possible in rcirc. Can this inconsistency be removed?
Thanks.
Leo
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#4738: 23.1.50; Inconsistent mouse-1 on url in rcirc
@ 2009-10-18 3:30 Chong Yidong
2009-10-18 3:43 ` Ryan Yeske
0 siblings, 1 reply; 7+ messages in thread
From: Chong Yidong @ 2009-10-18 3:30 UTC (permalink / raw)
To: Ryan Yeske; +Cc: 4738, Leo
Hi Ryan, could you take a look at this bug report? Thanks.
Leo <sdl.web@gmail.com> wrote:
> In other modes, usually I can use mouse-1 to open a url however this is
> seemingly not possible in rcirc. Can this inconsistency be removed?
> Thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#4738: 23.1.50; Inconsistent mouse-1 on url in rcirc
2009-10-18 3:30 bug#4738: 23.1.50; Inconsistent mouse-1 on url in rcirc Chong Yidong
@ 2009-10-18 3:43 ` Ryan Yeske
2009-10-18 4:35 ` Chong Yidong
2009-12-24 0:46 ` Leo
0 siblings, 2 replies; 7+ messages in thread
From: Ryan Yeske @ 2009-10-18 3:43 UTC (permalink / raw)
To: Chong Yidong; +Cc: 4738, sdl.web
Hi,
If I remember correctly, it used to be the case that only mouse-2
visited hyperlinks in emacs buffers. Is it standard for mouse-1 to do
this now? Should I just change the binding, or duplicate it?
Ryan
Chong Yidong <cyd@stupidchicken.com> writes:
> Hi Ryan, could you take a look at this bug report? Thanks.
>
> Leo <sdl.web@gmail.com> wrote:
>
>> In other modes, usually I can use mouse-1 to open a url however this is
>> seemingly not possible in rcirc. Can this inconsistency be removed?
>> Thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#4738: 23.1.50; Inconsistent mouse-1 on url in rcirc
2009-10-18 3:43 ` Ryan Yeske
@ 2009-10-18 4:35 ` Chong Yidong
2009-12-24 0:46 ` Leo
1 sibling, 0 replies; 7+ messages in thread
From: Chong Yidong @ 2009-10-18 4:35 UTC (permalink / raw)
To: Ryan Yeske; +Cc: 4738, sdl.web
Ryan Yeske <rcyeske@gmail.com> writes:
> If I remember correctly, it used to be the case that only mouse-2
> visited hyperlinks in emacs buffers. Is it standard for mouse-1 to do
> this now? Should I just change the binding, or duplicate it?
Use the "follow-link" functionality. See the "Defining Clickable Text"
node in the Emacs Lisp manual; you can look at the way other Emacs modes
do it for examples.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#4738: 23.1.50; Inconsistent mouse-1 on url in rcirc
2009-10-18 3:43 ` Ryan Yeske
2009-10-18 4:35 ` Chong Yidong
@ 2009-12-24 0:46 ` Leo
2009-12-24 1:56 ` Lennart Borgman
1 sibling, 1 reply; 7+ messages in thread
From: Leo @ 2009-12-24 0:46 UTC (permalink / raw)
To: Ryan Yeske; +Cc: 4738, Chong Yidong
On 2009-10-18 04:43 +0100, Ryan Yeske wrote:
> Hi,
>
> If I remember correctly, it used to be the case that only mouse-2
> visited hyperlinks in emacs buffers. Is it standard for mouse-1 to do
> this now? Should I just change the binding, or duplicate it?
>
> Ryan
On 2009-10-18 05:35 +0100, Chong Yidong wrote:
> Ryan Yeske <rcyeske@gmail.com> writes:
>
>> If I remember correctly, it used to be the case that only mouse-2
>> visited hyperlinks in emacs buffers. Is it standard for mouse-1 to do
>> this now? Should I just change the binding, or duplicate it?
>
> Use the "follow-link" functionality. See the "Defining Clickable Text"
> node in the Emacs Lisp manual; you can look at the way other Emacs modes
> do it for examples.
I tested the following patch and it seems to work correctly.
diff -c -L /Users/admin/lisp/lisp/net/rcirc.el.gz~ -L /Users/admin/lisp/lisp/net/rcirc.el.gz /tmp/jka-com5634zYF /tmp/jka-com5634NtR
--- /Users/admin/lisp/lisp/net/rcirc.el.gz~
+++ /Users/admin/lisp/lisp/net/rcirc.el.gz
@@ -835,7 +835,8 @@
"Keymap used for browsing URLs in `rcirc-mode'.")
(define-key rcirc-browse-url-map (kbd "RET") 'rcirc-browse-url-at-point)
(define-key rcirc-browse-url-map (kbd "<mouse-2>") 'rcirc-browse-url-at-mouse)
+(define-key rcirc-browse-url-map [follow-link] 'mouse-face)
(defvar rcirc-short-buffer-name nil
"Generated abbreviation to use to indicate buffer activity.")
Diff finished. Thu Dec 24 00:41:00 2009
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#4738: 23.1.50; Inconsistent mouse-1 on url in rcirc
2009-12-24 0:46 ` Leo
@ 2009-12-24 1:56 ` Lennart Borgman
0 siblings, 0 replies; 7+ messages in thread
From: Lennart Borgman @ 2009-12-24 1:56 UTC (permalink / raw)
To: Leo, 4738; +Cc: 4738, Chong Yidong, Ryan Yeske
On Thu, Dec 24, 2009 at 1:46 AM, Leo <sdl.web@gmail.com> wrote:
> On 2009-10-18 04:43 +0100, Ryan Yeske wrote:
>> Hi,
>>
>> If I remember correctly, it used to be the case that only mouse-2
>> visited hyperlinks in emacs buffers. Is it standard for mouse-1 to do
>> this now? Should I just change the binding, or duplicate it?
Wasn't there a decision long ago that mouse-1 also should follow
links, like in other sw?
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#4738: 23.1.50; Inconsistent mouse-1 on url in rcirc
@ 2010-01-02 16:14 Chong Yidong
0 siblings, 0 replies; 7+ messages in thread
From: Chong Yidong @ 2010-01-02 16:14 UTC (permalink / raw)
To: Leo; +Cc: 4738, Ryan Yeske
> >> If I remember correctly, it used to be the case that only mouse-2
> >> visited hyperlinks in emacs buffers. Is it standard for mouse-1 to do
> >> this now? Should I just change the binding, or duplicate it?
> >
> > Use the "follow-link" functionality. See the "Defining Clickable Text"
> > node in the Emacs Lisp manual; you can look at the way other Emacs modes
> > do it for examples.
>
> I tested the following patch and it seems to work correctly.
Thanks, I went ahead and checked it in.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2010-01-02 16:14 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-10-18 3:30 bug#4738: 23.1.50; Inconsistent mouse-1 on url in rcirc Chong Yidong
2009-10-18 3:43 ` Ryan Yeske
2009-10-18 4:35 ` Chong Yidong
2009-12-24 0:46 ` Leo
2009-12-24 1:56 ` Lennart Borgman
-- strict thread matches above, loose matches on Subject: below --
2010-01-02 16:14 Chong Yidong
2009-10-16 16:04 Leo
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).