From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Leo Newsgroups: gmane.emacs.bugs Subject: bug#4738: 23.1.50; Inconsistent mouse-1 on url in rcirc Date: Thu, 24 Dec 2009 00:46:39 +0000 Message-ID: References: <87zl7p4bwg.fsf@stupidchicken.com> <87bpk55puo.fsf@freegeek.hackery.lan> Reply-To: Leo , 4738@debbugs.gnu.org NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1261616850 19009 80.91.229.12 (24 Dec 2009 01:07:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 24 Dec 2009 01:07:30 +0000 (UTC) Cc: 4738@emacsbugs.donarmstrong.com, Chong Yidong To: Ryan Yeske Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 24 02:07:23 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NNcAk-0003qH-DP for geb-bug-gnu-emacs@m.gmane.org; Thu, 24 Dec 2009 02:07:22 +0100 Original-Received: from localhost ([127.0.0.1]:44530 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NNcAk-0003o5-Dy for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 Dec 2009 20:07:22 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NNcAg-0003nr-GK for bug-gnu-emacs@gnu.org; Wed, 23 Dec 2009 20:07:18 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NNcAc-0003nN-1r for bug-gnu-emacs@gnu.org; Wed, 23 Dec 2009 20:07:18 -0500 Original-Received: from [199.232.76.173] (port=48576 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NNcAb-0003nG-S2 for bug-gnu-emacs@gnu.org; Wed, 23 Dec 2009 20:07:13 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41248) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NNcAb-0003sg-Fl for bug-gnu-emacs@gnu.org; Wed, 23 Dec 2009 20:07:13 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1NNbr3-000408-Pe; Wed, 23 Dec 2009 19:47:01 -0500 X-Loop: bug-gnu-emacs@gnu.org Mail-Followup-To: Leo , 4738@debbugs.gnu.org Resent-From: Leo Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Dec 2009 00:47:01 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-Emacs-PR-Message: followup 4738 X-Emacs-PR-Package: emacs,rcirc X-Emacs-PR-Keywords: Original-Received: via spool by 4738-submit@debbugs.gnu.org id=B4738.126161560715374 (code B ref 4738); Thu, 24 Dec 2009 00:47:01 +0000 Original-Received: (at 4738) by debbugs.gnu.org; 24 Dec 2009 00:46:47 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NNbqp-0003zv-3Z for submit@debbugs.gnu.org; Wed, 23 Dec 2009 19:46:47 -0500 Original-Received: from ppsw-6.csi.cam.ac.uk ([131.111.8.136]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NNbqm-0003zo-O7 for 4738@emacsbugs.donarmstrong.com; Wed, 23 Dec 2009 19:46:45 -0500 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Original-Received: from smaug.linux.pwf.cam.ac.uk ([193.60.95.72]:41857) by ppsw-6.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.156]:587) with esmtpsa (LOGIN:sl392) (TLSv1:DHE-RSA-AES128-SHA:128) id 1NNbqh-0004Jg-M5 (Exim 4.70) (return-path ); Thu, 24 Dec 2009 00:46:39 +0000 In-Reply-To: <87bpk55puo.fsf@freegeek.hackery.lan> (Ryan Yeske's message of "Sat, 17 Oct 2009 20:43:27 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list X-Spam-Score: -4.0 (----) Resent-Date: Wed, 23 Dec 2009 19:47:01 -0500 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:33734 Archived-At: On 2009-10-18 04:43 +0100, Ryan Yeske wrote: > Hi, > > If I remember correctly, it used to be the case that only mouse-2 > visited hyperlinks in emacs buffers. Is it standard for mouse-1 to do > this now? Should I just change the binding, or duplicate it? > > Ryan On 2009-10-18 05:35 +0100, Chong Yidong wrote: > Ryan Yeske writes: > >> If I remember correctly, it used to be the case that only mouse-2 >> visited hyperlinks in emacs buffers. Is it standard for mouse-1 to do >> this now? Should I just change the binding, or duplicate it? > > Use the "follow-link" functionality. See the "Defining Clickable Text" > node in the Emacs Lisp manual; you can look at the way other Emacs modes > do it for examples. I tested the following patch and it seems to work correctly. diff -c -L /Users/admin/lisp/lisp/net/rcirc.el.gz~ -L /Users/admin/lisp/lisp/net/rcirc.el.gz /tmp/jka-com5634zYF /tmp/jka-com5634NtR --- /Users/admin/lisp/lisp/net/rcirc.el.gz~ +++ /Users/admin/lisp/lisp/net/rcirc.el.gz @@ -835,7 +835,8 @@ "Keymap used for browsing URLs in `rcirc-mode'.") (define-key rcirc-browse-url-map (kbd "RET") 'rcirc-browse-url-at-point) (define-key rcirc-browse-url-map (kbd "") 'rcirc-browse-url-at-mouse) +(define-key rcirc-browse-url-map [follow-link] 'mouse-face) (defvar rcirc-short-buffer-name nil "Generated abbreviation to use to indicate buffer activity.") Diff finished. Thu Dec 24 00:41:00 2009