From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.bugs Subject: bug#12504: `bookmark-rename' and `bookmark-maybe-historicize-string' Date: Sun, 30 Sep 2012 22:57:37 -0500 Message-ID: <87lifqhmj2.fsf@floss.red-bean.com> References: <736CB5A93DF64F6BB3FDF32A163C35B3@us.oracle.com> Reply-To: Karl Fogel NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1349063930 14544 80.91.229.3 (1 Oct 2012 03:58:50 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 1 Oct 2012 03:58:50 +0000 (UTC) To: 12504@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 01 05:58:55 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TIX9a-0004pm-ND for geb-bug-gnu-emacs@m.gmane.org; Mon, 01 Oct 2012 05:58:46 +0200 Original-Received: from localhost ([::1]:35968 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIX9U-00009A-TS for geb-bug-gnu-emacs@m.gmane.org; Sun, 30 Sep 2012 23:58:40 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:49552) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIX9S-000092-Le for bug-gnu-emacs@gnu.org; Sun, 30 Sep 2012 23:58:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TIX9R-0005uE-Sb for bug-gnu-emacs@gnu.org; Sun, 30 Sep 2012 23:58:38 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54027) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIX9R-0005uA-NF for bug-gnu-emacs@gnu.org; Sun, 30 Sep 2012 23:58:37 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TIX9p-0001Hx-GU for bug-gnu-emacs@gnu.org; Sun, 30 Sep 2012 23:59:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <736CB5A93DF64F6BB3FDF32A163C35B3@us.oracle.com> Resent-From: Karl Fogel Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 Oct 2012 03:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12504 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 12504-submit@debbugs.gnu.org id=B12504.13490638874882 (code B ref 12504); Mon, 01 Oct 2012 03:59:01 +0000 Original-Received: (at 12504) by debbugs.gnu.org; 1 Oct 2012 03:58:07 +0000 Original-Received: from localhost ([127.0.0.1]:35340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TIX8x-0001Gh-99 for submit@debbugs.gnu.org; Sun, 30 Sep 2012 23:58:07 -0400 Original-Received: from mail-ie0-f172.google.com ([209.85.223.172]:52729) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TIX8v-0001Ga-OR for 12504@debbugs.gnu.org; Sun, 30 Sep 2012 23:58:06 -0400 Original-Received: by iec9 with SMTP id 9so11848302iec.3 for <12504@debbugs.gnu.org>; Sun, 30 Sep 2012 20:57:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:reply-to:date:message-id:mime-version :content-type; bh=L9kLC4aVW6yAGCSVGpSYc1enQF7dPrXKLsz7njl/Skw=; b=mZh3YwlFhySqQ7A7ZChwgDIeoMLnAGYbPqJkrmExPTaPL874hlzLWcnL40kJ7Edl3E Ll910sHMHludekM86E9cH5QayLf6UtXfY8vR860TpGYxkQLJ/y8bFxRHc7T0vcu8QukT tEZjPU5BIeCI4TTNBQMSi+aNvTginJG2p8zKOHbTOOWEsLk2SEr3rDbE4DUSo0CCu3fh 2jlfRLwDX5Q0QY9kSVkTgH0cNm6MVlyVJv1FV3BRI/gNZieygSnZhtX8ULLpLYY8P34M WawDM9j0ay3EZj+RrJQNkm+i9TCZJZlpNQ3jd1F5XV3mn4J3UubSq0+NLNPtreH1bLG2 MLQQ== Original-Received: by 10.50.150.144 with SMTP id ui16mr4557419igb.68.1349063860930; Sun, 30 Sep 2012 20:57:40 -0700 (PDT) Original-Received: from floss.red-bean.com (173-109-178-220.pools.spcsdns.net. [173.109.178.220]) by mx.google.com with ESMTPS id a10sm6215410igd.1.2012.09.30.20.57.39 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 30 Sep 2012 20:57:40 -0700 (PDT) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:65045 Archived-At: I agree there is a bug, or maybe a buglet, here, for the reasons you describe, but I'm not sure how to solve it. Does invoking functions through a menu result in an environment where `called-interactively-p' returns non-nil? In that case, the premise behind `bookmark-maybe-historicize-string' is all wrong anyway, and the macro should be rewritten to: `(when (called-interactively-p 'interactive) (setq bookmark-history (cons ,string bookmark-history)))) The issue is larger than just `bookmark-rename', obviously. By the way, your guess is right: it's useful (I think) to have the old name in the history for `bookmark-rename', because someone may want to use it or a variant of it in another bookmark soon. History is cheap that way: it's better to have a little junk than to *not* have the thing the user needs when they need it. Let's tackle the larger issue with `bookmark-maybe-historicize-string', and then figure out whether `bookmark-rename' is doing the right thing. -Karl