From: Lars Ingebrigtsen <larsi@gnus.org>
To: lo2net <fangtao0901@gmail.com>
Cc: schwab@linux-m68k.org, ivan@siamics.net, 11788@debbugs.gnu.org
Subject: bug#11788: [babc40c4] still fails to implement HTTPS over HTTP proxy properly
Date: Fri, 25 Dec 2015 22:31:26 +0100 [thread overview]
Message-ID: <87lh8iz041.fsf@gnus.org> (raw)
In-Reply-To: <87io998qjn.fsf@gmail.com> (lo2net's message of "Sat, 25 Jul 2015 00:32:28 +0800")
lo2net <fangtao0901@gmail.com> writes:
> PS: If without gnutls support, it needs to be modified to use external
> program with https via proxy support(e.g. openssl s_client post-May 2015 release version:
> http://rt.openssl.org/Ticket/Display.html?id=2651) other than just throw an
> error. But I think very few people will need this since this bug report
> stayed with outstanding status for such a long time.
>
> Here is the patch:
I don't use proxies, so I can't test this, but looking at the code
quickly, it looks good. (But see comments below on style.)
Do you have FSF copyright assignments for Emacs on file?
> - (let ((proc (url-open-stream host buf host port gateway-method)))
> + (let ((proc (url-open-stream host buf (if url-using-proxy (url-host url-using-proxy) host) (if url-using-proxy (url-port url-using-proxy) port) gateway-method)))
Lines should preferably not be longer than 80 characters.
> + (url-request-data url-http-data)
> + (url-using-proxy (url-find-proxy-for-url url-current-object (url-host url-current-object)))
> + )
Don't put closing parentheses on separate lines -- they should be on the
previous line.
> - buffer))
> + (process-send-string connection (url-http-create-request))
> + )
> + )
> + )
> + ))
And ditto. :-)
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2015-12-25 21:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-26 10:11 bug#11788: url-http does not properly handle https over proxy Andreas Schwab
2013-12-03 8:31 ` bug#11788: [babc40c4] still fails to implement HTTPS over HTTP proxy properly Ivan Shmakov
2015-07-24 16:32 ` lo2net
2015-12-25 21:31 ` Lars Ingebrigtsen [this message]
2015-12-26 7:24 ` Eli Zaretskii
2015-12-30 16:16 ` lo2net
2015-12-30 16:50 ` Eli Zaretskii
2016-03-08 19:41 ` David Engster
2016-03-08 20:05 ` Eli Zaretskii
2016-03-15 15:47 ` Tao Fang
2016-03-16 16:23 ` Eli Zaretskii
2016-03-20 11:21 ` Lars Magne Ingebrigtsen
2016-03-22 15:31 ` Tao Fang
2016-04-04 20:21 ` Lars Magne Ingebrigtsen
2016-04-05 20:34 ` David Engster
2016-04-06 11:46 ` Lars Magne Ingebrigtsen
2016-04-06 18:01 ` David Engster
2016-04-06 18:09 ` John Wiegley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lh8iz041.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=11788@debbugs.gnu.org \
--cc=fangtao0901@gmail.com \
--cc=ivan@siamics.net \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).