From: Tao Fang <fangtao0901@gmail.com>
To: Lars Magne Ingebrigtsen <larsi@gnus.org>
Cc: 11788@debbugs.gnu.org, schwab@linux-m68k.org, ivan@siamics.net,
David Engster <deng@randomsample.de>
Subject: bug#11788: [babc40c4] still fails to implement HTTPS over HTTP proxy properly
Date: Tue, 22 Mar 2016 23:31:43 +0800 [thread overview]
Message-ID: <8760wesf4w.fsf@gmail.com> (raw)
In-Reply-To: <m31t75l7iy.fsf@gnus.org> (Lars Magne Ingebrigtsen's message of "Sun, 20 Mar 2016 12:21:09 +0100")
[-- Attachment #1: Type: text/plain, Size: 463 bytes --]
Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
> Throughout the code, the lines seem to be too long. They should
> preferably not be more than 80 characters long (unless there's an
> absolute need).
> After negotiation, you should probably call `nsm-verify-connection'.
> Uhm... and that's it. Oh, and a NEWS entry saying that url now
> supports HTTPS proxies would be nice, and a ChangeLog style commit
> message.
Done with it.
Here is the patch file:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-url-https-over-proxy-implement.-Bug-11788.patch --]
[-- Type: text/x-diff, Size: 8609 bytes --]
From 172363d31b3ad5f45da44aa09652d0e0779ef5f2 Mon Sep 17 00:00:00 2001
From: Tao Fang <fangtao0901@gmail.com>
Date: Tue, 22 Mar 2016 22:39:51 +0800
Subject: [PATCH] Fix url https over proxy implement. (Bug#11788)
* lisp/url/url-http.el: Fix url https over proxy implement. (Bug#11788)
* etc/NEWS: Mention this.
---
etc/NEWS | 3 ++
lisp/url/url-http.el | 105 ++++++++++++++++++++++++++++++++++++++++++++-------
2 files changed, 94 insertions(+), 14 deletions(-)
diff --git a/etc/NEWS b/etc/NEWS
index 4414625..7d2cc92 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -1193,6 +1193,9 @@ plist will contain a :peer element that has the output of
programmatically delete all cookies, or cookies from a specific
domain.
++++
+*** The URL package now support https over proxy.
+
** Tramp
+++
diff --git a/lisp/url/url-http.el b/lisp/url/url-http.el
index 33f6d11..4f180ed 100644
--- a/lisp/url/url-http.el
+++ b/lisp/url/url-http.el
@@ -197,7 +197,14 @@ request.")
;; `url-open-stream' needs a buffer in which to do things
;; like authentication. But we use another buffer afterwards.
(unwind-protect
- (let ((proc (url-open-stream host buf host port gateway-method)))
+ (let ((proc (url-open-stream host buf
+ (if url-using-proxy
+ (url-host url-using-proxy)
+ host)
+ (if url-using-proxy
+ (url-port url-using-proxy)
+ port)
+ gateway-method)))
;; url-open-stream might return nil.
(when (processp proc)
;; Drop the temp buffer link before killing the buffer.
@@ -925,7 +932,13 @@ should be shown to the user."
(erase-buffer)
(let ((url-request-method url-http-method)
(url-request-extra-headers url-http-extra-headers)
- (url-request-data url-http-data))
+ (url-request-data url-http-data)
+ (url-using-proxy (url-find-proxy-for-url
+ url-current-object
+ (url-host url-current-object))))
+ (when url-using-proxy
+ (setq url-using-proxy
+ (url-generic-parse-url url-using-proxy)))
(url-http url-current-object url-callback-function
url-callback-arguments (current-buffer)))))
((url-http-parse-headers)
@@ -1209,17 +1222,20 @@ The return value of this function is the retrieval buffer."
(nsm-noninteractive (or url-request-noninteractive
(and (boundp 'url-http-noninteractive)
url-http-noninteractive)))
- (connection (url-http-find-free-connection host port gateway-method))
+ (connection (url-http-find-free-connection (url-host url)
+ (url-port url)
+ gateway-method))
(mime-accept-string url-mime-accept-string)
(buffer (or retry-buffer
(generate-new-buffer
- (format " *http %s:%d*" host port)))))
+ (format " *http %s:%d*" (url-host url) (url-port url))))))
(if (not connection)
;; Failed to open the connection for some reason
(progn
(kill-buffer buffer)
(setq buffer nil)
- (error "Could not create connection to %s:%d" host port))
+ (error "Could not create connection to %s:%d" (url-host url)
+ (url-port url)))
(with-current-buffer buffer
(mm-disable-multibyte)
(setq url-current-object url
@@ -1275,13 +1291,72 @@ The return value of this function is the retrieval buffer."
(set-process-sentinel connection 'url-http-async-sentinel))
(`failed
;; Asynchronous connection failed
- (error "Could not create connection to %s:%d" host port))
+ (error "Could not create connection to %s:%d" (url-host url)
+ (url-port url)))
(_
- (set-process-sentinel connection
- 'url-http-end-of-document-sentinel)
- (process-send-string connection (url-http-create-request))))))
+ (if (and url-http-proxy (string= "https"
+ (url-type url-current-object)))
+ (url-https-proxy-connect connection)
+ (set-process-sentinel connection
+ 'url-http-end-of-document-sentinel)
+ (process-send-string connection (url-http-create-request)))))))
buffer))
+(defun url-https-proxy-connect (connection)
+ (setq url-http-after-change-function 'url-https-proxy-after-change-function)
+ (process-send-string connection (format (concat "CONNECT %s:%d HTTP/1.1\r\n"
+ "Host: %s\r\n"
+ "\r\n")
+ (url-host url-current-object)
+ (or (url-port url-current-object)
+ url-https-default-port)
+ (url-host url-current-object))))
+
+(defun url-https-proxy-after-change-function (st nd length)
+ (let* ((process-buffer (current-buffer))
+ (proc (get-buffer-process process-buffer)))
+ (goto-char (point-min))
+ (when (re-search-forward "^\r?\n" nil t)
+ (backward-char 1)
+ ;; Saw the end of the headers
+ (setq url-http-end-of-headers (set-marker (make-marker) (point)))
+ (url-http-parse-response)
+ (cond
+ ((null url-http-response-status)
+ ;; We got back a headerless malformed response from the
+ ;; server.
+ (url-http-activate-callback)
+ (error "Malformed response from proxy, fail!"))
+ ((= url-http-response-status 200)
+ (if (gnutls-available-p)
+ (condition-case e
+ (let ((tls-connection (gnutls-negotiate
+ :process proc
+ :hostname (url-host url-current-object)
+ :verify-error nil)))
+ ;; check certificate validity
+ (setq tls-connection
+ (nsm-verify-connection tls-connection
+ (url-host url-current-object)
+ (url-port url-current-object)))
+ (with-current-buffer process-buffer (erase-buffer))
+ (set-process-buffer tls-connection process-buffer)
+ (setq url-http-after-change-function
+ 'url-http-wait-for-headers-change-function)
+ (set-process-filter tls-connection 'url-http-generic-filter)
+ (process-send-string tls-connection
+ (url-http-create-request)))
+ (gnutls-error
+ (url-http-activate-callback)
+ (error "gnutls-error: %s" e))
+ (error
+ (url-http-activate-callback)
+ (error "error: %s" e)))
+ (error "error: gnutls support needed!")))
+ (t
+ (url-http-activate-callback)
+ (message "error response: %d" url-http-response-status))))))
+
(defun url-http-async-sentinel (proc why)
;; We are performing an asynchronous connection, and a status change
;; has occurred.
@@ -1293,11 +1368,13 @@ The return value of this function is the retrieval buffer."
(url-http-end-of-document-sentinel proc why))
((string= (substring why 0 4) "open")
(setq url-http-connection-opened t)
- (condition-case error
- (process-send-string proc (url-http-create-request))
- (file-error
- (setq url-http-connection-opened nil)
- (message "HTTP error: %s" error))))
+ (if (and url-http-proxy (string= "https" (url-type url-current-object)))
+ (url-https-proxy-connect proc)
+ (condition-case error
+ (process-send-string proc (url-http-create-request))
+ (file-error
+ (setq url-http-connection-opened nil)
+ (message "HTTP error: %s" error)))))
(t
(setf (car url-callback-arguments)
(nconc (list :error (list 'error 'connection-failed why
--
2.7.4
[-- Attachment #3: Type: text/plain, Size: 194 bytes --]
Feel free to modify the patch, I'm not very familiar with that :)
But I hope the bug can be fixed ASAP since I don't want to modify it
every time when udpate emacs daily build.
--
Emacs/Gnus
next prev parent reply other threads:[~2016-03-22 15:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-26 10:11 bug#11788: url-http does not properly handle https over proxy Andreas Schwab
2013-12-03 8:31 ` bug#11788: [babc40c4] still fails to implement HTTPS over HTTP proxy properly Ivan Shmakov
2015-07-24 16:32 ` lo2net
2015-12-25 21:31 ` Lars Ingebrigtsen
2015-12-26 7:24 ` Eli Zaretskii
2015-12-30 16:16 ` lo2net
2015-12-30 16:50 ` Eli Zaretskii
2016-03-08 19:41 ` David Engster
2016-03-08 20:05 ` Eli Zaretskii
2016-03-15 15:47 ` Tao Fang
2016-03-16 16:23 ` Eli Zaretskii
2016-03-20 11:21 ` Lars Magne Ingebrigtsen
2016-03-22 15:31 ` Tao Fang [this message]
2016-04-04 20:21 ` Lars Magne Ingebrigtsen
2016-04-05 20:34 ` David Engster
2016-04-06 11:46 ` Lars Magne Ingebrigtsen
2016-04-06 18:01 ` David Engster
2016-04-06 18:09 ` John Wiegley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760wesf4w.fsf@gmail.com \
--to=fangtao0901@gmail.com \
--cc=11788@debbugs.gnu.org \
--cc=deng@randomsample.de \
--cc=ivan@siamics.net \
--cc=larsi@gnus.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).