From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#11788: [babc40c4] still fails to implement HTTPS over HTTP proxy properly Date: Fri, 25 Dec 2015 22:31:26 +0100 Message-ID: <87lh8iz041.fsf@gnus.org> References: <87siua8hf1.fsf@violet.siamics.net> <87io998qjn.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1451079144 32663 80.91.229.3 (25 Dec 2015 21:32:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 25 Dec 2015 21:32:24 +0000 (UTC) Cc: schwab@linux-m68k.org, ivan@siamics.net, 11788@debbugs.gnu.org To: lo2net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 25 22:32:13 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aCZy5-0007u7-Lp for geb-bug-gnu-emacs@m.gmane.org; Fri, 25 Dec 2015 22:32:09 +0100 Original-Received: from localhost ([::1]:36518 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aCZy4-0002Ia-I9 for geb-bug-gnu-emacs@m.gmane.org; Fri, 25 Dec 2015 16:32:08 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54474) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aCZy1-0002IF-5m for bug-gnu-emacs@gnu.org; Fri, 25 Dec 2015 16:32:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aCZxx-0002ub-W8 for bug-gnu-emacs@gnu.org; Fri, 25 Dec 2015 16:32:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:56219) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aCZxx-0002uX-ST for bug-gnu-emacs@gnu.org; Fri, 25 Dec 2015 16:32:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aCZxx-0002Ld-Nw for bug-gnu-emacs@gnu.org; Fri, 25 Dec 2015 16:32:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Dec 2015 21:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11788 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11788-submit@debbugs.gnu.org id=B11788.14510791179015 (code B ref 11788); Fri, 25 Dec 2015 21:32:01 +0000 Original-Received: (at 11788) by debbugs.gnu.org; 25 Dec 2015 21:31:57 +0000 Original-Received: from localhost ([127.0.0.1]:35588 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aCZxt-0002LL-Lr for submit@debbugs.gnu.org; Fri, 25 Dec 2015 16:31:57 -0500 Original-Received: from hermes.netfonds.no ([80.91.224.195]:53275) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aCZxq-0002LB-Gu for 11788@debbugs.gnu.org; Fri, 25 Dec 2015 16:31:56 -0500 Original-Received: from 2.150.58.24.tmi.telenormobil.no ([2.150.58.24] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aCZxP-0004ki-4v; Fri, 25 Dec 2015 22:31:27 +0100 In-Reply-To: <87io998qjn.fsf@gmail.com> (lo2net's message of "Sat, 25 Jul 2015 00:32:28 +0800") User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1.50 (gnu/linux) X-MailScanner-ID: 1aCZxP-0004ki-4v MailScanner-NULL-Check: 1451683889.29316@EH51w/CSp/cf6cWI8uDeow X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:110458 Archived-At: lo2net writes: > PS: If without gnutls support, it needs to be modified to use external > program with https via proxy support(e.g. openssl s_client post-May 2015 release version: > http://rt.openssl.org/Ticket/Display.html?id=2651) other than just throw an > error. But I think very few people will need this since this bug report > stayed with outstanding status for such a long time. > > Here is the patch: I don't use proxies, so I can't test this, but looking at the code quickly, it looks good. (But see comments below on style.) Do you have FSF copyright assignments for Emacs on file? > - (let ((proc (url-open-stream host buf host port gateway-method))) > + (let ((proc (url-open-stream host buf (if url-using-proxy (url-host url-using-proxy) host) (if url-using-proxy (url-port url-using-proxy) port) gateway-method))) Lines should preferably not be longer than 80 characters. > + (url-request-data url-http-data) > + (url-using-proxy (url-find-proxy-for-url url-current-object (url-host url-current-object))) > + ) Don't put closing parentheses on separate lines -- they should be on the previous line. > - buffer)) > + (process-send-string connection (url-http-create-request)) > + ) > + ) > + ) > + )) And ditto. :-) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no