bug#22614: 25.1.50; ../../emacs/lisp/net/eww.el:29:1:Error: Symbol’s value as variable is void: image-map

bug#22614: 25.1.50; ../../emacs/lisp/net/eww.el:29:1:Error: Symbol’s value as variable is void: image-map

[Han Boetes]

With todays chekout I run into this output:

[snip]
gmake[2]: Entering directory '/mega/home/han/src/Emacs/openbsd/lisp'
  ELC      net/eww.elc

In toplevel form:
../../emacs/lisp/net/eww.el:29:1:Error: Symbol’s value as variable is void: image-map
Makefile:277: recipe for target 'net/eww.elc' failed
gmake[2]: *** [net/eww.elc] Error 1
gmake[2]: Leaving directory '/mega/home/han/src/Emacs/openbsd/lisp'
Makefile:300: recipe for target 'compile-main' failed
gmake[1]: *** [compile-main] Error 2
gmake[1]: Leaving directory '/mega/home/han/src/Emacs/openbsd/lisp'
Makefile:381: recipe for target 'lisp' failed
gmake: *** [lisp] Error 2


This problem does not occur on debian, just on OpenBSD-5.8




In GNU Emacs 25.1.50.1 (x86_64-unknown-openbsd5.8)
 of 2016-01-09 built on difool
Repository revision: 384cf23c6ed05e1f151032958a2cc2bb8100344b
Configured using:
 'configure --prefix=/usr/local --mandir=/usr/local/man
 --infodir=/usr/local/info --without-sound --without-jpeg --with-xpm
 --without-gif --without-x CC=/usr/local/bin/egcc 'CFLAGS=-pipe -O2''

Configured features:
NOTIFY GNUTLS LIBXML2 ZLIB

Important settings:
  value of $LC_ALL: en_US.UTF-8
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  shell-dirtrack-mode: t
  diff-auto-refine-mode: t
  global-edit-server-edit-mode: t
  icomplete-mode: t
  show-paren-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  size-indication-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent messages:
Setting up indent for shell type zsh
Indentation variables are now local.
Indentation setup for shell type zsh
When done with a buffer, type C-x #
Saving file /mega/home/han/.doit/_mega_home_han_src_Emacs_emacs...
Wrote /mega/home/han/.doit/_mega_home_han_src_Emacs_emacs
When done with this frame, type C-x 5 0
Making completion list...
Quit
Type C-x 1 to remove help window.
Quit [2 times]

Load-path shadows:
/usr/local/share/emacs/25.1.50/lisp/tempo hides ~/.emacs.d/lisp/tempo
/usr/local/share/emacs/25.1.50/lisp/progmodes/python hides ~/.emacs.d/lisp/python
/usr/local/share/emacs/25.1.50/lisp/obsolete/longlines hides ~/.emacs.d/lisp/longlines
/usr/local/share/emacs/25.1.50/lisp/textmodes/css-mode hides ~/.emacs.d/lisp/css-mode
/mega/home/han/.emacs.d/elpa/crontab-mode-20090510.1355/crontab-mode hides ~/.emacs.d/lisp/crontab-mode

Features:
(skeleton bug-reference map qp debug pp shadow sort mail-extr emacsbug
eieio-opt speedbar sb-image ezimage dframe find-func apropos autorevert
filenotify log4j-mode advice git-commit-mode log-edit pcvs-util add-log
make-mode crontab-mode lisp-mnt mm-archive message idna sendmail dired
dired-loaddefs format-spec rfc822 mml mml-sec mailabbrev gmm-utils
mailheader mm-decode mm-bodies mm-encode mail-utils network-stream nsm
starttls url-http tls gnutls mail-parse rfc2231 rfc2047 rfc2045
ietf-drums url-gw puny url-cache url-auth url url-proxy url-privacy
url-expand url-methods url-history url-cookie url-domsuf url-util
mailcap epg rect muttrc-mode man shell pcomplete grep compile comint
ansi-color ring tar-mode jka-compr parse-time vc-cvs cc-mode cc-fonts
cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs
conf-mode character-fold misearch multi-isearch vc vc-dispatcher vc-git
diff-mode generic image sh-script smie executable nuke-whitespace seq
post term/xterm xterm server pager auto-recomp cl session generic-x
yaml-mode derived regexp-opt edit-server easy-mmode edmacro kmacro
icomplete finder-inf info tool-bar tex-site package epg-config
url-handlers url-parse auth-source cl-seq eieio byte-opt bytecomp
byte-compile cl-extra cconv eieio-core cl-macs gv eieio-loaddefs
gnus-util mm-util help-fns help-mode easymenu cl-loaddefs pcase cl-lib
mail-prsvr password-cache url-vars time-date paren mule-util tooltip
eldoc electric uniquify ediff-hook vc-hooks lisp-float-type
tabulated-list newcomment elisp-mode lisp-mode prog-mode register page
menu-bar rfn-eshadow timer select mouse jit-lock font-lock syntax
facemenu font-core frame cl-generic cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932
hebrew greek romanian slovak czech european ethiopic indian cyrillic
chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev
obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face
macroexp files text-properties overlay sha1 md5 base64 format env
code-pages mule custom widget hashtable-print-readable backquote kqueue
multi-tty make-network-process emacs)

Memory information:
((conses 16 244421 277946)
 (symbols 48 32289 35)
 (miscs 40 108 670)
 (strings 32 69957 51005)
 (string-bytes 1 2375633)
 (vectors 16 34024)
 (vector-slots 8 1495178 150791)
 (floats 8 277 863)
 (intervals 56 850 1466)
 (buffers 976 25))

--



# Han
--
#!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj
$/=unpack('H*',$_);$_=`echo 16dio\U$k"SK$/SM$n\EsN0p[lN*1
lK[d2%Sa2/d0$^Ixp"|dc`;s/\W//g;$_=pack('H*',/((..)*)$/)

bug#22614: 25.1.50; ../../emacs/lisp/net/eww.el:29:1:Error: Symbol’s value as variable is void: image-map

[Wolfgang Jenkner]

On Wed, Feb 10 2016, Han Boetes wrote:

> ../../emacs/lisp/net/eww.el:29:1:Error: Symbol’s value as variable is void: image-map
> Makefile:277: recipe for target 'net/eww.elc' failed
[...]
> This problem does not occur on debian, just on OpenBSD-5.8
[...]
>  --without-gif --without-x CC=/usr/local/bin/egcc 'CFLAGS=-pipe -O2''

If the configuration of the broken build is similar to the above,
image.el is not contained in the dumped emacs, so I just pushed the
following fix to master to unbreak the build and mark this bug report as
done.

Subject: [PATCH] * lisp/net/shr.el (image-map): Defvar it.  (Bug#22614)

---
 lisp/net/shr.el | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lisp/net/shr.el b/lisp/net/shr.el
index 339f877..b1f2f07 100644
--- a/lisp/net/shr.el
+++ b/lisp/net/shr.el
@@ -189,6 +189,8 @@ shr-map
     (define-key map "\r" 'shr-browse-url)
     map))
 
+(defvar image-map nil)                  ;in case image.el is not pre-loaded
+
 (defvar shr-image-map
   (let ((map (copy-keymap shr-map)))
     (set-keymap-parent map image-map)
-- 
2.7.0

bug#22614: closed (Re: bug#22614: 25.1.50; ../../emacs/lisp/net/eww.el:29:1:Error: Symbol’s value as variable is void: image-map)

[Han Boetes]

I can confirm that this patch fixes the issue for me.

LG, Han

bug#22614: closed (Re: bug#22614: 25.1.50; ../../emacs/lisp/net/eww.el:29:1:Error: Symbol’s value as variable is void: image-map)

[Wolfgang Jenkner]

On Wed, Feb 10 2016, Han Boetes wrote:

> I can confirm that this patch fixes the issue for me.

Thanks.  Actually, image-map contains a binding for image-save, which
would be useful on a non-graphical emacs as well, but I leave this to
Lars :-)

bug#22614: closed (Re: bug#22614: 25.1.50; ../../emacs/lisp/net/eww.el:29:1:Error: Symbol’s value as variable is void: image-map)

[Wolfgang Jenkner]

On Wed, Feb 10 2016, Wolfgang Jenkner wrote:

> On Wed, Feb 10 2016, Han Boetes wrote:
>
>> I can confirm that this patch fixes the issue for me.
>
> Thanks.  Actually, image-map contains a binding for image-save, which
> would be useful on a non-graphical emacs as well, but I leave this to
> Lars :-)

Except that configuring --without-x seems to exclude any image library
support so there's no legal way to create `display' text properties with
image data in this case, but image-save uses them.  So, image-map is
really useless in this case, after all.

bug#22614: 25.1.50; ../../emacs/lisp/net/eww.el:29:1:Error: Symbol’s value as variable is void: image-map

[Glenn Morris]

Wolfgang Jenkner wrote:

> --- a/lisp/net/shr.el
> +++ b/lisp/net/shr.el
> @@ -189,6 +189,8 @@ shr-map
>      (define-key map "\r" 'shr-browse-url)
>      map))
>  
> +(defvar image-map nil)                  ;in case image.el is not pre-loaded
> +

This (ie, defining something from image.el in shr.el just to stop a void
variable error) seems sub-optimal to me. Can't shr use something like
"(when (featurep 'image) ...)" instead?

bug#22614: 25.1.50; ../../emacs/lisp/net/eww.el:29:1:Error: Symbol’s value as variable is void: image-map

[Lars Ingebrigtsen]

Glenn Morris <rgm@gnu.org> writes:

> This (ie, defining something from image.el in shr.el just to stop a void
> variable error) seems sub-optimal to me. Can't shr use something like
> "(when (featurep 'image) ...)" instead?

Yeah, I think that's a better idea.  I'll make the change.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#22614: closed (Re: bug#22614: 25.1.50; ../../emacs/lisp/net/eww.el:29:1:Error: Symbol’s value as variable is void: image-map)

[Lars Ingebrigtsen]

Wolfgang Jenkner <wjenkner@inode.at> writes:

> Except that configuring --without-x seems to exclude any image library
> support so there's no legal way to create `display' text properties with
> image data in this case, but image-save uses them.  So, image-map is
> really useless in this case, after all.

Yeah, I think so too...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#22614: 25.1.50; ../../emacs/lisp/net/eww.el:29:1:Error: Symbol’s value as variable is void: image-map

[Andreas Schwab]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Glenn Morris <rgm@gnu.org> writes:
>
>> This (ie, defining something from image.el in shr.el just to stop a void
>> variable error) seems sub-optimal to me. Can't shr use something like
>> "(when (featurep 'image) ...)" instead?
>
> Yeah, I think that's a better idea.  I'll make the change.

That changes the behaviour depending on the load order of shr
vs. image.  Why doesn't shr require image?

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

bug#22614: 25.1.50; ../../emacs/lisp/net/eww.el:29:1:Error: Symbol’s value as variable is void: image-map

[Wolfgang Jenkner]

On Wed, Feb 10 2016, Glenn Morris wrote:

> Wolfgang Jenkner wrote:
>
>> --- a/lisp/net/shr.el
>> +++ b/lisp/net/shr.el
>> @@ -189,6 +189,8 @@ shr-map
>>      (define-key map "\r" 'shr-browse-url)
>>      map))
>>  
>> +(defvar image-map nil)                  ;in case image.el is not pre-loaded
>> +
>
> This (ie, defining something from image.el in shr.el just to stop a void
> variable error) seems sub-optimal to me. Can't shr use something like
> "(when (featurep 'image) ...)" instead?

Well, you still get `image-map' as an interned symbol and I think it's
actually better to explicitly give it a nil value since the value it is
given in image.el is not too useful in an emacs where image.el is not
pre-loaded, i.e. compiled without graphical support (actually, it seems
to be completely useless, see other messages in this bug report).

Obviously, I considered your (and also Andreas') suggestion as well,
I decided otherwise, but I don't care (much).

Wolfgang

bug#22614: 25.1.50; ../../emacs/lisp/net/eww.el:29:1:Error: Symbol’s value as variable is void: image-map

[Lars Ingebrigtsen]

Andreas Schwab <schwab@suse.de> writes:

> That changes the behaviour depending on the load order of shr
> vs. image.  Why doesn't shr require image?

Isn't image.el dumped with Emacs if Emacs has image support?  That's
what I assumed, anyway...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no