From: npostavs@users.sourceforge.net
To: Dima Kogan <dima@secretsauce.net>
Cc: Andreas Schwab <schwab@linux-m68k.org>, 17544@debbugs.gnu.org
Subject: bug#17544: 24.3; [PATCH] Improved diff-mode navigation/manipulation
Date: Wed, 16 Nov 2016 23:33:23 -0500 [thread overview]
Message-ID: <87lgwilo8c.fsf@users.sourceforge.net> (raw)
In-Reply-To: <878tsihhhl.fsf@secretsauce.net> (Dima Kogan's message of "Wed, 16 Nov 2016 20:15:34 -0800")
Dima Kogan <dima@secretsauce.net> writes:
> New patch attached.
>
[...]
> +
> + ;; I advance to the next hunk with skip-hunk-start set to t
> + ;; because I want the behavior of moving to the next logical
> + ;; hunk, not the legacy behavior where were would sometimes stay
> + ;; on the curent hunk. This is the behavior we get when
> + ;; navigating through hunks interactively, and we want it when
> + ;; applying hunks too. See http://debbugs.gnu.org/17544
> (when diff-advance-after-apply-hunk
> - (diff-hunk-next))))))
> + (diff-hunk-next nil t))))))
Can you mention somewhere about avoiding an infinite loop that you were
talking about before? (that's what I meant when I said to update this
comment, but if it actually makes more sense to mention that somewhere
else, please do so)
Is it really a "legacy" behavior (considering that we *need* the "legacy"
behavior in order to function correctly)?
Also, I believe usual comment style is to use "we" not "I", and you
didn't end the last sentence with a period.
next prev parent reply other threads:[~2016-11-17 4:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-21 12:21 bug#17544: 24.3; [PATCH] Improved diff-mode navigation/manipulation Dima Kogan
2016-02-24 2:33 ` Lars Ingebrigtsen
2016-09-03 9:17 ` Dima Kogan
2016-09-03 10:14 ` Eli Zaretskii
2016-09-03 21:24 ` Dima Kogan
2016-09-04 3:27 ` npostavs
2016-09-07 7:14 ` Dima Kogan
2016-09-14 22:31 ` Dima Kogan
2016-09-23 7:22 ` Dima Kogan
2016-10-22 15:47 ` npostavs
2016-10-23 1:44 ` Dima Kogan
2016-10-23 2:49 ` npostavs
2016-11-07 2:26 ` Dima Kogan
2016-11-15 3:31 ` npostavs
2016-11-17 4:15 ` Dima Kogan
2016-11-17 4:33 ` npostavs [this message]
2016-11-17 8:05 ` Dima Kogan
2016-11-20 2:37 ` npostavs
2016-11-21 7:23 ` Dima Kogan
2016-11-23 0:42 ` npostavs
2016-11-23 21:11 ` Dima Kogan
2016-11-29 4:10 ` npostavs
2016-09-13 3:56 ` Dima Kogan
2016-09-03 11:05 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgwilo8c.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=17544@debbugs.gnu.org \
--cc=dima@secretsauce.net \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).