From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#17544: 24.3; [PATCH] Improved diff-mode navigation/manipulation Date: Wed, 16 Nov 2016 23:33:23 -0500 Message-ID: <87lgwilo8c.fsf@users.sourceforge.net> References: <87ha4jgw53.fsf@secretsauce.net> <87si0ion1c.fsf@gnus.org> <87k2et8hr4.fsf@secretsauce.net> <83a8fpe1dr.fsf@gnu.org> <87h99w8ynv.fsf@secretsauce.net> <87k2es9weh.fsf@users.sourceforge.net> <87oa4018r3.fsf@secretsauce.net> <87twdi6rm9.fsf@secretsauce.net> <87h997nkqp.fsf@secretsauce.net> <874m44tmge.fsf@users.sourceforge.net> <87h983rg9c.fsf@secretsauce.net> <87mvhvsrta.fsf@users.sourceforge.net> <87wpgge0kl.fsf@secretsauce.net> <87twb9l8qi.fsf@users.sourceforge.net> <878tsihhhl.fsf@secretsauce.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1479357199 6674 195.159.176.226 (17 Nov 2016 04:33:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 17 Nov 2016 04:33:19 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Cc: Andreas Schwab , 17544@debbugs.gnu.org To: Dima Kogan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 17 05:33:14 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c7ENu-0000P7-MF for geb-bug-gnu-emacs@m.gmane.org; Thu, 17 Nov 2016 05:33:14 +0100 Original-Received: from localhost ([::1]:56684 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c7ENu-0003Q7-Rt for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Nov 2016 23:33:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44322) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c7ENl-0003Pq-Uc for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2016 23:33:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c7ENi-0001N0-TP for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2016 23:33:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44654) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c7ENi-0001Mo-Ps for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2016 23:33:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1c7ENi-0003MJ-Fl for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2016 23:33:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Nov 2016 04:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17544 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 17544-submit@debbugs.gnu.org id=B17544.147935716112877 (code B ref 17544); Thu, 17 Nov 2016 04:33:02 +0000 Original-Received: (at 17544) by debbugs.gnu.org; 17 Nov 2016 04:32:41 +0000 Original-Received: from localhost ([127.0.0.1]:60053 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c7ENN-0003Ld-Ir for submit@debbugs.gnu.org; Wed, 16 Nov 2016 23:32:41 -0500 Original-Received: from mail-it0-f66.google.com ([209.85.214.66]:34760) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c7ENL-0003LO-MY for 17544@debbugs.gnu.org; Wed, 16 Nov 2016 23:32:40 -0500 Original-Received: by mail-it0-f66.google.com with SMTP id o1so12380544ito.1 for <17544@debbugs.gnu.org>; Wed, 16 Nov 2016 20:32:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=xsuXY8vhSMEbWJGhREr+fl4UvWb8qIXSRM77CwkJJsQ=; b=tYPdEkHWihyKZV1MM2wQVR3AjJBUGtBEbQxkO0esCC8/jAiNUXOrxuNaDU2BpR5D/r z/X73R3BTichUU8KzjUqHZ7CjFjs1DHNgSrcGbNicUcZzsECJkgeALWDd8zdxQppVCQV S0fjFb4llUSLT2NvTAgGnzhzaMAEfCMyY9p0Hq/YygkMrO/ogB0iajoeqt+kgtc6R1bR /n0Cj+EpPzCTyLf+KQFV/K2HiefP2MZms1mpzXOxIxl/7a/YuoBXKqD5kNjpJ24fxLcq xxjnsbnP2eMTrwaEiYnrpOg9CELoOtu/MQ7z7p6JeQdl7qIeEmy/oK5GLr8CSQaslVmB 2Xsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=xsuXY8vhSMEbWJGhREr+fl4UvWb8qIXSRM77CwkJJsQ=; b=kYmLaDN7Rm0NxQYFn6h84X7BO5Dj6TRFgcJIZIaXSGOig1d17osr/1eCdZFoyeavcJ qLyXOgC9k/ZeW2cc53Saw/xtx+OS6eif65mjYKpVblZ7fcNk6MV3Tz0hGUJsvjlt67s2 PwIaNAttvxLp/sCzP4t5X7PqxJCop1GLZ0zEd+H3dHmF7M4YtJ8HniQdU3t+G69ElYHF kbtRPHmrXlM6ImNdSkmRcB+FCseGYXPQSfqhKsEnJDRxuiNRR6SfrRzfKB8z2RKNzbsM DKKi3ZMW0xYjDI7N7WWco0UEtTyx56n+y3beZFDuIINuE5E9uShJXfRgJ6HFI48AB284 A/Lg== X-Gm-Message-State: ABUngvclz/yHidfmPIwxQjokpkuCDRQeh89lhBUupAS+gWybUrdtqmpPI6fJLxP7moB6Bg== X-Received: by 10.36.37.199 with SMTP id g190mr1306701itg.66.1479357153899; Wed, 16 Nov 2016 20:32:33 -0800 (PST) Original-Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id p20sm5218834itc.2.2016.11.16.20.32.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 16 Nov 2016 20:32:33 -0800 (PST) In-Reply-To: <878tsihhhl.fsf@secretsauce.net> (Dima Kogan's message of "Wed, 16 Nov 2016 20:15:34 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:125780 Archived-At: Dima Kogan writes: > New patch attached. > [...] > + > + ;; I advance to the next hunk with skip-hunk-start set to t > + ;; because I want the behavior of moving to the next logical > + ;; hunk, not the legacy behavior where were would sometimes stay > + ;; on the curent hunk. This is the behavior we get when > + ;; navigating through hunks interactively, and we want it when > + ;; applying hunks too. See http://debbugs.gnu.org/17544 > (when diff-advance-after-apply-hunk > - (diff-hunk-next)))))) > + (diff-hunk-next nil t)))))) Can you mention somewhere about avoiding an infinite loop that you were talking about before? (that's what I meant when I said to update this comment, but if it actually makes more sense to mention that somewhere else, please do so) Is it really a "legacy" behavior (considering that we *need* the "legacy" behavior in order to function correctly)? Also, I believe usual comment style is to use "we" not "I", and you didn't end the last sentence with a period.