From: Damien Cassou <damien@cassou.me>
To: "João Távora" <joaotavora@gmail.com>
Cc: 38284@debbugs.gnu.org, Nicolas Petton <nicolas@petton.fr>
Subject: bug#38284: 27.0.50; [PATCH] Make auth-source-pass-search understand port lists
Date: Fri, 22 Nov 2019 09:49:20 +0100 [thread overview]
Message-ID: <87lfs8thwv.fsf@cassou.me> (raw)
In-Reply-To: <CALDnm53fsq6QBfLVQkpsY=et4T0zj8zUEPdPaWfSKzf0bgPVmQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 694 bytes --]
Hi João,
João Távora <joaotavora@gmail.com> writes:
>> can you please rename "d" to "domain"?
>
> ok. I do call your attention that it was already the
> single letter n there
yes I saw. This should never have been merged like that. Thank you for
improving the code.
>> Can you please add a unit test covering this new use-case?
>
> No. This is too much work for such a trivial change
I care a lot about the automated testing of the code I write. I won't
try to convince you though. Can you please merge the attached patch with
yours?
--
Damien Cassou
"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-WIP.patch --]
[-- Type: text/x-patch, Size: 1118 bytes --]
From afd2ebb80c80573447ec1dc23bc1625f9b41046a Mon Sep 17 00:00:00 2001
From: Damien Cassou <damien@cassou.me>
Date: Fri, 22 Nov 2019 09:36:44 +0100
Subject: [PATCH] WIP
---
test/auth-source-pass-tests.el | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/test/auth-source-pass-tests.el b/test/auth-source-pass-tests.el
index bec42a5..ed1752d 100644
--- a/test/auth-source-pass-tests.el
+++ b/test/auth-source-pass-tests.el
@@ -353,6 +353,10 @@ (ert-deftest auth-source-pass--matching-entries-find-entries-with-a-port ()
(auth-source-pass--with-store '(("bar.com:8080"))
(should (auth-source-pass-match-entry-p "bar.com:8080" "bar.com" nil "8080"))))
+(ert-deftest auth-source-pass--matching-entries-find-entries-with-a-port-when-passed-multiple-ports ()
+ (auth-source-pass--with-store '(("bar.com:8080"))
+ (should (auth-source-pass-match-entry-p "bar.com:8080" "bar.com" nil '("http" "https" "80" "8080")))))
+
(ert-deftest auth-source-pass--matching-entries-find-entries-with-slash ()
;; match if entry filename matches user
(auth-source-pass--with-store '(("foo.com/user"))
--
2.23.0
next prev parent reply other threads:[~2019-11-22 8:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 0:20 bug#38284: 27.0.50; [PATCH] Make auth-source-pass-search understand port lists João Távora
2019-11-21 13:47 ` Lars Ingebrigtsen
2019-11-21 18:27 ` Damien Cassou
2019-11-21 19:06 ` João Távora
2019-11-22 8:49 ` Damien Cassou [this message]
2019-11-22 9:35 ` João Távora
2020-01-20 18:54 ` Stefan Kangas
2020-01-21 19:25 ` Damien Cassou
2020-01-22 8:02 ` Stefan Kangas
2020-01-22 9:22 ` Damien Cassou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfs8thwv.fsf@cassou.me \
--to=damien@cassou.me \
--cc=38284@debbugs.gnu.org \
--cc=joaotavora@gmail.com \
--cc=nicolas@petton.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).