From: Damien Cassou <damien@cassou.me>
To: "João Távora" <joaotavora@gmail.com>, 38284@debbugs.gnu.org
Cc: Nicolas Petton <nicolas@petton.fr>
Subject: bug#38284: 27.0.50; [PATCH] Make auth-source-pass-search understand port lists
Date: Thu, 21 Nov 2019 19:27:34 +0100 [thread overview]
Message-ID: <874kyxt78p.fsf@cassou.me> (raw)
In-Reply-To: <87ftijz9df.fsf@gmail.com>
Hi João,
João Távora <joaotavora@gmail.com> writes:
> […] Eventually I came to this patch, which seems to do the right
> thing.
great job, thank you. Some feedback below.
> (let ((domains (auth-source-pass--domains (split-string hostname "\\."))))
> - (seq-mapcat (lambda (n)
> - (auth-source-pass--name-port-user-suffixes n user port))
> + (seq-mapcat (lambda (d)
can you please rename "d" to "domain"?
> + (seq-mapcat
> + (lambda (p)
same for "p".
> + (auth-source-pass--name-port-user-suffixes d user p))
> + (if (listp port) port (list port))))
> domains)))
Can you please add a unit test covering this new use-case?
--
Damien Cassou
"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill
next prev parent reply other threads:[~2019-11-21 18:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 0:20 bug#38284: 27.0.50; [PATCH] Make auth-source-pass-search understand port lists João Távora
2019-11-21 13:47 ` Lars Ingebrigtsen
2019-11-21 18:27 ` Damien Cassou [this message]
2019-11-21 19:06 ` João Távora
2019-11-22 8:49 ` Damien Cassou
2019-11-22 9:35 ` João Távora
2020-01-20 18:54 ` Stefan Kangas
2020-01-21 19:25 ` Damien Cassou
2020-01-22 8:02 ` Stefan Kangas
2020-01-22 9:22 ` Damien Cassou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kyxt78p.fsf@cassou.me \
--to=damien@cassou.me \
--cc=38284@debbugs.gnu.org \
--cc=joaotavora@gmail.com \
--cc=nicolas@petton.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).