From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Damien Cassou Newsgroups: gmane.emacs.bugs Subject: bug#38284: 27.0.50; [PATCH] Make auth-source-pass-search understand port lists Date: Fri, 22 Nov 2019 09:49:20 +0100 Message-ID: <87lfs8thwv.fsf@cassou.me> References: <87ftijz9df.fsf@gmail.com> <874kyxt78p.fsf@cassou.me> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="23425"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 38284@debbugs.gnu.org, Nicolas Petton To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 22 09:50:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iY4dp-0005w5-NM for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 Nov 2019 09:50:13 +0100 Original-Received: from localhost ([::1]:48664 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iY4do-0000Cb-GV for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 Nov 2019 03:50:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47924) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iY4dg-0000AN-KT for bug-gnu-emacs@gnu.org; Fri, 22 Nov 2019 03:50:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iY4df-0001D0-GX for bug-gnu-emacs@gnu.org; Fri, 22 Nov 2019 03:50:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44911) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iY4df-0001Cu-BV for bug-gnu-emacs@gnu.org; Fri, 22 Nov 2019 03:50:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iY4df-00080O-3z for bug-gnu-emacs@gnu.org; Fri, 22 Nov 2019 03:50:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Damien Cassou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Nov 2019 08:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38284 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 38284-submit@debbugs.gnu.org id=B38284.157441256830726 (code B ref 38284); Fri, 22 Nov 2019 08:50:02 +0000 Original-Received: (at 38284) by debbugs.gnu.org; 22 Nov 2019 08:49:28 +0000 Original-Received: from localhost ([127.0.0.1]:53732 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iY4d6-0007zW-HH for submit@debbugs.gnu.org; Fri, 22 Nov 2019 03:49:28 -0500 Original-Received: from mail.choca.pics ([62.210.108.126]:39896) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iY4d3-0007zM-1n for 38284@debbugs.gnu.org; Fri, 22 Nov 2019 03:49:25 -0500 Original-Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 8AC34F1C3C2; Fri, 22 Nov 2019 09:49:23 +0100 (CET) Original-Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10032) with ESMTP id qMbSTu4hTtSW; Fri, 22 Nov 2019 09:49:22 +0100 (CET) Original-Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 57591F1C479; Fri, 22 Nov 2019 09:49:22 +0100 (CET) X-Virus-Scanned: amavisd-new at choca.pics Original-Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10026) with ESMTP id zd3Mqko655QZ; Fri, 22 Nov 2019 09:49:22 +0100 (CET) Original-Received: from luz4 (unknown [86.215.189.124]) by mail.choca.pics (Postfix) with ESMTPSA id 06375F1C3C2; Fri, 22 Nov 2019 09:49:21 +0100 (CET) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172208 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Jo=C3=A3o, Jo=C3=A3o T=C3=A1vora writes: >> can you please rename "d" to "domain"? > > ok. I do call your attention that it was already the > single letter n there yes I saw. This should never have been merged like that. Thank you for improving the code. >> Can you please add a unit test covering this new use-case? > > No. This is too much work for such a trivial change I care a lot about the automated testing of the code I write. I won't try to convince you though. Can you please merge the attached patch with yours? --=20 Damien Cassou "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-WIP.patch >From afd2ebb80c80573447ec1dc23bc1625f9b41046a Mon Sep 17 00:00:00 2001 From: Damien Cassou Date: Fri, 22 Nov 2019 09:36:44 +0100 Subject: [PATCH] WIP --- test/auth-source-pass-tests.el | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/test/auth-source-pass-tests.el b/test/auth-source-pass-tests.el index bec42a5..ed1752d 100644 --- a/test/auth-source-pass-tests.el +++ b/test/auth-source-pass-tests.el @@ -353,6 +353,10 @@ (ert-deftest auth-source-pass--matching-entries-find-entries-with-a-port () (auth-source-pass--with-store '(("bar.com:8080")) (should (auth-source-pass-match-entry-p "bar.com:8080" "bar.com" nil "8080")))) +(ert-deftest auth-source-pass--matching-entries-find-entries-with-a-port-when-passed-multiple-ports () + (auth-source-pass--with-store '(("bar.com:8080")) + (should (auth-source-pass-match-entry-p "bar.com:8080" "bar.com" nil '("http" "https" "80" "8080"))))) + (ert-deftest auth-source-pass--matching-entries-find-entries-with-slash () ;; match if entry filename matches user (auth-source-pass--with-store '(("foo.com/user")) -- 2.23.0 --=-=-=--