unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Tino Calancha <tino.calancha@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 31772@debbugs.gnu.org, tino.calancha@gmail.com,
	Noam Postavsky <npostavs@users.sourceforge.net>,
	Dmitry Gutov <dgutov@yandex.ru>, Leo Liu <sdl.web@gmail.com>
Subject: bug#31772: 26.1; (thing-at-point 'list) regression
Date: Mon, 11 Jun 2018 00:21:35 +0900	[thread overview]
Message-ID: <87k1r6acqo.fsf@gmail.com> (raw)
In-Reply-To: <838t7msmy1.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 10 Jun 2018 18:03:50 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

>> Due to change
>> 
>> commit 76e297c15f6312a83599aab216be0396e9aac5c5
>> Author: Tino Calancha
>> Date:   Thu Nov 3 20:33:19 2016 +0900
>> 
>> (thing-at-point 'list) no longer works in comments; always return nil.
>
> Should it?  AFACS, in Emacs 25 the above returned nonsensical values
> when invoked inside Lisp comments.

[CC the relevant thingatpt experts]

Initially I thought that; after discuss with Emacs colleages
I changed my mine.

If you are in a buffer in emacs-lisp-mode, I just see
one list of length 3 in the following line:
("foo" "(bar)" "baz")

"(bar)" is a string.

If we comment the line, then there is no list at all; just a comment.
That is tested in thingatpt-tests.el (thing-at-point-bug24627).

You could change to fundamental-mode, then you would get again
the full list: because the line is not commented anymore.

To me this behaviour has sense, and it's predictible.  Maybe others
disagree.

PD: I must admit I am a bit worry everytime we start discussing
about this lib... :-S





  reply	other threads:[~2018-06-10 15:21 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-10  3:58 bug#31772: 26.1; (thing-at-point 'list) regression Leo Liu
2018-06-10 15:03 ` Eli Zaretskii
2018-06-10 15:21   ` Tino Calancha [this message]
2018-06-11  3:17     ` Leo Liu
2018-06-11 15:06       ` Tino Calancha
2018-06-11 16:08         ` Leo Liu
2018-06-11 16:25           ` Tino Calancha
2018-09-06 10:37             ` Leo Liu
2018-09-06 19:01               ` Andreas Röhler
2018-09-07  4:42                 ` Leo Liu
2018-09-07  8:17                   ` Andreas Röhler
2018-09-08  0:09                     ` Leo Liu
2018-09-11  8:31               ` Eli Zaretskii
2018-09-11 10:26                 ` Leo Liu
2018-09-11 11:16                   ` Eli Zaretskii
2018-09-11 11:52                     ` Andreas Röhler
2018-09-11 12:10                       ` Eli Zaretskii
2018-09-11 12:36                     ` Leo Liu
2018-09-11 12:39                       ` Eli Zaretskii
2018-09-14 14:55                         ` Leo Liu
2018-09-15  9:06                           ` Eli Zaretskii
2018-09-15 12:58                             ` Leo Liu
2018-09-15 13:28                               ` Eli Zaretskii
2018-06-11 16:34           ` Eli Zaretskii
2018-06-11 15:10       ` Eli Zaretskii
2018-06-11 16:36         ` Leo Liu
2018-06-11  2:32   ` Leo Liu
2018-06-11 14:58     ` Eli Zaretskii
2018-06-11 17:04       ` Leo Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k1r6acqo.fsf@gmail.com \
    --to=tino.calancha@gmail.com \
    --cc=31772@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    --cc=eliz@gnu.org \
    --cc=npostavs@users.sourceforge.net \
    --cc=sdl.web@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).