From: "Andreas Röhler" <andreas.roehler@easy-emacs.de>
To: Leo Liu <sdl.web@gmail.com>
Cc: 31772@debbugs.gnu.org
Subject: bug#31772: 26.1; (thing-at-point 'list) regression
Date: Thu, 6 Sep 2018 21:01:55 +0200 [thread overview]
Message-ID: <27715d72-6339-f1ca-23e5-4426d822b84c@easy-emacs.de> (raw)
In-Reply-To: <m1h8j2ykrs.fsf@gmail.com>
On 06.09.2018 12:37, Leo Liu wrote:
> Hi there,
>
> I have been using 26.1 as my main editor for the last few months and
> this breakage remains a pain point in my day-to-day editing. For example
> whenever I rewrite a function, I normally comment out the old one (to
> keep the linter, pretty-printer or whatnot happy) and write the new one
> from scratch, occasionally copy things from the old one to save typing
> and this bug gets in the way many times a day. I propose a patch that
> doesn't divert too much from the old and tried behaviour.
>
> The idea that is currently in thing-at-point-bounds-of-list-at-point is
> fine for a higher level function such as list-at-point but doing it
> there affects all functions that build on it including some from
> thingatpt.el itself.
>
> I hope you can find time to review the patch and come to a solution for
> 26.2 which I very much look forward to.
>
> Thanks,
> Leo
>
Hi Leo,
lets consider the following proposed change of tests:
- ("(foo\n(a ;(b c d)\ne) bar)" . (a e))
+ ("(foo\n(a ;(b c d)\ne) bar)" . (foo (a e) bar))
As the ert-test mentioned calls (re-search-backward "\\((a\\|^a\\)")
point will be behind foo at "(a". I.e. "foo" belongs to outer list, not
to list-at-point. The desired result shown by this change looks wrong,
"(foo" should not be part of.
Maybe I'm missing something.
May you provide a standalone example where current behavior breaks your
code?
Thanks,
Andreas
gladly using GNU Emacs 27.0.50 (build 1, i686-pc-linux-gnu, GTK+ Version
3.14.5) of 2018-08-29
next prev parent reply other threads:[~2018-09-06 19:01 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-10 3:58 bug#31772: 26.1; (thing-at-point 'list) regression Leo Liu
2018-06-10 15:03 ` Eli Zaretskii
2018-06-10 15:21 ` Tino Calancha
2018-06-11 3:17 ` Leo Liu
2018-06-11 15:06 ` Tino Calancha
2018-06-11 16:08 ` Leo Liu
2018-06-11 16:25 ` Tino Calancha
2018-09-06 10:37 ` Leo Liu
2018-09-06 19:01 ` Andreas Röhler [this message]
2018-09-07 4:42 ` Leo Liu
2018-09-07 8:17 ` Andreas Röhler
2018-09-08 0:09 ` Leo Liu
2018-09-11 8:31 ` Eli Zaretskii
2018-09-11 10:26 ` Leo Liu
2018-09-11 11:16 ` Eli Zaretskii
2018-09-11 11:52 ` Andreas Röhler
2018-09-11 12:10 ` Eli Zaretskii
2018-09-11 12:36 ` Leo Liu
2018-09-11 12:39 ` Eli Zaretskii
2018-09-14 14:55 ` Leo Liu
2018-09-15 9:06 ` Eli Zaretskii
2018-09-15 12:58 ` Leo Liu
2018-09-15 13:28 ` Eli Zaretskii
2018-06-11 16:34 ` Eli Zaretskii
2018-06-11 15:10 ` Eli Zaretskii
2018-06-11 16:36 ` Leo Liu
2018-06-11 2:32 ` Leo Liu
2018-06-11 14:58 ` Eli Zaretskii
2018-06-11 17:04 ` Leo Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27715d72-6339-f1ca-23e5-4426d822b84c@easy-emacs.de \
--to=andreas.roehler@easy-emacs.de \
--cc=31772@debbugs.gnu.org \
--cc=sdl.web@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).