From: Lars Ingebrigtsen <larsi@gnus.org>
To: Ken Brown <kbrown@cornell.edu>
Cc: "23540@debbugs.gnu.org" <23540@debbugs.gnu.org>,
"23508@debbugs.gnu.org" <23508@debbugs.gnu.org>
Subject: bug#23508: bug#23540: 25.1.50; make-ipv4-tcp-server-with-unspecified-port fails
Date: Thu, 24 Oct 2019 13:48:03 +0200 [thread overview]
Message-ID: <87k18ufjpo.fsf@gnus.org> (raw)
In-Reply-To: <d5cfe64c-3729-b184-492a-d714dcde3c38@cornell.edu> (Ken Brown's message of "Wed, 23 Oct 2019 16:31:08 +0000")
Ken Brown <kbrown@cornell.edu> writes:
>>>> Presumably the documentation of open-network-stream should also be
>>>> updated to reflect this. I hesitate to do this myself without knowing
>>>> for sure that t is an acceptable value for all calls to
>>>> open-network-stream. I'd rather leave it for someone more familiar with
>>>> the code, like Lars.
>>>
>>> I went ahead and installed the obvious fix, to get rid of the test
>>> failure. I'm leaving the bug open because someone knowledgeable still
>>> needs to update the documentation of open-network-stream.
>>
>> The test calls make-network-process, not open-network-stream, so
>> altering the documentation of the latter doesn't seem appropriate.
>
> It's appropriate because the documentation is wrong. The documentation of
> open-network-stream doesn't say that the fourth argument can be t.
open-network-stream is for opening a client connection. The t value for
service only makes sense for servers, so mentioning that value in
the open-network-stream doc string seems odd.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2019-10-24 11:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-15 1:36 bug#23540: 25.1.50; make-ipv4-tcp-server-with-unspecified-port fails Ken Brown
2016-05-15 12:16 ` Ken Brown
2016-05-15 16:15 ` Eli Zaretskii
2016-05-15 17:08 ` Ken Brown
2016-05-24 15:09 ` Ken Brown
2016-05-24 15:27 ` Eli Zaretskii
2019-10-23 10:32 ` Lars Ingebrigtsen
2019-10-23 16:31 ` bug#23508: " Ken Brown
2019-10-24 11:48 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k18ufjpo.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=23508@debbugs.gnu.org \
--cc=23540@debbugs.gnu.org \
--cc=kbrown@cornell.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).