unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Ken Brown <kbrown@cornell.edu>
Cc: 23540@debbugs.gnu.org, larsi@gnus.org
Subject: bug#23540: 25.1.50; make-ipv4-tcp-server-with-unspecified-port fails
Date: Tue, 24 May 2016 18:27:29 +0300	[thread overview]
Message-ID: <83posb4gta.fsf@gnu.org> (raw)
In-Reply-To: <1181b6a8-c007-fbec-cb25-991a716c7b14@cornell.edu> (message from Ken Brown on Tue, 24 May 2016 11:09:00 -0400)

> Cc: 23540@debbugs.gnu.org, larsi@gnus.org
> From: Ken Brown <kbrown@cornell.edu>
> Date: Tue, 24 May 2016 11:09:00 -0400
> 
> On 5/15/2016 1:08 PM, Ken Brown wrote:
> > On 5/15/2016 12:15 PM, Eli Zaretskii wrote:
> >> Ffind_operation_coding_system includes an explicit test for the 4th
> >> argument to be an integer:
> >>
> >>   if (!(STRINGP (target)
> >>     || (EQ (operation, Qinsert_file_contents) && CONSP (target)
> >>         && STRINGP (XCAR (target)) && BUFFERP (XCDR (target)))
> >>     || (EQ (operation, Qopen_network_stream) && INTEGERP (target))))
> >>             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> >>     error ("Invalid argument %"pI"d of operation `%s'",
> >>        XFASTINT (target_idx) + 1, SDATA (SYMBOL_NAME (operation)));
> >>
> >> This should obviously be augmented, now that the value can also be t.
> >
> > Presumably the documentation of open-network-stream should also be
> > updated to reflect this.  I hesitate to do this myself without knowing
> > for sure that t is an acceptable value for all calls to
> > open-network-stream.  I'd rather leave it for someone more familiar with
> > the code, like Lars.
> 
> I went ahead and installed the obvious fix, to get rid of the test 
> failure.

Thanks.





  reply	other threads:[~2016-05-24 15:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-15  1:36 bug#23540: 25.1.50; make-ipv4-tcp-server-with-unspecified-port fails Ken Brown
2016-05-15 12:16 ` Ken Brown
2016-05-15 16:15   ` Eli Zaretskii
2016-05-15 17:08     ` Ken Brown
2016-05-24 15:09       ` Ken Brown
2016-05-24 15:27         ` Eli Zaretskii [this message]
2019-10-23 10:32         ` Lars Ingebrigtsen
2019-10-23 16:31           ` bug#23508: " Ken Brown
2019-10-24 11:48             ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83posb4gta.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=23540@debbugs.gnu.org \
    --cc=kbrown@cornell.edu \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).