From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#23508: bug#23540: 25.1.50; make-ipv4-tcp-server-with-unspecified-port fails Date: Thu, 24 Oct 2019 13:48:03 +0200 Message-ID: <87k18ufjpo.fsf@gnus.org> References: <83futj5mcl.fsf@gnu.org> <1181b6a8-c007-fbec-cb25-991a716c7b14@cornell.edu> <87sgnjhhwa.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="188811"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: "23540@debbugs.gnu.org" <23540@debbugs.gnu.org>, "23508@debbugs.gnu.org" <23508@debbugs.gnu.org> To: Ken Brown Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 24 14:48:31 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iNcXS-000mtJ-Ii for geb-bug-gnu-emacs@m.gmane.org; Thu, 24 Oct 2019 14:48:26 +0200 Original-Received: from localhost ([::1]:41512 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNcXQ-0005yL-Ph for geb-bug-gnu-emacs@m.gmane.org; Thu, 24 Oct 2019 08:48:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41747) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNbc0-0005Cb-JI for bug-gnu-emacs@gnu.org; Thu, 24 Oct 2019 07:49:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iNbbz-0000Ac-Bb for bug-gnu-emacs@gnu.org; Thu, 24 Oct 2019 07:49:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54840) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iNbbz-0000AF-8Y for bug-gnu-emacs@gnu.org; Thu, 24 Oct 2019 07:49:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iNbby-0007BA-SQ for bug-gnu-emacs@gnu.org; Thu, 24 Oct 2019 07:49:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Oct 2019 11:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23508 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 23508-submit@debbugs.gnu.org id=B23508.157191769327536 (code B ref 23508); Thu, 24 Oct 2019 11:49:02 +0000 Original-Received: (at 23508) by debbugs.gnu.org; 24 Oct 2019 11:48:13 +0000 Original-Received: from localhost ([127.0.0.1]:35428 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iNbbB-0007A3-3f for submit@debbugs.gnu.org; Thu, 24 Oct 2019 07:48:13 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:59922) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iNbb6-00079j-KQ; Thu, 24 Oct 2019 07:48:09 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iNbb2-0003zo-C8; Thu, 24 Oct 2019 13:48:06 +0200 In-Reply-To: (Ken Brown's message of "Wed, 23 Oct 2019 16:31:08 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:170123 Archived-At: Ken Brown writes: >>>> Presumably the documentation of open-network-stream should also be >>>> updated to reflect this. I hesitate to do this myself without knowing >>>> for sure that t is an acceptable value for all calls to >>>> open-network-stream. I'd rather leave it for someone more familiar with >>>> the code, like Lars. >>> >>> I went ahead and installed the obvious fix, to get rid of the test >>> failure. I'm leaving the bug open because someone knowledgeable still >>> needs to update the documentation of open-network-stream. >> >> The test calls make-network-process, not open-network-stream, so >> altering the documentation of the latter doesn't seem appropriate. > > It's appropriate because the documentation is wrong. The documentation of > open-network-stream doesn't say that the fourth argument can be t. open-network-stream is for opening a client connection. The t value for service only makes sense for servers, so mentioning that value in the open-network-stream doc string seems odd. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no