bug#43755: 27.1; Electric-buffer-list does not work with global-display-line-numbers-mode

bug#43755: 27.1; Electric-buffer-list does not work with global-display-line-numbers-mode

[superdorodor3]

Hello, developpers,

Followings will reproduce the bug in 27.1 or 28.0.50.

emacs -Q
M-x global-display-line-numbers-mode
M-x electric-buffer-list

Then, buffer list is displayed, but does not switch when a buffer is selected.
It correctly worked in 26.3.

Best Regards,
Masa

In GNU Emacs 27.1 (build 1, x86_64-apple-darwin18.7.0, NS appkit-1671.60 Version 10.14.6 (Build 18G95))
 of 2020-08-12 built on builder10-14.porkrind.org
Windowing system distributor 'Apple', version 10.3.1894
System Description:  Mac OS X 10.15.7

Configured using:
 'configure --with-ns '--enable-locallisppath=/Library/Application
 Support/Emacs/${version}/site-lisp:/Library/Application
 Support/Emacs/site-lisp' --with-modules'

Configured features:
NOTIFY KQUEUE ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS MODULES
THREADS JSON PDUMPER

Important settings:
  value of $LC_ALL: en_US.UTF-8
  value of $LC_CTYPE: UTF-8
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
format-spec rfc822 mml mml-sec password-cache epa derived epg epg-config
gnus-util rmail rmail-loaddefs text-property-search time-date subr-x seq
byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies mm-encode
mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047
rfc2045 ietf-drums mm-util mail-prsvr mail-utils help-mode easymenu
cl-loaddefs cl-lib tooltip eldoc electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel term/ns-win ns-win ucs-normalize mule-util
term/common-win tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode elisp-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer
select scroll-bar mouse jit-lock font-lock syntax facemenu font-core
term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese composite charscript charprop case-table epa-hook
jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs
button faces cus-face macroexp files text-properties overlay sha1 md5
base64 format env code-pages mule custom widget hashtable-print-readable
backquote threads kqueue cocoa ns multi-tty make-network-process emacs)

Memory information:
((conses 16 46152 6880)
 (symbols 48 6025 1)
 (strings 32 15505 1204)
 (string-bytes 1 517463)
 (vectors 16 10296)
 (vector-slots 8 128133 11324)
 (floats 8 19 34)
 (intervals 56 204 0)
 (buffers 1000 14))

bug#43755: 27.1; Electric-buffer-list does not work with global-display-line-numbers-mode

[Lars Ingebrigtsen]

superdorodor3 <superdorodoro3@gmail.com> writes:

> Followings will reproduce the bug in 27.1 or 28.0.50.
>
> emacs -Q
> M-x global-display-line-numbers-mode
> M-x electric-buffer-list
>
> Then, buffer list is displayed, but does not switch when a buffer is selected.
> It correctly worked in 26.3.

I can reproduce this in Emacs 28, and I've now pushed a fix.  I'm not
quite sure why global-display-line-numbers-mode makes this misbehave,
but electric-buffer-list is a somewhat eccentric command...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#43755: 27.1; Electric-buffer-list does not work with global-display-line-numbers-mode

[Eli Zaretskii]

> From: superdorodor3 <superdorodoro3@gmail.com>
> Date: Fri, 2 Oct 2020 11:32:38 +0900
> 
> Followings will reproduce the bug in 27.1 or 28.0.50.
> 
> emacs -Q
> M-x global-display-line-numbers-mode
> M-x electric-buffer-list
> 
> Then, buffer list is displayed, but does not switch when a buffer is selected.
> It correctly worked in 26.3.

What do you mean by "does not switch"?  Could you please describe the
recipe in more detail: which keys you type, what is expected to
happen, and what does actually happen?

Thanks.

bug#43755: 27.1; Electric-buffer-list does not work with global-display-line-numbers-mode

[superdorodor3]

emacs -Q
M-x global-display-line-numbers-mode
M-x electric-buffer-list        (*scratch* buffer is focused)
n                                        (then, *Messages* buffer is focused)
RET

Expected behavior: Window switches to *Messages* buffer.
Actually what happens:  Window keeps displaying *scratch* buffer.

Best Regards,
Masa

> On Oct 2, 2020, at 21:23, Eli Zaretskii <eliz@gnu.org> wrote:
> 
>> From: superdorodor3 <superdorodoro3@gmail.com>
>> Date: Fri, 2 Oct 2020 11:32:38 +0900
>> 
>> Followings will reproduce the bug in 27.1 or 28.0.50.
>> 
>> emacs -Q
>> M-x global-display-line-numbers-mode
>> M-x electric-buffer-list
>> 
>> Then, buffer list is displayed, but does not switch when a buffer is selected.
>> It correctly worked in 26.3.
> 
> What do you mean by "does not switch"?  Could you please describe the
> recipe in more detail: which keys you type, what is expected to
> happen, and what does actually happen?
> 
> Thanks.

bug#43755: 27.1; Electric-buffer-list does not work with global-display-line-numbers-mode

[Eli Zaretskii]

> From: superdorodor3 <superdorodoro3@gmail.com>
> Date: Fri, 2 Oct 2020 22:03:45 +0900
> Cc: 43755@debbugs.gnu.org
> 
> emacs -Q
> M-x global-display-line-numbers-mode
> M-x electric-buffer-list        (*scratch* buffer is focused)
> n                                        (then, *Messages* buffer is focused)
> RET
> 
> Expected behavior: Window switches to *Messages* buffer.
> Actually what happens:  Window keeps displaying *scratch* buffer.

Thanks.

This is already fixed on the master branch.  Hmm... what change fixed
that, I wonder?

bug#43755: 27.1; Electric-buffer-list does not work with global-display-line-numbers-mode

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

> This is already fixed on the master branch.  Hmm... what change fixed
> that, I wonder?

d037a6a2e6f92d793b1d5403dea4c7d3ca70883c

It fixes the symptom, but it would perhaps be interesting to see what it
is with display-line-numbers-mode that made this command behave oddly.
On the other hand, I thought the command itself was implemented so
peculiarly that it may not be worth poking into.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#43755: 27.1; Electric-buffer-list does not work with global-display-line-numbers-mode

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: superdorodor3 <superdorodoro3@gmail.com>,  43755@debbugs.gnu.org
> Date: Fri, 02 Oct 2020 15:15:02 +0200
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > This is already fixed on the master branch.  Hmm... what change fixed
> > that, I wonder?
> 
> d037a6a2e6f92d793b1d5403dea4c7d3ca70883c

Ah, thanks.  I think we should cherry-pick this to emacs-27.

> It fixes the symptom, but it would perhaps be interesting to see what it
> is with display-line-numbers-mode that made this command behave oddly.
> On the other hand, I thought the command itself was implemented so
> peculiarly that it may not be worth poking into.

I tend to agree.

bug#43755: 27.1; Electric-buffer-list does not work with global-display-line-numbers-mode

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

> Ah, thanks.  I think we should cherry-pick this to emacs-27.

Yup; now done.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no