From: "Kévin Le Gouguec" <kevin.legouguec@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 16514@debbugs.gnu.org, Dmitry Gutov <dgutov@yandex.ru>
Subject: bug#16514: 24.3.50; Region overlay looks bad on refined hunks in diff-mode
Date: Sun, 06 Dec 2020 16:39:04 +0100 [thread overview]
Message-ID: <87k0tvt04n.fsf@gmail.com> (raw)
In-Reply-To: <87lfebassa.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 06 Dec 2020 15:55:01 +0100")
Lars Ingebrigtsen <larsi@gnus.org> writes:
> I'm not sure I understand the recipe at all, but what I did was
>
> C-x v =
>
> in a file that had changes, and then created a region with the mouse
> over an arbitrary bit of that buffer:
>
> <screenshot>
>
> And the results don't look obviously wrong to me. So is this something
> that has been fixed already, or am I reproducing it wrong?
I'm not sure I understand the original recipe either, but the following
steps do show something inconsistent IMO:
1. emacs -Q CONTRIBUTE
2. C-x v g
3. move to "461cb9217d8 CONTRIBUTE (Paul Eggert 2019-05-25 10)"
4. =
5. move to the first removed line ("Briefly, …")
6. C-SPC
7. C-f C-f …
As long as point does not go past the refinement (before the comma), the
region's background has the region face's background.
Once point moves past the refinement, only non-refined parts keep the
region face's background; refined parts keep the refinement background.
next prev parent reply other threads:[~2020-12-06 15:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-21 4:44 bug#16514: 24.3.50; Region overlay looks bad on refined hunks in diff-mode Dmitry Gutov
2020-12-06 14:55 ` Lars Ingebrigtsen
2020-12-06 15:39 ` Kévin Le Gouguec [this message]
2020-12-06 15:48 ` Kévin Le Gouguec
2020-12-06 15:58 ` Eli Zaretskii
2020-12-06 19:34 ` Dmitry Gutov
2020-12-06 19:56 ` Eli Zaretskii
2020-12-06 16:10 ` Andreas Schwab
2020-12-07 13:19 ` Lars Ingebrigtsen
2020-12-06 19:33 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0tvt04n.fsf@gmail.com \
--to=kevin.legouguec@gmail.com \
--cc=16514@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).