From: Dmitry Gutov <dgutov@yandex.ru>
To: "Eli Zaretskii" <eliz@gnu.org>,
"Kévin Le Gouguec" <kevin.legouguec@gmail.com>
Cc: larsi@gnus.org, 16514@debbugs.gnu.org
Subject: bug#16514: 24.3.50; Region overlay looks bad on refined hunks in diff-mode
Date: Sun, 6 Dec 2020 21:34:44 +0200 [thread overview]
Message-ID: <157e9a89-6d6c-1d3e-9308-e81d7442889a@yandex.ru> (raw)
In-Reply-To: <83r1o39bab.fsf@gnu.org>
On 06.12.2020 17:58, Eli Zaretskii wrote:
>> From: Kévin Le Gouguec<kevin.legouguec@gmail.com>
>> Date: Sun, 06 Dec 2020 16:39:04 +0100
>> Cc:16514@debbugs.gnu.org, Dmitry Gutov<dgutov@yandex.ru>
>>
>> As long as point does not go past the refinement (before the comma), the
>> region's background has the region face's background.
>>
>> Once point moves past the refinement, only non-refined parts keep the
>> region face's background; refined parts keep the refinement background.
> This is expected, since we sort overlays so that the one whose extent
> is larger wins.
>
> To do anything else the overlays should have priorities.
So it's probably correct from the low-level primitives POV.
But is this a good UI? And shouldn't we maybe tweak the high-level
implementation (perhaps, the way how the refinements are applied) so
that the behavior is better?
next prev parent reply other threads:[~2020-12-06 19:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-21 4:44 bug#16514: 24.3.50; Region overlay looks bad on refined hunks in diff-mode Dmitry Gutov
2020-12-06 14:55 ` Lars Ingebrigtsen
2020-12-06 15:39 ` Kévin Le Gouguec
2020-12-06 15:48 ` Kévin Le Gouguec
2020-12-06 15:58 ` Eli Zaretskii
2020-12-06 19:34 ` Dmitry Gutov [this message]
2020-12-06 19:56 ` Eli Zaretskii
2020-12-06 16:10 ` Andreas Schwab
2020-12-07 13:19 ` Lars Ingebrigtsen
2020-12-06 19:33 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=157e9a89-6d6c-1d3e-9308-e81d7442889a@yandex.ru \
--to=dgutov@yandex.ru \
--cc=16514@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=kevin.legouguec@gmail.com \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).