From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Newsgroups: gmane.emacs.bugs Subject: bug#16514: 24.3.50; Region overlay looks bad on refined hunks in diff-mode Date: Sun, 06 Dec 2020 16:39:04 +0100 Message-ID: <87k0tvt04n.fsf@gmail.com> References: <87y52arljh.fsf@yandex.ru> <87lfebassa.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18547"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 16514@debbugs.gnu.org, Dmitry Gutov To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 06 16:40:52 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1klw9b-0004jJ-ST for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Dec 2020 16:40:51 +0100 Original-Received: from localhost ([::1]:39048 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1klw9a-0008Bl-PV for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Dec 2020 10:40:50 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41018) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1klw8o-00087K-Tg for bug-gnu-emacs@gnu.org; Sun, 06 Dec 2020 10:40:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39268) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1klw8o-0003Iu-J9 for bug-gnu-emacs@gnu.org; Sun, 06 Dec 2020 10:40:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1klw8o-00073u-GN for bug-gnu-emacs@gnu.org; Sun, 06 Dec 2020 10:40:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 Dec 2020 15:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16514 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 16514-submit@debbugs.gnu.org id=B16514.160726915427088 (code B ref 16514); Sun, 06 Dec 2020 15:40:02 +0000 Original-Received: (at 16514) by debbugs.gnu.org; 6 Dec 2020 15:39:14 +0000 Original-Received: from localhost ([127.0.0.1]:50814 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klw81-00072q-ST for submit@debbugs.gnu.org; Sun, 06 Dec 2020 10:39:14 -0500 Original-Received: from mail-wm1-f54.google.com ([209.85.128.54]:52648) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klw80-00072S-EH for 16514@debbugs.gnu.org; Sun, 06 Dec 2020 10:39:12 -0500 Original-Received: by mail-wm1-f54.google.com with SMTP id a6so9409298wmc.2 for <16514@debbugs.gnu.org>; Sun, 06 Dec 2020 07:39:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=5OE31/cAoSMlVr0fgmUkjMTY9lTXp6T5LdFIQB49Uco=; b=ofB4ESVwFLOqz2O8HcN37W05MCUnZZ5JHOBKaSUtjNYm4PfMAmzqqwO4+n5rP2OG2i 5+J5gt05dT51My4FKK7BfpkVxtp3jrhR1oNkJIeSv7RhPjS9fzmwwNlWqnlcFlCAdHZ7 Dwct54OT/Nh8bHOHk3Wud4pwCDt9Ca0yK+fwL7pN0/vKcOleat9IBCD8KfmYo5rLPidu txCsZYP1fW6aq9lZk43qfGMPyKMXkhJoaQP4m9aoTgWJ3jqI7utQCX+DoCeTx6AxhjZs zzV5D1B7tUS4v2RIWleNUUX7W+CfoHB/vshQYRVTBhhUHFww6yW9/SyEtxx/G2nJI4kp iPtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=5OE31/cAoSMlVr0fgmUkjMTY9lTXp6T5LdFIQB49Uco=; b=E3W7CSbb1rWRbhT/sKVEcu5kvNAyXjyrkNUaD2AKpiAvgp2HxZ1pF/HLqwmDMacBtg est/tNwnc6FejsXMs+q+HV2Xbhxy5cl3cGO1iK7EKA9PRijFZL/LBnYe2Xp8OkxKkEFj 0aqH/0lve20Ctb1TO+ebxA6IZ6pe4jwsh/ccs46q2gVQ0RkddCyGethVxCqqYDoqudi5 cIRfJZZx6as+Gm5lzw8DFbfvn5R83/754MoTX4SH6TJduqrECNPcSM5gHFCjUS8IL6Nz N4hNli102imqUAMhq7lhh5DNXPQx/TqzzzP3vmNJGbQxllYkEuNk3fDL4gsV7HJsP17x d8LA== X-Gm-Message-State: AOAM5316UWoLRM2VF+dL3vReNfD48kmSqzcM9z5g00IMkNfErHZMqv8A OogjcegbIUOBQw0N5oQyP7cD+DyZjil0Rw== X-Google-Smtp-Source: ABdhPJw3Oec7Ras386RnC24HhC8AVy9IQzlquUPMYzoeReXttjMQC6adSuI9WEugvcP15Rgu/q5uWg== X-Received: by 2002:a1c:9acb:: with SMTP id c194mr13878547wme.43.1607269146228; Sun, 06 Dec 2020 07:39:06 -0800 (PST) Original-Received: from my-little-tumbleweed ([2a01:e0a:20e:d340:922b:34ff:fe95:9aed]) by smtp.gmail.com with ESMTPSA id c1sm10260209wml.8.2020.12.06.07.39.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Dec 2020 07:39:05 -0800 (PST) In-Reply-To: <87lfebassa.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 06 Dec 2020 15:55:01 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:195120 Archived-At: Lars Ingebrigtsen writes: > I'm not sure I understand the recipe at all, but what I did was > > C-x v =3D > > in a file that had changes, and then created a region with the mouse > over an arbitrary bit of that buffer: > > > > And the results don't look obviously wrong to me. So is this something > that has been fixed already, or am I reproducing it wrong? I'm not sure I understand the original recipe either, but the following steps do show something inconsistent IMO: 1. emacs -Q CONTRIBUTE 2. C-x v g 3. move to "461cb9217d8 CONTRIBUTE (Paul Eggert 2019-05-25 10)" 4. =3D 5. move to the first removed line ("Briefly, =E2=80=A6") 6. C-SPC 7. C-f C-f =E2=80=A6 As long as point does not go past the refinement (before the comma), the region's background has the region face's background. Once point moves past the refinement, only non-refined parts keep the region face's background; refined parts keep the refinement background.