From: Lars Ingebrigtsen <larsi@gnus.org>
To: Neil Okamoto <neil.okamoto@gmail.com>
Cc: 40188@debbugs.gnu.org
Subject: bug#40188: check-declare-files does not include malformed declarations in the list
Date: Tue, 10 Aug 2021 18:33:31 +0200 [thread overview]
Message-ID: <87k0ktuun8.fsf_-_@gnus.org> (raw)
In-Reply-To: <370E4512-AE5C-4D9C-8AEE-F4286BFD68CF@gmail.com> (Neil Okamoto's message of "Wed, 25 Mar 2020 15:19:44 -0700")
Neil Okamoto <neil.okamoto@gmail.com> writes:
> ;; repro for 40188:
> ;; http://debbugs.gnu.org/cgi/bugreport.cgi?bug=40188
>
> ;; evaluate:
> ;; (check-declare-file "test.el")
> ;; yields:
> ;; (("../../tmp/check-declare/some-file.el"
> ;; ("/tmp/check-declare/test.el" "bar" "file not found")))
> ;;
> ;; which omits the second declare-function, which is malformed
>
> (declare-function bar "some-file.el")
> (declare-function foo ‘malformed)
Well, the doc string says that it "checks the veracity" of the
declare-function calls -- not that it checks whether they're malformed.
So I think the return value is working as intended.
However, it (now) pops up the following warning:
check.el:14:Warning (check-declare): said ‘foo’ was defined in unknown file:
Malformed declaration
So it does warn about the malformed `declare-function' (but doesn't
include it in the return value).
I think this is probably working as intended on the whole, so I'm
closing this bug report.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2021-08-10 16:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 0:31 bug#40188: check-declare-files does not include malformed declarations in the list Neil Okamoto
2020-03-25 21:41 ` bug#40188: repro for Emacs 26.3 and 27.0.90 Neil Okamoto
2020-03-25 22:19 ` Neil Okamoto
2021-08-10 16:33 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0ktuun8.fsf_-_@gnus.org \
--to=larsi@gnus.org \
--cc=40188@debbugs.gnu.org \
--cc=neil.okamoto@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).