From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#40188: check-declare-files does not include malformed declarations in the list Date: Tue, 10 Aug 2021 18:33:31 +0200 Message-ID: <87k0ktuun8.fsf_-_@gnus.org> References: <370E4512-AE5C-4D9C-8AEE-F4286BFD68CF@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10874"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 40188@debbugs.gnu.org To: Neil Okamoto Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 10 18:34:24 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mDUhr-0002Y2-Q1 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 10 Aug 2021 18:34:23 +0200 Original-Received: from localhost ([::1]:50084 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mDUhp-0000pa-NE for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 10 Aug 2021 12:34:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60172) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDUhW-0000l6-8E for bug-gnu-emacs@gnu.org; Tue, 10 Aug 2021 12:34:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49141) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mDUhW-0006X9-1u for bug-gnu-emacs@gnu.org; Tue, 10 Aug 2021 12:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mDUhV-00087s-Vb for bug-gnu-emacs@gnu.org; Tue, 10 Aug 2021 12:34:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 10 Aug 2021 16:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40188 X-GNU-PR-Package: emacs Original-Received: via spool by 40188-submit@debbugs.gnu.org id=B40188.162861323731224 (code B ref 40188); Tue, 10 Aug 2021 16:34:01 +0000 Original-Received: (at 40188) by debbugs.gnu.org; 10 Aug 2021 16:33:57 +0000 Original-Received: from localhost ([127.0.0.1]:60687 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDUhQ-00087X-F5 for submit@debbugs.gnu.org; Tue, 10 Aug 2021 12:33:57 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:49682) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDUhC-00086n-Rk for 40188@debbugs.gnu.org; Tue, 10 Aug 2021 12:33:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=PBvTFRvhvP1Irmt6MUueKWpdMo6DPtuJOQXf7i3u/NE=; b=IVmHHSJwn6rrBqs7NVQ4qZqY7m b52ITxfp1xcB8tQXjdvem3PyfvIDb/eZ5Eq0elxfMWrTWlPggNin+ZO+RUBkXWvn5F+h5lUzdnnJI jplx4n/Zdg2437dIWbHwpcXSrZ6C3sVwr4F9sS+JCSzCVutRWlnce+Ko8DGQH7O/GKXo=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mDUh2-00048r-7D; Tue, 10 Aug 2021 18:33:36 +0200 In-Reply-To: <370E4512-AE5C-4D9C-8AEE-F4286BFD68CF@gmail.com> (Neil Okamoto's message of "Wed, 25 Mar 2020 15:19:44 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:211530 Archived-At: Neil Okamoto writes: > ;; repro for 40188: > ;; http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D40188 > > ;; evaluate: > ;; (check-declare-file "test.el") > ;; yields: > ;; (("../../tmp/check-declare/some-file.el" > ;; ("/tmp/check-declare/test.el" "bar" "file not found"))) > ;;=20 > ;; which omits the second declare-function, which is malformed=20 > > (declare-function bar "some-file.el") > (declare-function foo =E2=80=98malformed) Well, the doc string says that it "checks the veracity" of the declare-function calls -- not that it checks whether they're malformed. So I think the return value is working as intended. However, it (now) pops up the following warning: check.el:14:Warning (check-declare): said =E2=80=98foo=E2=80=99 was defined= in unknown file: Malformed declaration So it does warn about the malformed `declare-function' (but doesn't include it in the return value). I think this is probably working as intended on the whole, so I'm closing this bug report. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no