unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Neil Okamoto <neil.okamoto@gmail.com>
To: 40188@debbugs.gnu.org
Subject: bug#40188: check-declare-files does not include malformed declarations in the list
Date: Sun, 22 Mar 2020 17:31:03 -0700	[thread overview]
Message-ID: <12DE784E-580A-4686-9126-101156860970@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 486 bytes --]


As noted in the subject line: malformed declarations are noted by ‘check-declare-scan’ which logs a message in the ‘check-declare-warning-buffer’.  However that malformed declaration is not passed back to 'check-declare-files’, and therefore its not part of the error list returned from that function.

Software that uses  'check-declare-files' as a lint check would have to parse the warning buffer (an additional step) in order to catch these malformed declarations.


[-- Attachment #2: Type: text/html, Size: 784 bytes --]

             reply	other threads:[~2020-03-23  0:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-23  0:31 Neil Okamoto [this message]
2020-03-25 21:41 ` bug#40188: repro for Emacs 26.3 and 27.0.90 Neil Okamoto
2020-03-25 22:19   ` Neil Okamoto
2021-08-10 16:33     ` bug#40188: check-declare-files does not include malformed declarations in the list Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12DE784E-580A-4686-9126-101156860970@gmail.com \
    --to=neil.okamoto@gmail.com \
    --cc=40188@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).