bug#63625: 29.0.90; package-install inserts package directory into load-path twice.

[Philip Kaludercic <philipk@posteo.net>]

Eli Zaretskii <eliz@gnu.org> writes:

>> Cc: todd smith <toddasmith@mac.com>
>> From: Robert Pluim <rpluim@gmail.com>
>> Date: Mon, 22 May 2023 10:55:13 +0200
>> 
>> This is because we didnʼt respect DRY. package.el should use the
>> package support of `loaddefs-generate', but that doesnʼt expose the
>> requisite feature of `loaddefs-generate--rubric' (maybe on master it does).
>> 
>> diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
>> index 78017b77677..31e5e0809a8 100644
>> --- a/lisp/emacs-lisp/package.el
>> +++ b/lisp/emacs-lisp/package.el
>> @@ -1107,8 +1107,9 @@ package-generate-autoloads
>>          ;; Add the directory that will contain the autoload file to
>>          ;; the load path.  We don't hard-code `pkg-dir', to avoid
>>          ;; issues if the package directory is moved around.
>> +        (directory-file-name
>>          (or (and load-file-name (file-name-directory load-file-name))
>> -            (car load-path)))))
>> +            (car load-path))))))
>>      (let ((buf (find-buffer-visiting output-file)))
>>        (when buf (kill-buffer buf)))
>>      auto-name))
>
> Thanks.
>
> Philip, Stefan: any comments or suggestions?

This looks like the adequate change to me.