From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#63625: 29.0.90; package-install inserts package directory into load-path twice. Date: Mon, 22 May 2023 13:18:17 +0000 Message-ID: <87jzx0bj3a.fsf@posteo.net> References: <4ACD9E26-B5A6-412E-8DFC-C09C05A4EACD@mac.com> <871qj8lp8u.fsf@gmail.com> <83zg5wpq0h.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9306"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Robert Pluim , toddasmith@mac.com, Stefan Monnier , 63625@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 22 15:19:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q15Rb-0002Ef-E4 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 22 May 2023 15:19:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q15RI-0005QE-Q6; Mon, 22 May 2023 09:19:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q15RG-0005Pv-7G for bug-gnu-emacs@gnu.org; Mon, 22 May 2023 09:19:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q15RF-0000Ow-W9 for bug-gnu-emacs@gnu.org; Mon, 22 May 2023 09:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q15RF-0000LY-SR for bug-gnu-emacs@gnu.org; Mon, 22 May 2023 09:19:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 May 2023 13:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63625 X-GNU-PR-Package: emacs Original-Received: via spool by 63625-submit@debbugs.gnu.org id=B63625.16847615081283 (code B ref 63625); Mon, 22 May 2023 13:19:01 +0000 Original-Received: (at 63625) by debbugs.gnu.org; 22 May 2023 13:18:28 +0000 Original-Received: from localhost ([127.0.0.1]:34045 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q15Qi-0000Kc-9E for submit@debbugs.gnu.org; Mon, 22 May 2023 09:18:28 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:47193) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q15Qe-0000KO-Uf for 63625@debbugs.gnu.org; Mon, 22 May 2023 09:18:26 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id C1C54240104 for <63625@debbugs.gnu.org>; Mon, 22 May 2023 15:18:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1684761498; bh=zYHq2+WZQhp+1iMYCmXLYEGE01uJv70D2yu4eQINJEY=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version: Content-Transfer-Encoding:From; b=iWyhfBWtzr6uEMT9T3ItWr4Y0SSjJoGiI+OdM2ATgdMLkt6Jv2/YmUSeGJFK6rWJu bT1iLZRiS24NFJwxX4qJ1ZDP4Wi5dZx4p7RiFmucIBHMe7hvcxBUStRWgKLjb7SvqP 8bcNJjXPyFiksUQdDIHMmniL7FMp4R0ePaMzBwCryyim+WTp8EQUS7fY47r1yNtk/l zbz2FXVBNvSOJ9dywiEsbybQ2jLepdROpF63hb37dr36PPacLP1kMdJD1vTcDlP4o9 /Le9EA5YImXZ0AH1gNDfzsU/CIgS/fsFyelBlk9MVE/Mel/N45KlogdAvEHdee02XH ZOFJPzwzcCt0w== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QPygY5Ks3z6trm; Mon, 22 May 2023 15:18:17 +0200 (CEST) In-Reply-To: <83zg5wpq0h.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 22 May 2023 14:25:02 +0300") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262151 Archived-At: Eli Zaretskii writes: >> Cc: todd smith >> From: Robert Pluim >> Date: Mon, 22 May 2023 10:55:13 +0200 >>=20 >> This is because we didn=CA=BCt respect DRY. package.el should use the >> package support of `loaddefs-generate', but that doesn=CA=BCt expose the >> requisite feature of `loaddefs-generate--rubric' (maybe on master it doe= s). >>=20 >> diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el >> index 78017b77677..31e5e0809a8 100644 >> --- a/lisp/emacs-lisp/package.el >> +++ b/lisp/emacs-lisp/package.el >> @@ -1107,8 +1107,9 @@ package-generate-autoloads >> ;; Add the directory that will contain the autoload file to >> ;; the load path. We don't hard-code `pkg-dir', to avoid >> ;; issues if the package directory is moved around. >> + (directory-file-name >> (or (and load-file-name (file-name-directory load-file-name)) >> - (car load-path))))) >> + (car load-path)))))) >> (let ((buf (find-buffer-visiting output-file))) >> (when buf (kill-buffer buf))) >> auto-name)) > > Thanks. > > Philip, Stefan: any comments or suggestions? This looks like the adequate change to me.