From: Eli Zaretskii <eliz@gnu.org>
To: Robert Pluim <rpluim@gmail.com>
Cc: philipk@posteo.net, toddasmith@mac.com, monnier@iro.umontreal.ca,
63625@debbugs.gnu.org
Subject: bug#63625: 29.0.90; package-install inserts package directory into load-path twice.
Date: Mon, 22 May 2023 18:53:47 +0300 [thread overview]
Message-ID: <83o7mcpdkk.fsf@gnu.org> (raw)
In-Reply-To: <877ct0js46.fsf@gmail.com> (message from Robert Pluim on Mon, 22 May 2023 17:36:09 +0200)
> Cc: Philip Kaludercic <philipk@posteo.net>, 63625@debbugs.gnu.org,
> todd smith <toddasmith@mac.com>
> From: Robert Pluim <rpluim@gmail.com>
> Date: Mon, 22 May 2023 17:36:09 +0200
>
> Stefan> (package--reload-previously-loaded pkg-desc))
> Stefan> (with-demoted-errors "Error loading autoloads: %s"
> Stefan> (load (package--autoloads-file-name pkg-desc) nil t))
> Stefan> - (add-to-list 'load-path (directory-file-name pkg-dir)))
> Stefan> + ;; FIXME: Since 2013 (commit 4fac34cee97a), the autoload files take
> Stefan> + ;; care of changing the `load-path', so maybe it's time to
> Stefan> + ;; remove this fallback code?
> Stefan> + (unless (or (member (file-name-as-directory pkg-dir) load-path)
> Stefan> + (member (directory-file-name pkg-dir) load-path))
> Stefan> + (add-to-list 'load-path pkg-dir)))
>
> Stefan> Maybe we can have that patch in emacs-29 and remove the code altogether
> Stefan> on `master`?
>
> That seems reasonable. Eli?
I'm a bit confused by "that patch" and stuff, and would prefer to see
the patch for emacs-29 and another for master, please.
Thanks.
next prev parent reply other threads:[~2023-05-22 15:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-20 21:45 bug#63625: 29.0.90; package-install inserts package directory into load-path twice todd smith via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-22 8:55 ` Robert Pluim
2023-05-22 11:25 ` Eli Zaretskii
2023-05-22 12:46 ` Robert Pluim
2023-05-22 13:18 ` Philip Kaludercic
2023-05-22 13:54 ` Robert Pluim
2023-05-22 13:58 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-22 14:19 ` Robert Pluim
2023-05-22 15:04 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-22 15:36 ` Robert Pluim
2023-05-22 15:53 ` Eli Zaretskii [this message]
2023-05-22 16:57 ` Robert Pluim
2023-05-23 12:06 ` Eli Zaretskii
2023-05-23 13:20 ` Robert Pluim
2023-05-23 13:46 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-22 15:49 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83o7mcpdkk.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=63625@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=philipk@posteo.net \
--cc=rpluim@gmail.com \
--cc=toddasmith@mac.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).