From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#46358: 28.0.50; [PATCH] Add vc-dir faces; also apply them to vc-git Date: Mon, 08 Feb 2021 20:17:33 +0200 Organization: LINKOV.NET Message-ID: <87im72o6r6.fsf@mail.linkov.net> References: <87czxc5cku.fsf@protesilaos.com> <83tuqnnc3s.fsf@gnu.org> <87pn1b4zxp.fsf@protesilaos.com> <87im73m4ki.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5545"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 46358@debbugs.gnu.org, Protesilaos Stavrou To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 09 00:11:42 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l9Fgz-0001MT-Uc for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Feb 2021 00:11:41 +0100 Original-Received: from localhost ([::1]:53134 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9Fgy-0003BL-WE for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 Feb 2021 18:11:41 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50656) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9BCd-0003Wk-Oe for bug-gnu-emacs@gnu.org; Mon, 08 Feb 2021 13:24:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40351) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l9BCd-0006IB-F5 for bug-gnu-emacs@gnu.org; Mon, 08 Feb 2021 13:24:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l9BCd-0006YI-Ay for bug-gnu-emacs@gnu.org; Mon, 08 Feb 2021 13:24:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Feb 2021 18:24:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46358 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 46358-submit@debbugs.gnu.org id=B46358.161280860925108 (code B ref 46358); Mon, 08 Feb 2021 18:24:03 +0000 Original-Received: (at 46358) by debbugs.gnu.org; 8 Feb 2021 18:23:29 +0000 Original-Received: from localhost ([127.0.0.1]:51890 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9BC4-0006Wt-L6 for submit@debbugs.gnu.org; Mon, 08 Feb 2021 13:23:28 -0500 Original-Received: from relay4-d.mail.gandi.net ([217.70.183.196]:57839) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9BC0-0006WU-Km for 46358@debbugs.gnu.org; Mon, 08 Feb 2021 13:23:26 -0500 X-Originating-IP: 91.129.108.204 Original-Received: from mail.gandi.net (m91-129-108-204.cust.tele2.ee [91.129.108.204]) (Authenticated sender: juri@linkov.net) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id CBDDFE0002; Mon, 8 Feb 2021 18:23:16 +0000 (UTC) In-Reply-To: <87im73m4ki.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 08 Feb 2021 07:55:25 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199636 Archived-At: >> Very well! I am doing just that in the revised patch. So there should >> be no visual difference between this and the prior state, except for one >> case: the empty Git stash header, which will ultimately inherit from >> 'shadow' (before there was a "FIXME" to disambiguate it from other >> header values). > > Looks good to me; pushed to Emacs 28 now. I don't know if anyone else has such problem, but now highlighting the empty Git stash header with a different color distinguishes it from other header lines, and thus attracts more attention. So now the most noticeable thing in the vc-dir is the Git stash header (that I almost never use). Maybe better to display the empty Git stash header using the default colors, and then highlight it differently only when it's non-empty?