bug#61337: 29.0.60; Setting frame-title-format makes Emacs to steal focus

[Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>]

"Oscar Fuentes" <ofv@wanadoo.es> writes:

> This is on KDE with two desktops.
>
> Let's suppose that we are on Desktop1. On xterm, for instance:
>
> $ emacs -Q
>
> Eval this on *scratch*:
>
> (setq frame-title-format "hello")
>
> Click somewhere on Emacs' frame to update its displayed title.
>
> Set focus to xterm, switch to Desktop2 and back to Desktop1. Focus is on
> Emacs' frame. The z-order is not altered.
>
> After bisecting:
>
> commit e99f41f03a97641ee05ba4a27f8b91c190f55df1
> Author: Po Lu <luangruo@yahoo.com>
> Date:   Thu Jun 9 21:48:19 2022 +0800
>
>     Fix recalculation of `icon-title-format' after a frame is iconified
>     
>     Previously it would only happen upon the next mode line
>     redisplay, meaning that just pressing C-z would not update the
>     implicit title, since C-z doesn't cause a redisplay.
>     
>     * src/dispextern.h: Update prototypes.
>     * src/frame.h (SET_FRAME_ICONIFIED): De-slugify.  Call
>     `gui_consider_frame_title', since `icon-title-format' might be
>     different from the current frame title.
>     * src/xdisp.c (gui_consider_frame_title): Export (also in
>     dispextern.h).  (bug#55850)
>
> I checked that reverting this commit fixes the problem.
>
>
> In GNU Emacs 29.0.60 (build 3, x86_64-pc-linux-gnu, X toolkit, cairo
>  version 1.16.0) of 2023-02-07 built on sky
> Repository revision: 746748f5c283b98a221571e725833affe304a748
> Repository branch: emacs-29
> Windowing system distributor 'The X.Org Foundation', version 11.0.12101006
> System Description: Debian GNU/Linux bookworm/sid
>
> Configured using:
>  'configure --without-toolkit-scroll-bars --with-x-toolkit=lucid
>  --with-modules --without-imagemagick'
>
> Configured features:
> CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON
> LIBOTF LIBSELINUX LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG RSVG
> SECCOMP SOUND THREADS TIFF TREE_SITTER WEBP X11 XAW3D XDBE XIM XINPUT2
> XPM LUCID ZLIB
>
> Important settings:
>   value of $LANG: es_ES.UTF-8
>   locale-coding-system: utf-8-unix

Thanks.  Does this solve the problem?

diff --git a/src/xfns.c b/src/xfns.c
index 3a129211463..b64ebd0aefd 100644
--- a/src/xfns.c
+++ b/src/xfns.c
@@ -2329,7 +2329,7 @@ x_set_title (struct frame *f, Lisp_Object name, Lisp_Object old_name)
   else
     CHECK_STRING (name);
 
-  x_set_name_internal (f, name);
+  x_set_name (f, arg, false);
 }
 
 void