unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Protesilaos Stavrou <info@protesilaos.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: "Basil L. Contovounesios" <contovob@tcd.ie>, 46964@debbugs.gnu.org
Subject: bug#46964: [ELPA]: [PATCH] Replace modus-*-theme with modus-themes from :core
Date: Sat, 06 Mar 2021 18:19:08 +0200	[thread overview]
Message-ID: <87h7lofe6b.fsf@protesilaos.com> (raw)
In-Reply-To: <jwvblbwba8o.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Sat, 06 Mar 2021 10:00:29 -0500")

On 2021-03-06, 14:39 +0000, "Basil L. Contovounesios" <contovob@tcd.ie> wrote:

> Have you tried specifying the manual's source .org/.texi file as the
> package :doc property?

I tried with this:

    ("modus-themes"
      :core ("etc/themes/modus-themes.el"
             "etc/themes/modus-operandi-theme.el"
             "etc/themes/modus-vivendi-theme.el")
      :doc "doc/misc/modus-themes.org")

The feedback I get at the shell, with 'make packages/modus-themes':

    ...
    Linking files for package: modus-themes
      etc/themes/modus-themes.el -> modus-themes.el
      etc/themes/modus-operandi-theme.el -> modus-operandi-theme.el
      etc/themes/modus-vivendi-theme.el -> modus-vivendi-theme.el

Whereas the following creates a symlink for the org file as well:

    ("modus-themes"
      :core ("etc/themes/modus-themes.el"
             "etc/themes/modus-operandi-theme.el"
             "etc/themes/modus-vivendi-theme.el"
             "doc/misc/modus-themes.org"))

> Although I don't know whether :core packages support that yet, or
> whether elpa.git can even build .texi/.org manuals from emacs.git (see,
> for example, the commented-out entry in elpa-packages for cc-mode).

Indeed.  Besides, emacs.git only recently started including manuals in
Org format.

> [ P.S. If you're interested in becoming a member, I think it's time you
>   created a Savannah account and requested inclusion in the Emacs
>   project: https://savannah.gnu.org/project/memberlist.php?group=emacs ]

Just did.  It informed me that it sent an email to a list of
maintainers.


On 2021-03-06, 10:00 -0500, Stefan Monnier <monnier@iro.umontreal.ca> wrote:

>>> What I am not sure about---and apologies if I missed it in the elpa.git
>>> README---is whether a ":core" package benefits from the 'make' command
>>> when that has been called from the root of the emacs.git directory.
>
> :core packages are made by creating a local "look-alike" package which
> just contains symlinks to files in a pristine emacs.git tree.
> So I think the answer is "no".

I see, thank you!  What would be the best course of action then, to
include "doc/misc/modus-themes.org" or omit it?


-- 
Protesilaos Stavrou
protesilaos.com





  reply	other threads:[~2021-03-06 16:19 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-06 11:58 bug#46964: [ELPA]: [PATCH] Replace modus-*-theme with modus-themes from :core Protesilaos Stavrou
2021-03-06 14:39 ` Basil L. Contovounesios
2021-03-06 15:00   ` Stefan Monnier
2021-03-06 16:19     ` Protesilaos Stavrou [this message]
2021-03-06 18:35       ` Stefan Monnier
2021-03-07  7:32         ` Protesilaos Stavrou
2021-03-09 15:54           ` Basil L. Contovounesios
2021-03-09 16:46             ` Stefan Monnier
2021-03-09 19:08             ` Protesilaos Stavrou
2021-03-09 20:49               ` Stefan Monnier
2021-03-10  3:48                 ` Stefan Monnier
2021-03-10  5:43                   ` Protesilaos Stavrou
2021-03-10 18:41                     ` Stefan Monnier
2021-03-10 20:13                       ` Protesilaos Stavrou
2021-03-10 23:17                         ` Stefan Monnier
2021-03-10 23:23                           ` Basil L. Contovounesios
2021-03-11  3:07                             ` Stefan Monnier
2021-03-11  8:27                               ` Protesilaos Stavrou
2021-03-11 19:45                                 ` Basil L. Contovounesios
2021-03-11 22:54                                 ` Stefan Monnier
2021-03-12  7:59                                   ` Protesilaos Stavrou
2021-03-13 17:10                           ` Stefan Monnier
2021-03-17  7:04                             ` Protesilaos Stavrou
2021-03-18  7:55                               ` Protesilaos Stavrou
2021-03-18 17:52                                 ` Stefan Monnier
2021-03-19  5:29                                   ` Protesilaos Stavrou
2021-03-19 12:55                                     ` Stefan Monnier
2021-03-19 14:18                                       ` Protesilaos Stavrou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h7lofe6b.fsf@protesilaos.com \
    --to=info@protesilaos.com \
    --cc=46964@debbugs.gnu.org \
    --cc=contovob@tcd.ie \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).