From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Protesilaos Stavrou Newsgroups: gmane.emacs.bugs Subject: bug#46964: [ELPA]: [PATCH] Replace modus-*-theme with modus-themes from :core Date: Sat, 06 Mar 2021 18:19:08 +0200 Message-ID: <87h7lofe6b.fsf@protesilaos.com> References: <87y2f0fq8v.fsf@protesilaos.com> <87sg58tkg7.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19986"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: "Basil L. Contovounesios" , 46964@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 06 17:20:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lIZf4-000532-4h for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Mar 2021 17:20:14 +0100 Original-Received: from localhost ([::1]:55440 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lIZf3-0004HW-6j for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Mar 2021 11:20:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37970) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lIZet-0004HP-0d for bug-gnu-emacs@gnu.org; Sat, 06 Mar 2021 11:20:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54843) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lIZes-0002lb-KZ for bug-gnu-emacs@gnu.org; Sat, 06 Mar 2021 11:20:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lIZes-0007q8-Fj for bug-gnu-emacs@gnu.org; Sat, 06 Mar 2021 11:20:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Protesilaos Stavrou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Mar 2021 16:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46964 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 46964-submit@debbugs.gnu.org id=B46964.161504756030079 (code B ref 46964); Sat, 06 Mar 2021 16:20:02 +0000 Original-Received: (at 46964) by debbugs.gnu.org; 6 Mar 2021 16:19:20 +0000 Original-Received: from localhost ([127.0.0.1]:38156 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lIZeC-0007p4-FS for submit@debbugs.gnu.org; Sat, 06 Mar 2021 11:19:20 -0500 Original-Received: from relay13.mail.gandi.net ([217.70.178.233]:27333) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lIZe9-0007oo-WD for 46964@debbugs.gnu.org; Sat, 06 Mar 2021 11:19:18 -0500 Original-Received: from kronos (unknown [94.46.225.161]) (Authenticated sender: public@protesilaos.com) by relay13.mail.gandi.net (Postfix) with ESMTPSA id A10C080005; Sat, 6 Mar 2021 16:19:10 +0000 (UTC) In-Reply-To: (Stefan Monnier's message of "Sat, 06 Mar 2021 10:00:29 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201644 Archived-At: On 2021-03-06, 14:39 +0000, "Basil L. Contovounesios" wrote: > Have you tried specifying the manual's source .org/.texi file as the > package :doc property? I tried with this: ("modus-themes" :core ("etc/themes/modus-themes.el" "etc/themes/modus-operandi-theme.el" "etc/themes/modus-vivendi-theme.el") :doc "doc/misc/modus-themes.org") The feedback I get at the shell, with 'make packages/modus-themes': ... Linking files for package: modus-themes etc/themes/modus-themes.el -> modus-themes.el etc/themes/modus-operandi-theme.el -> modus-operandi-theme.el etc/themes/modus-vivendi-theme.el -> modus-vivendi-theme.el Whereas the following creates a symlink for the org file as well: ("modus-themes" :core ("etc/themes/modus-themes.el" "etc/themes/modus-operandi-theme.el" "etc/themes/modus-vivendi-theme.el" "doc/misc/modus-themes.org")) > Although I don't know whether :core packages support that yet, or > whether elpa.git can even build .texi/.org manuals from emacs.git (see, > for example, the commented-out entry in elpa-packages for cc-mode). Indeed. Besides, emacs.git only recently started including manuals in Org format. > [ P.S. If you're interested in becoming a member, I think it's time you > created a Savannah account and requested inclusion in the Emacs > project: https://savannah.gnu.org/project/memberlist.php?group=emacs ] Just did. It informed me that it sent an email to a list of maintainers. On 2021-03-06, 10:00 -0500, Stefan Monnier wrote: >>> What I am not sure about---and apologies if I missed it in the elpa.git >>> README---is whether a ":core" package benefits from the 'make' command >>> when that has been called from the root of the emacs.git directory. > > :core packages are made by creating a local "look-alike" package which > just contains symlinks to files in a pristine emacs.git tree. > So I think the answer is "no". I see, thank you! What would be the best course of action then, to include "doc/misc/modus-themes.org" or omit it? -- Protesilaos Stavrou protesilaos.com