unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Protesilaos Stavrou <info@protesilaos.com>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: 46964@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#46964: [ELPA]: [PATCH] Replace modus-*-theme with modus-themes from :core
Date: Tue, 09 Mar 2021 21:08:22 +0200	[thread overview]
Message-ID: <874khk6t7d.fsf@protesilaos.com> (raw)
In-Reply-To: <878s6wqq40.fsf@tcd.ie> (Basil L. Contovounesios's message of "Tue, 09 Mar 2021 15:54:55 +0000")

[-- Attachment #1: Type: text/plain, Size: 1554 bytes --]

On 2021-03-09, 15:54 +0000, "Basil L. Contovounesios" <contovob@tcd.ie> wrote:

> Protesilaos Stavrou <info@protesilaos.com> writes:
>
>> Thank you!  I have amended the patch using the format you recommended.
>
> Thanks, LGTM.
>
> Have you been able to verify that the tarball is created properly,
> and especially that the contained .info file is nonempty?

No, the build always gives me errors.  Though I assumed something was
wrong on my end (I am not familiar with makefiles).  This is not just
with the modus-themes.  Same for something like project.el.  Please see
the attached file with the backtrace.


On 2021-03-09, 11:46 -0500, Stefan Monnier <monnier@iro.umontreal.ca> wrote:

>>> - ("modus-operandi-theme":url "https://gitlab.com/protesilaos/modus-themes")
>>> - ("modus-vivendi-theme"	:url "https://gitlab.com/protesilaos/modus-themes")
>> Also wondering if we need to do anything special before "ripping off
>> this bandaid"[1], or can we also get away with the money like MELPA?
>
> I think "overwrite modus-operandi-theme and modus-vivendi-theme with
> a small package which depends on modus-themes for compatibility and prints some
> kind of deprecation warning, maybe via the autoload mechanism" is the
> better way forward (but this can be done calmly once the `modus-themes`
> is confirmed to be in good shape).

Yes, we can look into this once the package is confirmed to work.

I have no strong opinion about how to handle the old packages.  I prefer
to go with whatever is easier for you.

-- 
Protesilaos Stavrou
protesilaos.com

[-- Attachment #2: 2021-03-09-elpa-make-build-backtrace --]
[-- Type: application/octet-stream, Size: 22236 bytes --]

~/Git/build/elpa $ make build/project
emacs --batch -Q -l admin/elpa-admin.el \
         -f elpaa-batch-pkg-spec-make-dependencies .pkg-descs.mk
emacs --batch -l /home/prot/Git/build/elpa/admin/elpa-admin.el	\
         -f elpaa-batch-make-one-package project
Linking files for package: project
  lisp/progmodes/project.el -> project.el
Debugger entered--Lisp error: (wrong-type-argument stringp nil)
  call-process("git" nil t nil "reset" "--merge" nil)
  apply(call-process "git" nil t nil ("reset" "--merge" nil))
  elpaa--call(t "git" "reset" "--merge" nil)
  (let ((default-directory (elpaa--dirname dir))) (elpaa--call t "git" "reset" "--merge" rev) (elpaa--message "Reverted to release revision %s\n%s" rev (buffer-string)))
  (progn (let ((default-directory (elpaa--dirname dir))) (elpaa--call t "git" "reset" "--merge" rev) (elpaa--message "Reverted to release revision %s\n%s" rev (buffer-string))))
  (unwind-protect (progn (let ((default-directory (elpaa--dirname dir))) (elpaa--call t "git" "reset" "--merge" rev) (elpaa--message "Reverted to release revision %s\n%s" rev (buffer-string)))) (and (buffer-name temp-buffer) (kill-buffer temp-buffer)))
  (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn (let ((default-directory (elpaa--dirname dir))) (elpaa--call t "git" "reset" "--merge" rev) (elpaa--message "Reverted to release revision %s\n%s" rev (buffer-string)))) (and (buffer-name temp-buffer) (kill-buffer temp-buffer))))
  (let ((temp-buffer (generate-new-buffer " *temp*" t))) (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn (let ((default-directory (elpaa--dirname dir))) (elpaa--call t "git" "reset" "--merge" rev) (elpaa--message "Reverted to release revision %s\n%s" rev (buffer-string)))) (and (buffer-name temp-buffer) (kill-buffer temp-buffer)))))
  (if (equal rev cur-rev) (elpaa--message "Current revision is already desired revision!") (let ((temp-buffer (generate-new-buffer " *temp*" t))) (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn (let ((default-directory ...)) (elpaa--call t "git" "reset" "--merge" rev) (elpaa--message "Reverted to release revision %s\n%s" rev (buffer-string)))) (and (buffer-name temp-buffer) (kill-buffer temp-buffer))))))
  (let ((cur-rev (let* ((ftn (file-truename (expand-file-name ... dir))) (default-directory (file-name-directory ftn))) (vc-working-revision ftn)))) (if (equal rev cur-rev) (elpaa--message "Current revision is already desired revision!") (let ((temp-buffer (generate-new-buffer " *temp*" t))) (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn (let (...) (elpaa--call t "git" "reset" "--merge" rev) (elpaa--message "Reverted to release revision %s\n%s" rev ...))) (and (buffer-name temp-buffer) (kill-buffer temp-buffer)))))))
  elpaa--select-revision("/home/prot/Git/build/elpa/packages/project" ("project" :core "lisp/progmodes/project.el") nil)
  (progn (elpaa--select-revision dir pkg-spec (funcall revision-function)))
  (if revision-function (progn (elpaa--select-revision dir pkg-spec (funcall revision-function))))
  (let* ((destdir (file-name-directory tarball)) (pkgname (car pkg-spec)) (_ (if (and destdir (not (file-directory-p destdir))) (progn (make-directory destdir)))) (vers (nth 1 metadata)) (elpaignore (expand-file-name ".elpaignore" dir)) (ignores (elpaa--spec-get pkg-spec :ignored-files)) (renames (elpaa--spec-get pkg-spec :renames)) (ldir (elpaa--spec-get pkg-spec :lisp-dir)) (re (concat "\\`" (regexp-quote pkgname) "-\\([0-9].*\\)\\.\\(tar\\|el\\)\\(\\.[a-z]*z\\)?\\'")) (oldtarballs (if one-tarball nil (mapcar #'(lambda (file) (string-match re file) (cons ... file)) (directory-files destdir nil re))))) (if ldir (progn (setq renames (let* ((va (list ... ""))) (if (member va renames) renames (cons va renames)))))) (if revision-function (progn (elpaa--select-revision dir pkg-spec (funcall revision-function)))) (elpaa--copyright-check pkg-spec) (elpaa--make pkg-spec dir) (elpaa--build-Info pkg-spec dir) (elpaa--write-pkg-file dir pkgname metadata) (progn (or (not (string-match "[][*\\|?]" pkgname)) (cl--assertion-failed '(not (string-match "[][*\\|?]" pkgname)))) nil) (progn (or (not (string-match "[][*\\|?]" vers)) (cl--assertion-failed '(not (string-match "[][*\\|?]" vers)))) nil) (apply #'elpaa--call nil "tar" (cons "--exclude-vcs" (append (cond (ignores (mapcar #'... ignores)) ((file-readable-p elpaignore) (list "-X" elpaignore))) (mapcar #'(lambda (r) (elpaa--make-tar-transform pkgname r)) renames) (list "--transform" (format "s|^packages/%s|%s-%s|" pkgname pkgname vers) "-chf" tarball (concat "packages/" pkgname))))) (if one-tarball nil (let* ((pkgdesc (elpaa--process-multi-file-package dir pkgname 'dont-rename))) (elpaa--message "%s: %S" pkgname pkgdesc) (elpaa--update-archive-contents pkgdesc destdir) (if (and nil revision-function) (progn (let ((default-directory ...)) (elpaa--call nil "git" "tag" "-f" (format "%s-release/%s-%s" elpaa--name pkgname vers))))) (let ((link (expand-file-name (format "%s.tar" pkgname) destdir))) (if (file-symlink-p link) (progn (delete-file link))) (make-symbolic-link (file-name-nondirectory tarball) link)) (setq oldtarballs (elpaa--prune-old-tarballs tarball oldtarballs destdir)) (let* ((default-directory (expand-file-name destdir))) (elpaa--html-make-pkg pkgdesc pkg-spec (cons (cons vers (file-name-nondirectory tarball)) oldtarballs) dir)) (message "Built new package %s!" tarball) 'new)))
  (closure ((one-tarball) (revision-function closure ((tarball . "archive/project-0.5.4.tar") (new) (tarball . "archive-devel/project-0.5.4.0.20210309.20601.tar") (devel-vers . "0.5.4.0.20210309.20601") (date-version . "20210309.20601") (vers . "0.5.4") (metadata nil "0.5.4" "Operations on the current project" ((emacs (26 1)) (xref (1 0 2))) ((:url . "https://elpa.gnu.org/packages/project.html"))) (_) (_) (dir . "/home/prot/Git/build/elpa/packages/project") (pkgname . "project") (one-tarball) (pkg-spec "project" :core "lisp/progmodes/project.el") elpaa--temp-files t) nil (elpaa--get-release-revision dir pkg-spec vers (plist-get (cdr pkg-spec) :version-map))) (metadata nil "0.5.4" "Operations on the current project" ((emacs (26 1)) (xref (1 0 2))) ((:url . "https://elpa.gnu.org/packages/project.html"))) (pkg-spec "project" :core "lisp/progmodes/project.el") (dir . "/home/prot/Git/build/elpa/packages/project") (tarball . "archive/project-0.5.4.tar") elpaa--temp-files t) nil (let* ((destdir (file-name-directory tarball)) (pkgname (car pkg-spec)) (_ (if (and destdir (not (file-directory-p destdir))) (progn (make-directory destdir)))) (vers (nth 1 metadata)) (elpaignore (expand-file-name ".elpaignore" dir)) (ignores (elpaa--spec-get pkg-spec :ignored-files)) (renames (elpaa--spec-get pkg-spec :renames)) (ldir (elpaa--spec-get pkg-spec :lisp-dir)) (re (concat "\\`" (regexp-quote pkgname) "-\\([0-9].*\\)\\.\\(tar\\|el\\)\\(\\.[a-z]*z\\)?\\'")) (oldtarballs (if one-tarball nil (mapcar #'(lambda ... ... ...) (directory-files destdir nil re))))) (if ldir (progn (setq renames (let* ((va ...)) (if (member va renames) renames (cons va renames)))))) (if revision-function (progn (elpaa--select-revision dir pkg-spec (funcall revision-function)))) (elpaa--copyright-check pkg-spec) (elpaa--make pkg-spec dir) (elpaa--build-Info pkg-spec dir) (elpaa--write-pkg-file dir pkgname metadata) (progn (or (not (string-match "[][*\\|?]" pkgname)) (cl--assertion-failed '(not (string-match "[][*\\|?]" pkgname)))) nil) (progn (or (not (string-match "[][*\\|?]" vers)) (cl--assertion-failed '(not (string-match "[][*\\|?]" vers)))) nil) (apply #'elpaa--call nil "tar" (cons "--exclude-vcs" (append (cond (ignores (mapcar ... ignores)) ((file-readable-p elpaignore) (list "-X" elpaignore))) (mapcar #'(lambda ... ...) renames) (list "--transform" (format "s|^packages/%s|%s-%s|" pkgname pkgname vers) "-chf" tarball (concat "packages/" pkgname))))) (if one-tarball nil (let* ((pkgdesc (elpaa--process-multi-file-package dir pkgname 'dont-rename))) (elpaa--message "%s: %S" pkgname pkgdesc) (elpaa--update-archive-contents pkgdesc destdir) (if (and nil revision-function) (progn (let (...) (elpaa--call nil "git" "tag" "-f" ...)))) (let ((link (expand-file-name ... destdir))) (if (file-symlink-p link) (progn (delete-file link))) (make-symbolic-link (file-name-nondirectory tarball) link)) (setq oldtarballs (elpaa--prune-old-tarballs tarball oldtarballs destdir)) (let* ((default-directory (expand-file-name destdir))) (elpaa--html-make-pkg pkgdesc pkg-spec (cons (cons vers ...) oldtarballs) dir)) (message "Built new package %s!" tarball) 'new))))()
  funcall((closure ((one-tarball) (revision-function closure ((tarball . "archive/project-0.5.4.tar") (new) (tarball . "archive-devel/project-0.5.4.0.20210309.20601.tar") (devel-vers . "0.5.4.0.20210309.20601") (date-version . "20210309.20601") (vers . "0.5.4") (metadata nil "0.5.4" "Operations on the current project" ((emacs ...) (xref ...)) ((:url . "https://elpa.gnu.org/packages/project.html"))) (_) (_) (dir . "/home/prot/Git/build/elpa/packages/project") (pkgname . "project") (one-tarball) (pkg-spec "project" :core "lisp/progmodes/project.el") elpaa--temp-files t) nil (elpaa--get-release-revision dir pkg-spec vers (plist-get (cdr pkg-spec) :version-map))) (metadata nil "0.5.4" "Operations on the current project" ((emacs (26 1)) (xref (1 0 2))) ((:url . "https://elpa.gnu.org/packages/project.html"))) (pkg-spec "project" :core "lisp/progmodes/project.el") (dir . "/home/prot/Git/build/elpa/packages/project") (tarball . "archive/project-0.5.4.tar") elpaa--temp-files t) nil (let* ((destdir (file-name-directory tarball)) (pkgname (car pkg-spec)) (_ (if (and destdir (not ...)) (progn (make-directory destdir)))) (vers (nth 1 metadata)) (elpaignore (expand-file-name ".elpaignore" dir)) (ignores (elpaa--spec-get pkg-spec :ignored-files)) (renames (elpaa--spec-get pkg-spec :renames)) (ldir (elpaa--spec-get pkg-spec :lisp-dir)) (re (concat "\\`" (regexp-quote pkgname) "-\\([0-9].*\\)\\.\\(tar\\|el\\)\\(\\.[a-z]*z\\)?\\'")) (oldtarballs (if one-tarball nil (mapcar #'... (directory-files destdir nil re))))) (if ldir (progn (setq renames (let* (...) (if ... renames ...))))) (if revision-function (progn (elpaa--select-revision dir pkg-spec (funcall revision-function)))) (elpaa--copyright-check pkg-spec) (elpaa--make pkg-spec dir) (elpaa--build-Info pkg-spec dir) (elpaa--write-pkg-file dir pkgname metadata) (progn (or (not (string-match "[][*\\|?]" pkgname)) (cl--assertion-failed '(not ...))) nil) (progn (or (not (string-match "[][*\\|?]" vers)) (cl--assertion-failed '(not ...))) nil) (apply #'elpaa--call nil "tar" (cons "--exclude-vcs" (append (cond (ignores ...) (... ...)) (mapcar #'... renames) (list "--transform" (format "s|^packages/%s|%s-%s|" pkgname pkgname vers) "-chf" tarball (concat "packages/" pkgname))))) (if one-tarball nil (let* ((pkgdesc (elpaa--process-multi-file-package dir pkgname ...))) (elpaa--message "%s: %S" pkgname pkgdesc) (elpaa--update-archive-contents pkgdesc destdir) (if (and nil revision-function) (progn (let ... ...))) (let ((link ...)) (if (file-symlink-p link) (progn ...)) (make-symbolic-link (file-name-nondirectory tarball) link)) (setq oldtarballs (elpaa--prune-old-tarballs tarball oldtarballs destdir)) (let* ((default-directory ...)) (elpaa--html-make-pkg pkgdesc pkg-spec (cons ... oldtarballs) dir)) (message "Built new package %s!" tarball) 'new)))))
  (progn (elpaa--clean dir) (funcall f))
  (unwind-protect (progn (elpaa--clean dir) (funcall f)) (elpaa--message "Deleting temp files: %S" elpaa--temp-files) (let ((--dolist-tail-- elpaa--temp-files)) (while --dolist-tail-- (let ((f (car --dolist-tail--))) (if (stringp f) (delete-file f) (funcall f)) (setq --dolist-tail-- (cdr --dolist-tail--))))))
  (let ((elpaa--temp-files nil)) (unwind-protect (progn (elpaa--clean dir) (funcall f)) (elpaa--message "Deleting temp files: %S" elpaa--temp-files) (let ((--dolist-tail-- elpaa--temp-files)) (while --dolist-tail-- (let ((f (car --dolist-tail--))) (if (stringp f) (delete-file f) (funcall f)) (setq --dolist-tail-- (cdr --dolist-tail--)))))))
  elpaa--call-with-temp-files("/home/prot/Git/build/elpa/packages/project" (closure ((one-tarball) (revision-function closure ((tarball . "archive/project-0.5.4.tar") (new) (tarball . "archive-devel/project-0.5.4.0.20210309.20601.tar") (devel-vers . "0.5.4.0.20210309.20601") (date-version . "20210309.20601") (vers . "0.5.4") (metadata nil "0.5.4" "Operations on the current project" ((emacs ...) (xref ...)) ((:url . "https://elpa.gnu.org/packages/project.html"))) (_) (_) (dir . "/home/prot/Git/build/elpa/packages/project") (pkgname . "project") (one-tarball) (pkg-spec "project" :core "lisp/progmodes/project.el") elpaa--temp-files t) nil (elpaa--get-release-revision dir pkg-spec vers (plist-get (cdr pkg-spec) :version-map))) (metadata nil "0.5.4" "Operations on the current project" ((emacs (26 1)) (xref (1 0 2))) ((:url . "https://elpa.gnu.org/packages/project.html"))) (pkg-spec "project" :core "lisp/progmodes/project.el") (dir . "/home/prot/Git/build/elpa/packages/project") (tarball . "archive/project-0.5.4.tar") elpaa--temp-files t) nil (let* ((destdir (file-name-directory tarball)) (pkgname (car pkg-spec)) (_ (if (and destdir (not ...)) (progn (make-directory destdir)))) (vers (nth 1 metadata)) (elpaignore (expand-file-name ".elpaignore" dir)) (ignores (elpaa--spec-get pkg-spec :ignored-files)) (renames (elpaa--spec-get pkg-spec :renames)) (ldir (elpaa--spec-get pkg-spec :lisp-dir)) (re (concat "\\`" (regexp-quote pkgname) "-\\([0-9].*\\)\\.\\(tar\\|el\\)\\(\\.[a-z]*z\\)?\\'")) (oldtarballs (if one-tarball nil (mapcar #'... (directory-files destdir nil re))))) (if ldir (progn (setq renames (let* (...) (if ... renames ...))))) (if revision-function (progn (elpaa--select-revision dir pkg-spec (funcall revision-function)))) (elpaa--copyright-check pkg-spec) (elpaa--make pkg-spec dir) (elpaa--build-Info pkg-spec dir) (elpaa--write-pkg-file dir pkgname metadata) (progn (or (not (string-match "[][*\\|?]" pkgname)) (cl--assertion-failed '(not ...))) nil) (progn (or (not (string-match "[][*\\|?]" vers)) (cl--assertion-failed '(not ...))) nil) (apply #'elpaa--call nil "tar" (cons "--exclude-vcs" (append (cond (ignores ...) (... ...)) (mapcar #'... renames) (list "--transform" (format "s|^packages/%s|%s-%s|" pkgname pkgname vers) "-chf" tarball (concat "packages/" pkgname))))) (if one-tarball nil (let* ((pkgdesc (elpaa--process-multi-file-package dir pkgname ...))) (elpaa--message "%s: %S" pkgname pkgdesc) (elpaa--update-archive-contents pkgdesc destdir) (if (and nil revision-function) (progn (let ... ...))) (let ((link ...)) (if (file-symlink-p link) (progn ...)) (make-symbolic-link (file-name-nondirectory tarball) link)) (setq oldtarballs (elpaa--prune-old-tarballs tarball oldtarballs destdir)) (let* ((default-directory ...)) (elpaa--html-make-pkg pkgdesc pkg-spec (cons ... oldtarballs) dir)) (message "Built new package %s!" tarball) 'new)))))
  (if (or (file-readable-p tarball) (file-readable-p (replace-regexp-in-string "\\.tar\\'" ".el" tarball))) (progn (elpaa--message "Tarball %s already built!" tarball) nil) (elpaa--call-with-temp-files dir #'(lambda nil (let* ((destdir (file-name-directory tarball)) (pkgname (car pkg-spec)) (_ (if ... ...)) (vers (nth 1 metadata)) (elpaignore (expand-file-name ".elpaignore" dir)) (ignores (elpaa--spec-get pkg-spec :ignored-files)) (renames (elpaa--spec-get pkg-spec :renames)) (ldir (elpaa--spec-get pkg-spec :lisp-dir)) (re (concat "\\`" ... "-\\([0-9].*\\)\\.\\(tar\\|el\\)\\(\\.[a-z]*z\\)?\\'")) (oldtarballs (if one-tarball nil ...))) (if ldir (progn (setq renames ...))) (if revision-function (progn (elpaa--select-revision dir pkg-spec ...))) (elpaa--copyright-check pkg-spec) (elpaa--make pkg-spec dir) (elpaa--build-Info pkg-spec dir) (elpaa--write-pkg-file dir pkgname metadata) (progn (or (not ...) (cl--assertion-failed ...)) nil) (progn (or (not ...) (cl--assertion-failed ...)) nil) (apply #'elpaa--call nil "tar" (cons "--exclude-vcs" (append ... ... ...))) (if one-tarball nil (let* (...) (elpaa--message "%s: %S" pkgname pkgdesc) (elpaa--update-archive-contents pkgdesc destdir) (if ... ...) (let ... ... ...) (setq oldtarballs ...) (let* ... ...) (message "Built new package %s!" tarball) 'new))))))
  elpaa--make-one-tarball("archive/project-0.5.4.tar" "/home/prot/Git/build/elpa/packages/project" ("project" :core "lisp/progmodes/project.el") (nil "0.5.4" "Operations on the current project" ((emacs (26 1)) (xref (1 0 2))) ((:url . "https://elpa.gnu.org/packages/project.html"))) (closure ((tarball . "archive/project-0.5.4.tar") (new) (tarball . "archive-devel/project-0.5.4.0.20210309.20601.tar") (devel-vers . "0.5.4.0.20210309.20601") (date-version . "20210309.20601") (vers . "0.5.4") (metadata nil "0.5.4" "Operations on the current project" ((emacs (26 1)) (xref (1 0 2))) ((:url . "https://elpa.gnu.org/packages/project.html"))) (_) (_) (dir . "/home/prot/Git/build/elpa/packages/project") (pkgname . "project") (one-tarball) (pkg-spec "project" :core "lisp/progmodes/project.el") elpaa--temp-files t) nil (elpaa--get-release-revision dir pkg-spec vers (plist-get (cdr pkg-spec) :version-map))))
  (if (elpaa--make-one-tarball tarball dir pkg-spec metadata #'(lambda nil (elpaa--get-release-revision dir pkg-spec vers (plist-get (cdr pkg-spec) :version-map)))) (progn (elpaa--release-email pkg-spec metadata dir)))
  (let ((tarball (concat elpaa--release-subdir (format "%s-%s.tar" pkgname vers)))) (if (elpaa--make-one-tarball tarball dir pkg-spec metadata #'(lambda nil (elpaa--get-release-revision dir pkg-spec vers (plist-get (cdr pkg-spec) :version-map)))) (progn (elpaa--release-email pkg-spec metadata dir))))
  (cond (one-tarball nil) ((or (equal vers "0") (member '-4 (version-to-list vers))) (cond ((equal vers "0") (elpaa--message "Package %s not released yet!" pkgname)) ((not new) (elpaa--message "Nothing new for package %s!" pkgname)) (t (let* ((last-rel (elpaa--get-last-release pkg-spec)) (tarball (concat elpaa--release-subdir ...)) (metadata (cons nil ...))) (if (not last-rel) (elpaa--message "Package %s not released yet!" pkgname) (if (elpaa--make-one-tarball tarball dir pkg-spec metadata ...) (progn ...))))))) (t (let ((tarball (concat elpaa--release-subdir (format "%s-%s.tar" pkgname vers)))) (if (elpaa--make-one-tarball tarball dir pkg-spec metadata #'(lambda nil (elpaa--get-release-revision dir pkg-spec vers ...))) (progn (elpaa--release-email pkg-spec metadata dir))))))
  (let* ((date-version (elpaa--get-devel-version dir pkg-spec)) (devel-vers (concat vers (if (string-match "[0-9]\\'" vers) ".") "0." date-version)) (tarball (or one-tarball (concat elpaa--devel-subdir (format "%s-%s.tar" pkgname devel-vers)))) (new (let ((elpaa--name (concat elpaa--name "-devel"))) (elpaa--make-one-tarball tarball dir pkg-spec (cons nil (cons devel-vers (nthcdr 2 metadata))) nil one-tarball)))) (cond (one-tarball nil) ((or (equal vers "0") (member '-4 (version-to-list vers))) (cond ((equal vers "0") (elpaa--message "Package %s not released yet!" pkgname)) ((not new) (elpaa--message "Nothing new for package %s!" pkgname)) (t (let* ((last-rel ...) (tarball ...) (metadata ...)) (if (not last-rel) (elpaa--message "Package %s not released yet!" pkgname) (if ... ...)))))) (t (let ((tarball (concat elpaa--release-subdir (format "%s-%s.tar" pkgname vers)))) (if (elpaa--make-one-tarball tarball dir pkg-spec metadata #'(lambda nil ...)) (progn (elpaa--release-email pkg-spec metadata dir)))))))
  (if (null metadata) (error "No metadata found for package: %s" pkgname) (let* ((v metadata)) (setcar v nil)) (let* ((date-version (elpaa--get-devel-version dir pkg-spec)) (devel-vers (concat vers (if (string-match "[0-9]\\'" vers) ".") "0." date-version)) (tarball (or one-tarball (concat elpaa--devel-subdir (format "%s-%s.tar" pkgname devel-vers)))) (new (let ((elpaa--name (concat elpaa--name "-devel"))) (elpaa--make-one-tarball tarball dir pkg-spec (cons nil (cons devel-vers ...)) nil one-tarball)))) (cond (one-tarball nil) ((or (equal vers "0") (member '-4 (version-to-list vers))) (cond ((equal vers "0") (elpaa--message "Package %s not released yet!" pkgname)) ((not new) (elpaa--message "Nothing new for package %s!" pkgname)) (t (let* (... ... ...) (if ... ... ...))))) (t (let ((tarball (concat elpaa--release-subdir ...))) (if (elpaa--make-one-tarball tarball dir pkg-spec metadata #'...) (progn (elpaa--release-email pkg-spec metadata dir))))))))
  (let* ((pkgname (car pkg-spec)) (dir (expand-file-name pkgname "packages")) (_ (cond (one-tarball nil) ((eq (nth 1 pkg-spec) :core) (elpaa--core-package-sync pkg-spec)) (t (elpaa--worktree-sync pkg-spec)))) (_ (elpaa--message "pkg-spec for %s: %S" pkgname pkg-spec)) (metadata (elpaa--metadata dir pkg-spec)) (vers (nth 1 metadata))) (elpaa--message "metadata = %S" metadata) (if (null metadata) (error "No metadata found for package: %s" pkgname) (let* ((v metadata)) (setcar v nil)) (let* ((date-version (elpaa--get-devel-version dir pkg-spec)) (devel-vers (concat vers (if (string-match "[0-9]\\'" vers) ".") "0." date-version)) (tarball (or one-tarball (concat elpaa--devel-subdir (format "%s-%s.tar" pkgname devel-vers)))) (new (let ((elpaa--name ...)) (elpaa--make-one-tarball tarball dir pkg-spec (cons nil ...) nil one-tarball)))) (cond (one-tarball nil) ((or (equal vers "0") (member '-4 (version-to-list vers))) (cond ((equal vers "0") (elpaa--message "Package %s not released yet!" pkgname)) ((not new) (elpaa--message "Nothing new for package %s!" pkgname)) (t (let* ... ...)))) (t (let ((tarball ...)) (if (elpaa--make-one-tarball tarball dir pkg-spec metadata ...) (progn ...))))))))
  elpaa--make-one-package(("project" :core "lisp/progmodes/project.el"))
  (while command-line-args-left (elpaa--make-one-package (elpaa--get-package-spec (car-safe (prog1 command-line-args-left (setq command-line-args-left (cdr command-line-args-left)))))))
  elpaa-batch-make-one-package()
  command-line-1(("-l" "/home/prot/Git/build/elpa/admin/elpa-admin.el" "-f" "elpaa-batch-make-one-package" "project"))
  command-line()
  normal-top-level()

make: *** [GNUmakefile:21: build/project] Error 255

  parent reply	other threads:[~2021-03-09 19:08 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-06 11:58 bug#46964: [ELPA]: [PATCH] Replace modus-*-theme with modus-themes from :core Protesilaos Stavrou
2021-03-06 14:39 ` Basil L. Contovounesios
2021-03-06 15:00   ` Stefan Monnier
2021-03-06 16:19     ` Protesilaos Stavrou
2021-03-06 18:35       ` Stefan Monnier
2021-03-07  7:32         ` Protesilaos Stavrou
2021-03-09 15:54           ` Basil L. Contovounesios
2021-03-09 16:46             ` Stefan Monnier
2021-03-09 19:08             ` Protesilaos Stavrou [this message]
2021-03-09 20:49               ` Stefan Monnier
2021-03-10  3:48                 ` Stefan Monnier
2021-03-10  5:43                   ` Protesilaos Stavrou
2021-03-10 18:41                     ` Stefan Monnier
2021-03-10 20:13                       ` Protesilaos Stavrou
2021-03-10 23:17                         ` Stefan Monnier
2021-03-10 23:23                           ` Basil L. Contovounesios
2021-03-11  3:07                             ` Stefan Monnier
2021-03-11  8:27                               ` Protesilaos Stavrou
2021-03-11 19:45                                 ` Basil L. Contovounesios
2021-03-11 22:54                                 ` Stefan Monnier
2021-03-12  7:59                                   ` Protesilaos Stavrou
2021-03-13 17:10                           ` Stefan Monnier
2021-03-17  7:04                             ` Protesilaos Stavrou
2021-03-18  7:55                               ` Protesilaos Stavrou
2021-03-18 17:52                                 ` Stefan Monnier
2021-03-19  5:29                                   ` Protesilaos Stavrou
2021-03-19 12:55                                     ` Stefan Monnier
2021-03-19 14:18                                       ` Protesilaos Stavrou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874khk6t7d.fsf@protesilaos.com \
    --to=info@protesilaos.com \
    --cc=46964@debbugs.gnu.org \
    --cc=contovob@tcd.ie \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).