unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Juri Linkov <juri@linkov.net>
Cc: Michael Heerdegen <michael_heerdegen@web.de>,
	45607@debbugs.gnu.org, Allen Li <darkfeline@felesatra.moe>
Subject: bug#45607: 27.1; compiled replace-string breaks repeat-complex-command
Date: Fri, 12 Aug 2022 15:01:47 +0200	[thread overview]
Message-ID: <87h72hr4xw.fsf@gnus.org> (raw)
In-Reply-To: <86tu6lnrip.fsf@mail.linkov.net> (Juri Linkov's message of "Tue,  09 Aug 2022 22:30:54 +0300")

Juri Linkov <juri@linkov.net> writes:

> Interesting, there are not too many uses of this pattern,
> and most of them are related to replacement commands.
> Ok, I could replace them with adding interactive-args.
>
> lisp/isearch.el
> 2392:      (if (use-region-p) (region-beginning))
> 2393:      (if (use-region-p) (region-end))
> lisp/replace.el
> 464: 	   (if (use-region-p) (region-beginning))
> 465: 	   (if (use-region-p) (region-end))
> 558: 	   (if (use-region-p) (region-beginning))
> 559: 	   (if (use-region-p) (region-end))
> 606: 	   (if (use-region-p) (region-beginning))
> 607: 	   (if (use-region-p) (region-end))
> 761: 	   (if (use-region-p) (region-beginning))
> 762: 	   (if (use-region-p) (region-end))
> lisp/textmodes/paragraphs.el
> 518:                      (if (use-region-p) (region-beginning))
> 519:                      (if (use-region-p) (region-end))))
> lisp/vc/log-view.el
> 581:    (list (if (use-region-p) (region-beginning) (point))
> 582:          (if (use-region-p) (region-end) (point))))
> 596:    (list (if (use-region-p) (region-beginning) (point))
> 597:          (if (use-region-p) (region-end) (point))))

That's fewer than I'd have guessed -- but I guess that quite a few
commands stash the logic down into the function body instead of putting
it into the `interactive' spec.  Commands like `duplicate-dwim', for
instance, could be pretty easily fixed in that way, for instance.





  reply	other threads:[~2022-08-12 13:01 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-02  9:04 bug#45607: 27.1; compiled replace-string breaks repeat-complex-command Allen Li
2022-06-07 12:38 ` Lars Ingebrigtsen
2022-06-07 18:40   ` Juri Linkov
2022-06-07 18:58     ` Eli Zaretskii
2022-06-09  8:39       ` Allen Li
2022-06-09  9:23         ` Eli Zaretskii
2022-06-08 12:05     ` Lars Ingebrigtsen
2022-06-09 18:52       ` Lars Ingebrigtsen
2022-06-09 18:56         ` Lars Ingebrigtsen
2022-06-09 20:51           ` Drew Adams
2022-07-05 14:41           ` Michael Heerdegen
2022-07-05 16:45             ` Lars Ingebrigtsen
2022-07-05 18:47               ` Michael Heerdegen
2022-07-06  7:53             ` Juri Linkov
2022-07-06 11:35               ` Lars Ingebrigtsen
2022-07-06 18:39                 ` Juri Linkov
2022-07-07  8:02                   ` Lars Ingebrigtsen
2022-08-08 13:53                     ` Lars Ingebrigtsen
2022-08-08 17:07                       ` Juri Linkov
2022-08-09 15:00                         ` Lars Ingebrigtsen
2022-08-09 18:41                           ` Juri Linkov
2022-08-09 18:48                             ` Eli Zaretskii
2022-08-09 19:15                               ` Lars Ingebrigtsen
2022-08-09 19:25                                 ` Eli Zaretskii
2022-08-09 19:30                                   ` Lars Ingebrigtsen
2022-08-09 19:14                             ` Lars Ingebrigtsen
2022-08-09 19:30                               ` Juri Linkov
2022-08-12 13:01                                 ` Lars Ingebrigtsen [this message]
2022-08-12 17:39                                   ` Juri Linkov
2022-08-13 11:46                                     ` Lars Ingebrigtsen
2022-08-13 19:30                                       ` Juri Linkov
2022-08-15  6:37                                         ` Lars Ingebrigtsen
2022-09-04 16:57                                 ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h72hr4xw.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=45607@debbugs.gnu.org \
    --cc=darkfeline@felesatra.moe \
    --cc=juri@linkov.net \
    --cc=michael_heerdegen@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).