From: Lars Ingebrigtsen <larsi@gnus.org>
To: Juri Linkov <juri@linkov.net>
Cc: 45607@debbugs.gnu.org, Allen Li <darkfeline@felesatra.moe>
Subject: bug#45607: 27.1; compiled replace-string breaks repeat-complex-command
Date: Thu, 09 Jun 2022 20:52:57 +0200 [thread overview]
Message-ID: <87v8t9y8hi.fsf@gnus.org> (raw)
In-Reply-To: <87y1y79x82.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 08 Jun 2022 14:05:33 +0200")
Lars Ingebrigtsen <larsi@gnus.org> writes:
> could be something like
>
> (interactive-region-beginning)
> (interactive-region-end)
>
> and whatever updates command-history would reify those as is instead of
> their return values?
Sometimes it's helpful to actually look at the code. All this magic
comes from:
/* If the list of args INPUT was produced with an explicit call to
`list', look for elements that were computed with
(region-beginning) or (region-end), and put those expressions into
VALUES instead of the present values.
This function doesn't return a value because it modifies elements
of VALUES to do its job. */
static void
fix_command (Lisp_Object input, Lisp_Object values)
{
/* FIXME: Instead of this ugly hack, we should provide a way for an
interactive spec to return an expression/function that will re-build the
args without user intervention. */
if (CONSP (input))
And what this does is to try to hack its way through the lisp code in an
interactive spec like
/* Skip through certain special forms. */
while (EQ (car, Qlet) || EQ (car, Qletx)
|| EQ (car, Qsave_excursion)
|| EQ (car, Qprogn))
looking for `region-beginning' and friends. But we now byte-compile the
interactive specs, so all this fails spectacularly.
So we need a brand new way to specify which options are
`region-beginning' etc. Perhaps with a declare form? (That translates
into symbol properties, I guess.)
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2022-06-09 18:52 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-02 9:04 bug#45607: 27.1; compiled replace-string breaks repeat-complex-command Allen Li
2022-06-07 12:38 ` Lars Ingebrigtsen
2022-06-07 18:40 ` Juri Linkov
2022-06-07 18:58 ` Eli Zaretskii
2022-06-09 8:39 ` Allen Li
2022-06-09 9:23 ` Eli Zaretskii
2022-06-08 12:05 ` Lars Ingebrigtsen
2022-06-09 18:52 ` Lars Ingebrigtsen [this message]
2022-06-09 18:56 ` Lars Ingebrigtsen
2022-06-09 20:51 ` Drew Adams
2022-07-05 14:41 ` Michael Heerdegen
2022-07-05 16:45 ` Lars Ingebrigtsen
2022-07-05 18:47 ` Michael Heerdegen
2022-07-06 7:53 ` Juri Linkov
2022-07-06 11:35 ` Lars Ingebrigtsen
2022-07-06 18:39 ` Juri Linkov
2022-07-07 8:02 ` Lars Ingebrigtsen
2022-08-08 13:53 ` Lars Ingebrigtsen
2022-08-08 17:07 ` Juri Linkov
2022-08-09 15:00 ` Lars Ingebrigtsen
2022-08-09 18:41 ` Juri Linkov
2022-08-09 18:48 ` Eli Zaretskii
2022-08-09 19:15 ` Lars Ingebrigtsen
2022-08-09 19:25 ` Eli Zaretskii
2022-08-09 19:30 ` Lars Ingebrigtsen
2022-08-09 19:14 ` Lars Ingebrigtsen
2022-08-09 19:30 ` Juri Linkov
2022-08-12 13:01 ` Lars Ingebrigtsen
2022-08-12 17:39 ` Juri Linkov
2022-08-13 11:46 ` Lars Ingebrigtsen
2022-08-13 19:30 ` Juri Linkov
2022-08-15 6:37 ` Lars Ingebrigtsen
2022-09-04 16:57 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8t9y8hi.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=45607@debbugs.gnu.org \
--cc=darkfeline@felesatra.moe \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).