From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#45607: 27.1; compiled replace-string breaks repeat-complex-command Date: Fri, 12 Aug 2022 15:01:47 +0200 Message-ID: <87h72hr4xw.fsf@gnus.org> References: <80o8i7676p.fsf@felesatra.moe> <87czfkir6n.fsf@gnus.org> <86r1402un1.fsf@mail.linkov.net> <87y1y79x82.fsf@gnus.org> <87v8t9y8hi.fsf@gnus.org> <87r13xy8c3.fsf@gnus.org> <871quzaagc.fsf@web.de> <861quywusu.fsf@mail.linkov.net> <8735felbi7.fsf@gnus.org> <864jzursq8.fsf@mail.linkov.net> <87zghlgxk4.fsf@gnus.org> <87bksuzvs5.fsf@gnus.org> <86iln264vg.fsf@mail.linkov.net> <871qtpzck5.fsf@gnus.org> <868rnxqmy3.fsf@mail.linkov.net> <87r11ptek3.fsf@gnus.org> <86tu6lnrip.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29139"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Michael Heerdegen , 45607@debbugs.gnu.org, Allen Li To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 12 15:02:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oMUIm-0007LI-EV for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 12 Aug 2022 15:02:12 +0200 Original-Received: from localhost ([::1]:54912 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oMUIl-0005zz-Ez for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 12 Aug 2022 09:02:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51038) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oMUIc-0005yy-Eu for bug-gnu-emacs@gnu.org; Fri, 12 Aug 2022 09:02:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37911) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oMUIc-0008Px-69 for bug-gnu-emacs@gnu.org; Fri, 12 Aug 2022 09:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oMUIc-00063E-0Q for bug-gnu-emacs@gnu.org; Fri, 12 Aug 2022 09:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Aug 2022 13:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45607 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 45607-submit@debbugs.gnu.org id=B45607.166030931923252 (code B ref 45607); Fri, 12 Aug 2022 13:02:01 +0000 Original-Received: (at 45607) by debbugs.gnu.org; 12 Aug 2022 13:01:59 +0000 Original-Received: from localhost ([127.0.0.1]:55893 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oMUIZ-00062y-F6 for submit@debbugs.gnu.org; Fri, 12 Aug 2022 09:01:59 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:54274) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oMUIX-00062k-Ik for 45607@debbugs.gnu.org; Fri, 12 Aug 2022 09:01:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Eh1df1ElCLS9IccWu75yIS+eKolU49nXWEEY6aUNrH4=; b=cFnH2ozEPrQAi/+kTh+sOQ1w3A wjqoSzFzU1wZeLgu4/IYXqfoyq0CTOoW3noEMKSm9z16gOCwlLBPuN1H8yFFILWZwNmx41i5U5Emz WVa7UJ6dCRCaBeJXv4rtfSEEBkD3isBv13NpKeu6Xfp9SoUKZlHRXFAvN9yNQka12OKY=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oMUIO-00057d-Fa; Fri, 12 Aug 2022 15:01:50 +0200 In-Reply-To: <86tu6lnrip.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 09 Aug 2022 22:30:54 +0300") X-Now-Playing: Two Nice Girls's _Chloe Liked Olivia_: "For the Inauguration" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:239410 Archived-At: Juri Linkov writes: > Interesting, there are not too many uses of this pattern, > and most of them are related to replacement commands. > Ok, I could replace them with adding interactive-args. > > lisp/isearch.el > 2392: (if (use-region-p) (region-beginning)) > 2393: (if (use-region-p) (region-end)) > lisp/replace.el > 464: (if (use-region-p) (region-beginning)) > 465: (if (use-region-p) (region-end)) > 558: (if (use-region-p) (region-beginning)) > 559: (if (use-region-p) (region-end)) > 606: (if (use-region-p) (region-beginning)) > 607: (if (use-region-p) (region-end)) > 761: (if (use-region-p) (region-beginning)) > 762: (if (use-region-p) (region-end)) > lisp/textmodes/paragraphs.el > 518: (if (use-region-p) (region-beginning)) > 519: (if (use-region-p) (region-end)))) > lisp/vc/log-view.el > 581: (list (if (use-region-p) (region-beginning) (point)) > 582: (if (use-region-p) (region-end) (point)))) > 596: (list (if (use-region-p) (region-beginning) (point)) > 597: (if (use-region-p) (region-end) (point)))) That's fewer than I'd have guessed -- but I guess that quite a few commands stash the logic down into the function body instead of putting it into the `interactive' spec. Commands like `duplicate-dwim', for instance, could be pretty easily fixed in that way, for instance.