From: Michael Albinus <michael.albinus@gmx.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 60505@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>,
Gregory Heytings <gregory@heytings.org>,
julien@jroy.ca
Subject: bug#60505: 29.0.60; Fido Mode and Tramp Completion
Date: Fri, 03 Feb 2023 20:23:26 +0100 [thread overview]
Message-ID: <87h6w2d041.fsf@gmx.de> (raw)
In-Reply-To: <jwv1qn6bo56.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Fri, 03 Feb 2023 13:43:07 -0500")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
Hi Stefan,
>> +(defun tramp-completion-handle-expand-file-name (filename &optional directory)
>> + "Like `expand-file-name' for partial Tramp files."
>> + (if (file-name-absolute-p filename)
>> + filename
>> + (concat (or directory default-directory "/") filename)))
>
> Hmm... shouldn't a "/" may need to be added if `directory` or
> `default-directory` doesn't end with one (except in cases like `/ssh:`)?
Rather not. We're speaking about the tramp-completion-file-name-handler,
which is activated for file names matching
"\\`\\(?:\\)?/\\(?:\\(?:\\(-\\|[[:alnum:]]\\{2,\\}\\)\\(?::\\)\\(?:\\([^/:|[:blank:]]+\\)\\(?:@\\)\\)?\\(\\(?:[%._[:alnum:]-]+\\|\\(?:\\[\\)\\(?:\\(?:[[:alnum:]]*:\\)+[.[:alnum:]]*\\)?\\(?:]\\)\\)\\(?:\\(?:#\\)\\(?:[[:digit:]]+\\)\\)?\\)?\\)\\(?:|\\)\\)*\\(?:\\(?:-\\|[[:alnum:]]+\\)\\(?:\\(?::\\)\\(?:[%._[:alnum:]-]+\\)?\\)?\\)?\\'".
It looks complex, but in practice it is everything until
"/method:user@host" without a trailing colon. No slash there.
It's value is
--8<---------------cut here---------------start------------->8---
(rx
bos
;; `file-name-completion' uses absolute paths for matching.
;; This means that on W32 systems, something like
;; "/ssh:host:~/path" becomes "c:/ssh:host:~/path". See also
;; `tramp-drop-volume-letter'.
(? (regexp tramp-volume-letter-regexp))
;; We cannot use `tramp-prefix-regexp', because it starts with `bol'.
(literal tramp-prefix-format)
;; Optional multi hops.
(* (regexp tramp-remote-file-name-spec-regexp)
(regexp tramp-postfix-hop-regexp))
;; Last hop.
(? (regexp tramp-completion-method-regexp)
;; Method separator, user name and host name.
(? (regexp tramp-postfix-method-regexp)
;; This is a little bit lax, but it serves.
(? (regexp tramp-host-regexp))))
eos)
--8<---------------cut here---------------end--------------->8---
> Then again, maybe not. I don't understand enough of the details of when
> `tramp-completion-file-name-handler` is used (IOW what is meant exactly by
> "partial Tramp file name").
Exactly that.
> I didn't remember this part of the design, but it sounds good and does
> make changes to that part (like the proposed patch) "safer", so it's
> probably OK to try it on `master`.
There is no special design for it. Ordinary file name handler machinery.
> I wonder how this patch interacts with `locate-dominating-file`.
I'll check tomorrow. But since there isn't a slash in such filenames
(except the leading one), I expect it shall work. Needs more testing,
this case and other use cases.
> Stefan
Best regards, Michael.
next prev parent reply other threads:[~2023-02-03 19:23 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-02 19:37 bug#60505: 29.0.60; Fido Mode and Tramp Completion Julien Roy
2023-01-03 8:56 ` Michael Albinus
2023-01-05 13:07 ` Gregory Heytings
2023-01-05 13:55 ` Michael Albinus
2023-01-05 14:14 ` Gregory Heytings
2023-01-06 9:51 ` Gregory Heytings
2023-01-14 21:37 ` Gregory Heytings
2023-01-15 19:23 ` Michael Albinus
2023-01-15 22:38 ` Gregory Heytings
2023-01-18 12:30 ` Michael Albinus
2023-02-01 18:12 ` Gregory Heytings
2023-02-01 20:15 ` Michael Albinus
2023-02-01 21:27 ` Gregory Heytings
2023-02-02 6:37 ` Eli Zaretskii
2023-02-02 8:25 ` Michael Albinus
2023-02-02 9:15 ` Eli Zaretskii
2023-02-02 15:39 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-03 15:40 ` Michael Albinus
2023-02-03 18:43 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-03 19:23 ` Michael Albinus [this message]
2023-02-03 20:51 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-04 16:04 ` Michael Albinus
2023-02-04 16:48 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-03 22:33 ` Gregory Heytings
2023-02-04 9:54 ` Michael Albinus
2023-02-06 17:26 ` Michael Albinus
2023-02-06 17:41 ` Gregory Heytings
2023-02-07 0:35 ` Michael Heerdegen
2023-02-07 8:54 ` Michael Albinus
2023-02-07 18:20 ` Michael Heerdegen
2023-02-07 18:30 ` Michael Albinus
2023-02-07 20:39 ` Michael Heerdegen
[not found] ` <87357h19qj.fsf@dick>
2023-02-08 8:05 ` Michael Albinus
2023-02-08 11:27 ` dick
2023-02-08 13:08 ` Michael Albinus
2023-02-08 13:20 ` Eli Zaretskii
2023-02-08 14:13 ` dick
2023-02-08 14:42 ` Michael Albinus
2023-02-08 13:30 ` dick
2023-02-08 15:04 ` Michael Albinus
2023-02-07 22:22 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-08 15:11 ` Michael Albinus
2023-02-08 16:18 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-08 17:59 ` Michael Albinus
2023-02-08 19:03 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-10 16:55 ` Michael Albinus
2023-02-12 19:26 ` Michael Albinus
2023-02-07 19:18 ` Michael Heerdegen
2023-02-08 15:09 ` Michael Albinus
2023-02-09 0:38 ` Michael Heerdegen
2023-02-03 0:23 ` Gregory Heytings
2023-02-03 7:43 ` Juri Linkov
2023-02-03 8:39 ` Michael Albinus
2023-02-03 12:01 ` Eli Zaretskii
2023-02-02 15:16 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-02 15:05 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-05 20:58 ` Julien Roy
[not found] <874k4xblcy.fsf.ref@aol.com>
2022-02-17 14:47 ` bug#54042: 29.0.50; fido-mode and ssh not listing hosts Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-17 16:43 ` Michael Albinus
[not found] ` <handler.54042.D60505.167623003032452.notifdone@debbugs.gnu.org>
2023-02-15 18:31 ` bug#54042: closed (Re: bug#60505: 29.0.60; Fido Mode and Tramp Completion) Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-16 8:51 ` Michael Albinus
2023-02-18 17:25 ` Michael Albinus
2023-02-19 2:04 ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-19 9:53 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6w2d041.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=60505@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=gregory@heytings.org \
--cc=julien@jroy.ca \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).