* bug#3948: 23.1.50; Please mark list-colors buffer unmodified @ 2009-07-27 16:25 ` Lennart Borgman 2009-08-04 21:33 ` Juri Linkov 2009-10-31 20:25 ` bug#3948: marked as done (23.1.50; Please mark list-colors buffer unmodified) Emacs bug Tracking System 0 siblings, 2 replies; 3+ messages in thread From: Lennart Borgman @ 2009-07-27 16:25 UTC (permalink / raw) To: emacs-pretest-bug It is rather annoying that it is marked as modified. Perhaps there are more buffers that are marked modified but are not that? In GNU Emacs 23.1.50.1 (i386-mingw-nt5.1.2600) of 2009-06-30 Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (3.4) --no-opt --cflags -Ic:/g/include -fno-crossjumping' ^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#3948: 23.1.50; Please mark list-colors buffer unmodified 2009-07-27 16:25 ` bug#3948: 23.1.50; Please mark list-colors buffer unmodified Lennart Borgman @ 2009-08-04 21:33 ` Juri Linkov 2009-10-31 20:25 ` bug#3948: marked as done (23.1.50; Please mark list-colors buffer unmodified) Emacs bug Tracking System 1 sibling, 0 replies; 3+ messages in thread From: Juri Linkov @ 2009-08-04 21:33 UTC (permalink / raw) To: Lennart Borgman; +Cc: 3948 > It is rather annoying that it is marked as modified. Perhaps there are > more buffers that are marked modified but are not that? `list-colors-display' is non-standard since it outputs the buffer's content in `temp-buffer-show-hook' to be able to align hex numbers at the window's right edge. This can be fixed by restoring the `modified' flag explicitly: Index: lisp/facemenu.el =================================================================== RCS file: /sources/emacs/emacs/lisp/facemenu.el,v retrieving revision 1.108 diff -c -r1.108 facemenu.el *** lisp/facemenu.el 18 Apr 2009 13:50:23 -0000 1.108 --- lisp/facemenu.el 4 Aug 2009 21:32:16 -0000 *************** *** 493,499 **** ;; to get the right value of window-width in list-colors-print ;; after the buffer is displayed. (add-hook 'temp-buffer-show-hook ! (lambda () (list-colors-print list)) nil t))))) (defun list-colors-print (list) (dolist (color list) --- 574,584 ---- ;; to get the right value of window-width in list-colors-print ;; after the buffer is displayed. (add-hook 'temp-buffer-show-hook ! (lambda () ! (set-buffer-modified-p ! (prog1 (buffer-modified-p) ! (list-colors-print list)))) ! nil t))))) (defun list-colors-print (list) (dolist (color list) -- Juri Linkov http://www.jurta.org/emacs/ ^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#3948: marked as done (23.1.50; Please mark list-colors buffer unmodified) 2009-07-27 16:25 ` bug#3948: 23.1.50; Please mark list-colors buffer unmodified Lennart Borgman 2009-08-04 21:33 ` Juri Linkov @ 2009-10-31 20:25 ` Emacs bug Tracking System 1 sibling, 0 replies; 3+ messages in thread From: Emacs bug Tracking System @ 2009-10-31 20:25 UTC (permalink / raw) To: Chong Yidong [-- Attachment #1: Type: text/plain, Size: 900 bytes --] Your message dated Sat, 31 Oct 2009 16:16:53 -0400 with message-id <871vkje2tm.fsf@stupidchicken.com> and subject line Re: bug#3948: 23.1.50; Please mark list-colors buffer unmodified has caused the Emacs bug report #3948, regarding 23.1.50; Please mark list-colors buffer unmodified to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) -- 3948: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3948 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems [-- Attachment #2: Type: message/rfc822, Size: 3200 bytes --] From: Lennart Borgman <lennart.borgman@gmail.com> To: emacs-pretest-bug@gnu.org Subject: 23.1.50; Please mark list-colors buffer unmodified Date: Mon, 27 Jul 2009 18:25:39 +0200 Message-ID: <e01d8a50907270925g539e7caauecf92e0b18242c76@mail.gmail.com> It is rather annoying that it is marked as modified. Perhaps there are more buffers that are marked modified but are not that? In GNU Emacs 23.1.50.1 (i386-mingw-nt5.1.2600) of 2009-06-30 Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (3.4) --no-opt --cflags -Ic:/g/include -fno-crossjumping' [-- Attachment #3: Type: message/rfc822, Size: 1815 bytes --] From: Chong Yidong <cyd@stupidchicken.com> To: Juri Linkov <juri@jurta.org> Cc: Lennart Borgman <lennart.borgman@gmail.com>, 3948-done@emacsbugs.donarmstrong.com Subject: Re: bug#3948: 23.1.50; Please mark list-colors buffer unmodified Date: Sat, 31 Oct 2009 16:16:53 -0400 Message-ID: <871vkje2tm.fsf@stupidchicken.com> > `list-colors-display' is non-standard since it outputs the buffer's > content in `temp-buffer-show-hook' to be able to align hex numbers > at the window's right edge. This can be fixed by restoring the > `modified' flag explicitly: I've checked in your patch, thanks. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-10-31 20:25 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <871vkje2tm.fsf@stupidchicken.com> 2009-07-27 16:25 ` bug#3948: 23.1.50; Please mark list-colors buffer unmodified Lennart Borgman 2009-08-04 21:33 ` Juri Linkov 2009-10-31 20:25 ` bug#3948: marked as done (23.1.50; Please mark list-colors buffer unmodified) Emacs bug Tracking System
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).