From: Juri Linkov <juri@jurta.org>
To: Lennart Borgman <lennart.borgman@gmail.com>
Cc: 3948@emacsbugs.donarmstrong.com
Subject: bug#3948: 23.1.50; Please mark list-colors buffer unmodified
Date: Wed, 05 Aug 2009 00:33:51 +0300 [thread overview]
Message-ID: <87fxc7b6rw.fsf@mail.jurta.org> (raw)
In-Reply-To: <e01d8a50907270925g539e7caauecf92e0b18242c76@mail.gmail.com> (Lennart Borgman's message of "Mon, 27 Jul 2009 18:25:39 +0200")
> It is rather annoying that it is marked as modified. Perhaps there are
> more buffers that are marked modified but are not that?
`list-colors-display' is non-standard since it outputs the buffer's
content in `temp-buffer-show-hook' to be able to align hex numbers
at the window's right edge. This can be fixed by restoring the
`modified' flag explicitly:
Index: lisp/facemenu.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/facemenu.el,v
retrieving revision 1.108
diff -c -r1.108 facemenu.el
*** lisp/facemenu.el 18 Apr 2009 13:50:23 -0000 1.108
--- lisp/facemenu.el 4 Aug 2009 21:32:16 -0000
***************
*** 493,499 ****
;; to get the right value of window-width in list-colors-print
;; after the buffer is displayed.
(add-hook 'temp-buffer-show-hook
! (lambda () (list-colors-print list)) nil t)))))
(defun list-colors-print (list)
(dolist (color list)
--- 574,584 ----
;; to get the right value of window-width in list-colors-print
;; after the buffer is displayed.
(add-hook 'temp-buffer-show-hook
! (lambda ()
! (set-buffer-modified-p
! (prog1 (buffer-modified-p)
! (list-colors-print list))))
! nil t)))))
(defun list-colors-print (list)
(dolist (color list)
--
Juri Linkov
http://www.jurta.org/emacs/
next prev parent reply other threads:[~2009-08-04 21:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <871vkje2tm.fsf@stupidchicken.com>
2009-07-27 16:25 ` bug#3948: 23.1.50; Please mark list-colors buffer unmodified Lennart Borgman
2009-08-04 21:33 ` Juri Linkov [this message]
2009-10-31 20:25 ` bug#3948: marked as done (23.1.50; Please mark list-colors buffer unmodified) Emacs bug Tracking System
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fxc7b6rw.fsf@mail.jurta.org \
--to=juri@jurta.org \
--cc=3948@emacsbugs.donarmstrong.com \
--cc=lennart.borgman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).