* bug#16209: 24.3.50; menubar not updated when exiting from splash screen
@ 2013-12-21 7:36 YAMAMOTO Mitsuharu
2013-12-27 19:13 ` Eli Zaretskii
2021-05-30 5:23 ` Lars Ingebrigtsen
0 siblings, 2 replies; 3+ messages in thread
From: YAMAMOTO Mitsuharu @ 2013-12-21 7:36 UTC (permalink / raw)
To: 16209
Steps to reproduce:
1. $ emacs -q &
2. Type "q" to exit from the splash screen.
I'd expect that the new menu bar title "Lisp-Interaction" appears
for the *scratch* buffer. But the titles in the menubar don't get
updated.
3. Click the menubar.
Then the titles get updated suddenly.
YAMAMOTO Mitsuharu
mituharu@math.s.chiba-u.ac.jp
In GNU Emacs 24.3.50.1 (i386-apple-darwin13.0.0, GTK+ Version 3.10.6)
of 2013-12-21 on YAMAMOTO-no-iMac.local
Bzr revision: 115657 mituharu@math.s.chiba-u.ac.jp-20131221070407-a2ncsc7xl81p18ao
Windowing system distributor `The X.Org Foundation', version 11.0.11404000
Configured using:
`configure --without-imagemagick LDFLAGS=-L/opt/local/lib
CPPFLAGS=-I/opt/local/include'
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#16209: 24.3.50; menubar not updated when exiting from splash screen
2013-12-21 7:36 bug#16209: 24.3.50; menubar not updated when exiting from splash screen YAMAMOTO Mitsuharu
@ 2013-12-27 19:13 ` Eli Zaretskii
2021-05-30 5:23 ` Lars Ingebrigtsen
1 sibling, 0 replies; 3+ messages in thread
From: Eli Zaretskii @ 2013-12-27 19:13 UTC (permalink / raw)
To: YAMAMOTO Mitsuharu, Stefan Monnier; +Cc: 16209
> Date: Sat, 21 Dec 2013 16:36:52 +0900
> From: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
>
> Steps to reproduce:
>
> 1. $ emacs -q &
> 2. Type "q" to exit from the splash screen.
> I'd expect that the new menu bar title "Lisp-Interaction" appears
> for the *scratch* buffer. But the titles in the menubar don't get
> updated.
Stefan, this is a side effect of your commit 115377. It includes this
change in set_window_buffer:
@@ -3364,7 +3363,7 @@ set_window_buffer (Lisp_Object window, L
}
/* Maybe we could move this into the `if' but it's not obviously safe and
I doubt it's worth the trouble. */
- windows_or_buffers_changed = 28;
+ wset_redisplay (w);
However, update_menu_bar only recomputes the menu bar under these
conditions:
if (windows_or_buffers_changed
/* This used to test w->update_mode_line, but we believe
there is no need to recompute the menu in that case. */
|| update_mode_lines
|| window_buffer_changed (w))
{
I can easily fix this bug if I add a test for w->redisplay, but isn't
it too drastic to recompute the menu bar each time a window needs to
be redisplayed?
Perhaps we need a new flag, for when the buffer shown by the window is
changed?
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#16209: 24.3.50; menubar not updated when exiting from splash screen
2013-12-21 7:36 bug#16209: 24.3.50; menubar not updated when exiting from splash screen YAMAMOTO Mitsuharu
2013-12-27 19:13 ` Eli Zaretskii
@ 2021-05-30 5:23 ` Lars Ingebrigtsen
1 sibling, 0 replies; 3+ messages in thread
From: Lars Ingebrigtsen @ 2021-05-30 5:23 UTC (permalink / raw)
To: YAMAMOTO Mitsuharu; +Cc: 16209
YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp> writes:
> Steps to reproduce:
>
> 1. $ emacs -q &
> 2. Type "q" to exit from the splash screen.
> I'd expect that the new menu bar title "Lisp-Interaction" appears
> for the *scratch* buffer. But the titles in the menubar don't get
> updated.
(I'm going through old bug reports.)
As far as I can tell, this problem has been fixed in the years since it
was reported, and I'm therefore closing this bug report. If you can
still see this problem, please respond to the debbugs address and we'll
reopen.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-30 5:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-12-21 7:36 bug#16209: 24.3.50; menubar not updated when exiting from splash screen YAMAMOTO Mitsuharu
2013-12-27 19:13 ` Eli Zaretskii
2021-05-30 5:23 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).