From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#16209: 24.3.50; menubar not updated when exiting from splash screen Date: Fri, 27 Dec 2013 21:13:33 +0200 Message-ID: <83bo023y5e.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1388171655 6579 80.91.229.3 (27 Dec 2013 19:14:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 27 Dec 2013 19:14:15 +0000 (UTC) Cc: 16209@debbugs.gnu.org To: YAMAMOTO Mitsuharu , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 27 20:14:21 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VwcrU-0008Sh-3l for geb-bug-gnu-emacs@m.gmane.org; Fri, 27 Dec 2013 20:14:20 +0100 Original-Received: from localhost ([::1]:50050 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VwcrT-0002Oz-FM for geb-bug-gnu-emacs@m.gmane.org; Fri, 27 Dec 2013 14:14:19 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34651) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VwcrI-0002E9-6a for bug-gnu-emacs@gnu.org; Fri, 27 Dec 2013 14:14:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VwcrC-0000Mf-3D for bug-gnu-emacs@gnu.org; Fri, 27 Dec 2013 14:14:08 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:32921) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VwcrC-0000Mb-06 for bug-gnu-emacs@gnu.org; Fri, 27 Dec 2013 14:14:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VwcrB-0000pG-Ku for bug-gnu-emacs@gnu.org; Fri, 27 Dec 2013 14:14:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 27 Dec 2013 19:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16209 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16209-submit@debbugs.gnu.org id=B16209.13881716253138 (code B ref 16209); Fri, 27 Dec 2013 19:14:01 +0000 Original-Received: (at 16209) by debbugs.gnu.org; 27 Dec 2013 19:13:45 +0000 Original-Received: from localhost ([127.0.0.1]:46939 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vwcqu-0000oX-Tb for submit@debbugs.gnu.org; Fri, 27 Dec 2013 14:13:45 -0500 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:60028) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vwcqr-0000oL-Go for 16209@debbugs.gnu.org; Fri, 27 Dec 2013 14:13:43 -0500 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MYH00C00BTYAE00@a-mtaout22.012.net.il> for 16209@debbugs.gnu.org; Fri, 27 Dec 2013 21:13:39 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MYH00COFC2R9U20@a-mtaout22.012.net.il>; Fri, 27 Dec 2013 21:13:39 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:82663 Archived-At: > Date: Sat, 21 Dec 2013 16:36:52 +0900 > From: YAMAMOTO Mitsuharu > > Steps to reproduce: > > 1. $ emacs -q & > 2. Type "q" to exit from the splash screen. > I'd expect that the new menu bar title "Lisp-Interaction" appears > for the *scratch* buffer. But the titles in the menubar don't get > updated. Stefan, this is a side effect of your commit 115377. It includes this change in set_window_buffer: @@ -3364,7 +3363,7 @@ set_window_buffer (Lisp_Object window, L } /* Maybe we could move this into the `if' but it's not obviously safe and I doubt it's worth the trouble. */ - windows_or_buffers_changed = 28; + wset_redisplay (w); However, update_menu_bar only recomputes the menu bar under these conditions: if (windows_or_buffers_changed /* This used to test w->update_mode_line, but we believe there is no need to recompute the menu in that case. */ || update_mode_lines || window_buffer_changed (w)) { I can easily fix this bug if I add a test for w->redisplay, but isn't it too drastic to recompute the menu bar each time a window needs to be redisplayed? Perhaps we need a new flag, for when the buffer shown by the window is changed?