* bug#13455: 24.2.91; profiler.el: missing documentation, menu stuff etc @ 2013-01-16 1:50 Michael Heerdegen 2013-01-20 2:42 ` Glenn Morris 2016-07-17 5:14 ` npostavs 0 siblings, 2 replies; 6+ messages in thread From: Michael Heerdegen @ 2013-01-16 1:50 UTC (permalink / raw) To: 13455 Hi Emacs, somebody should please take care of some simple things missing, e.g. (1) Add the main commands to the Emacs-Lisp -> Profiling menu (presumably into a new submenu), so that people can find it. (2) Missing commentary header. At least say that it's documented in the elisp manual. (3) "If a given line has a `+' symbol at the left-hand side, you can expand that line by typing <RET>, in order to see the function(s) called by the higher-level function. Pressing <RET> again will collapse back to the original state." Why not make mouse-1 do this, too? (4) Add a menu for the profiler report. This is all not urgent, but should be done some day. Regards, Michael. In GNU Emacs 24.2.91.2 (x86_64-unknown-linux-gnu, GTK+ Version 2.24.10) of 2012-12-30 on drachen Bzr revision: rgm@gnu.org-20121230122326-m6gw29pkwjgwqf9d Windowing system distributor `The X.Org Foundation', version 11.0.10707000 System Description: Debian GNU/Linux 7.0 (wheezy) Configured using: `configure '--prefix=/usr/local/built/'' Important settings: value of $LC_ALL: de_DE.utf8 value of $LC_TIME: C value of $LANG: de_DE.utf8 locale-coding-system: utf-8-unix default enable-multibyte-characters: t ^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#13455: 24.2.91; profiler.el: missing documentation, menu stuff etc 2013-01-16 1:50 bug#13455: 24.2.91; profiler.el: missing documentation, menu stuff etc Michael Heerdegen @ 2013-01-20 2:42 ` Glenn Morris 2013-01-20 4:17 ` Michael Heerdegen 2016-07-17 5:14 ` npostavs 1 sibling, 1 reply; 6+ messages in thread From: Glenn Morris @ 2013-01-20 2:42 UTC (permalink / raw) To: michael_heerdegen; +Cc: 13455 Michael Heerdegen wrote: > (4) Add a menu for the profiler report. It already has one? ^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#13455: 24.2.91; profiler.el: missing documentation, menu stuff etc 2013-01-20 2:42 ` Glenn Morris @ 2013-01-20 4:17 ` Michael Heerdegen 0 siblings, 0 replies; 6+ messages in thread From: Michael Heerdegen @ 2013-01-20 4:17 UTC (permalink / raw) To: Glenn Morris; +Cc: 13455 Glenn Morris <rgm@gnu.org> writes: > > (4) Add a menu for the profiler report. > > It already has one? I tested the emacs-24 branch, where there is none. You're right, in trunk, there is indeed a menu. Regards, Michael. ^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#13455: 24.2.91; profiler.el: missing documentation, menu stuff etc 2013-01-16 1:50 bug#13455: 24.2.91; profiler.el: missing documentation, menu stuff etc Michael Heerdegen 2013-01-20 2:42 ` Glenn Morris @ 2016-07-17 5:14 ` npostavs 2016-07-19 23:42 ` Michael Heerdegen 1 sibling, 1 reply; 6+ messages in thread From: npostavs @ 2016-07-17 5:14 UTC (permalink / raw) To: Michael Heerdegen; +Cc: 13455 [-- Attachment #1: Type: text/plain, Size: 1020 bytes --] tags 13455 patch quit Michael Heerdegen <michael_heerdegen@web.de> writes: > (1) Add the main commands to the Emacs-Lisp -> Profiling menu > (presumably into a new submenu), so that people can find it. It seems this was added in 24.4. > > (2) Missing commentary header. At least say that it's documented in the > elisp manual. There is now a comment pointing to the manual. > > (4) Add a menu for the profiler report. As mentioned by Glenn, this is also present. > > (3) "If a given line has a `+' symbol at the left-hand side, you can > expand that line by typing <RET>, in order to see the function(s) called > by the higher-level function. Pressing <RET> again will collapse back > to the original state." > > Why not make mouse-1 do this, too? This is still not the case, though it's easy enough to add. Also, I'd like to add mention of prefix arg for profiler-report-toggle-entry, I was about make a feature request for an expand-all command, until I realized this already worked. Here's a patch: [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: patch --] [-- Type: text/x-diff, Size: 2363 bytes --] From c0100625ce2ab45f6980a221a02c7fc106818218 Mon Sep 17 00:00:00 2001 From: Noam Postavsky <npostavs@gmail.com> Date: Sun, 17 Jul 2016 00:21:42 -0400 Subject: [PATCH v1] Make profiler a bit friendier. * doc/lispref/debugging.texi (Profiling): * lisp/profiler.el (profiler-report-toggle-entry): Document use of prefix argument to expand whole call trees. (profiler-report-mode-map): Add mouse-1 binding for profiler-report-toggle-entry (Bug #13455). --- doc/lispref/debugging.texi | 5 +++-- lisp/profiler.el | 4 +++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/doc/lispref/debugging.texi b/doc/lispref/debugging.texi index 98c4705..2f83b40 100644 --- a/doc/lispref/debugging.texi +++ b/doc/lispref/debugging.texi @@ -840,8 +840,9 @@ Profiling absolute and percentage times since profiling started. If a given line has a @samp{+} symbol at the left-hand side, you can expand that line by typing @key{RET}, in order to see the function(s) called by -the higher-level function. Pressing @key{RET} again will collapse -back to the original state. +the higher-level function. Use a prefix argument (@key{C-u RET}) to +see the whole call tree below a function. Pressing @key{RET} again +will collapse back to the original state. Press @kbd{j} or @kbd{mouse-2} to jump to the definition of a function. Press @kbd{d} to view a function's documentation. diff --git a/lisp/profiler.el b/lisp/profiler.el index 401cae5..dac42fe 100644 --- a/lisp/profiler.el +++ b/lisp/profiler.el @@ -534,6 +534,7 @@ profiler-report-mode-map (define-key map "\r" 'profiler-report-toggle-entry) (define-key map "\t" 'profiler-report-toggle-entry) (define-key map "i" 'profiler-report-toggle-entry) + (define-key map [mouse-1] 'profiler-report-toggle-entry) (define-key map "f" 'profiler-report-find-entry) (define-key map "j" 'profiler-report-find-entry) (define-key map [mouse-2] 'profiler-report-find-entry) @@ -692,7 +693,8 @@ profiler-report-collapse-entry (defun profiler-report-toggle-entry (&optional arg) "Expand entry at point if the tree is collapsed, -otherwise collapse." +otherwise collapse. With prefix argument, expand all subentries +below entry at point." (interactive "P") (or (profiler-report-expand-entry arg) (profiler-report-collapse-entry))) -- 2.8.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* bug#13455: 24.2.91; profiler.el: missing documentation, menu stuff etc 2016-07-17 5:14 ` npostavs @ 2016-07-19 23:42 ` Michael Heerdegen 2016-07-29 0:15 ` npostavs 0 siblings, 1 reply; 6+ messages in thread From: Michael Heerdegen @ 2016-07-19 23:42 UTC (permalink / raw) To: npostavs; +Cc: 13455 npostavs@users.sourceforge.net writes: > tags 13455 patch > quit > > (3) "If a given line has a `+' symbol at the left-hand side, you can > > expand that line by typing <RET>, in order to see the function(s) > > called > > by the higher-level function. Pressing <RET> again will collapse back > > to the original state." > > > > Why not make mouse-1 do this, too? > > This is still not the case, though it's easy enough to add. Also, I'd > like to add mention of prefix arg for profiler-report-toggle-entry, I > was about make a feature request for an expand-all command, until I > realized this already worked. Here's a patch: [...] Looks good to me, thanks. Can we install it to master? Regards, Michael. ^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#13455: 24.2.91; profiler.el: missing documentation, menu stuff etc 2016-07-19 23:42 ` Michael Heerdegen @ 2016-07-29 0:15 ` npostavs 0 siblings, 0 replies; 6+ messages in thread From: npostavs @ 2016-07-29 0:15 UTC (permalink / raw) To: Michael Heerdegen; +Cc: 13455 tags 13455 fixed close 13455 quit Michael Heerdegen <michael_heerdegen@web.de> writes: > > Looks good to me, thanks. > > Can we install it to master? I installed the mouse-1 binding to master (4a5b6e62), and the documentation additions to emacs-25 (272391f). ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-07-29 0:15 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2013-01-16 1:50 bug#13455: 24.2.91; profiler.el: missing documentation, menu stuff etc Michael Heerdegen 2013-01-20 2:42 ` Glenn Morris 2013-01-20 4:17 ` Michael Heerdegen 2016-07-17 5:14 ` npostavs 2016-07-19 23:42 ` Michael Heerdegen 2016-07-29 0:15 ` npostavs
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).