From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#13455: 24.2.91; profiler.el: missing documentation, menu stuff etc Date: Sun, 17 Jul 2016 01:14:16 -0400 Message-ID: <8737n8ethz.fsf@users.sourceforge.net> References: <87vcaxc2vo.fsf@web.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1468732531 1588 80.91.229.3 (17 Jul 2016 05:15:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 17 Jul 2016 05:15:31 +0000 (UTC) Cc: 13455@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 17 07:15:19 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bOeQB-0004BC-0k for geb-bug-gnu-emacs@m.gmane.org; Sun, 17 Jul 2016 07:15:19 +0200 Original-Received: from localhost ([::1]:40211 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bOeQ6-0001jS-Sb for geb-bug-gnu-emacs@m.gmane.org; Sun, 17 Jul 2016 01:15:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51652) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bOeQ0-0001gj-K3 for bug-gnu-emacs@gnu.org; Sun, 17 Jul 2016 01:15:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bOePu-0000FU-Jm for bug-gnu-emacs@gnu.org; Sun, 17 Jul 2016 01:15:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41847) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bOePu-0000FQ-FK for bug-gnu-emacs@gnu.org; Sun, 17 Jul 2016 01:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bOePu-0004tD-99 for bug-gnu-emacs@gnu.org; Sun, 17 Jul 2016 01:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 Jul 2016 05:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13455 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 13455-submit@debbugs.gnu.org id=B13455.146873246318733 (code B ref 13455); Sun, 17 Jul 2016 05:15:02 +0000 Original-Received: (at 13455) by debbugs.gnu.org; 17 Jul 2016 05:14:23 +0000 Original-Received: from localhost ([127.0.0.1]:54184 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bOePH-0004s3-Gr for submit@debbugs.gnu.org; Sun, 17 Jul 2016 01:14:23 -0400 Original-Received: from mail-it0-f53.google.com ([209.85.214.53]:38580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bOePF-0004rg-J1; Sun, 17 Jul 2016 01:14:21 -0400 Original-Received: by mail-it0-f53.google.com with SMTP id j124so7384487ith.1; Sat, 16 Jul 2016 22:14:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Kek0kSgFBY43SZ7IqpnfyDH74J5eeQOem/VHRbzERqI=; b=YiKI1ywh0i2H/Gi/VxWH+2TdB19n+zXwabGxjlo3SZMDkCMOosFwvt75Jf52cT/Jxo NROpeqIQNARFlVmTKXm+hplDIzgslAGk92z48P3Vu59YnF8cCxzYl97pqj8kQpgNERDz Edf7YHduHzLQ9PnflhOm5VuPLl1h3nqdYmjjupbv36VqBTBXLhzehwkURKRQyaKth6Z0 BLM8E8IQ8Jpr+JvWM+UK6Dyc6i4OMCPAqztwVEd+/mYxiz0Y4GWXQ+VC+2JqJGwyWejD gcEaWuAOhm7VdYLHGqjpphY2Z42WR4T8V21/dq0k+N9MwOhEvPwe3qNHwHA7XKiFbGWn ehhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=Kek0kSgFBY43SZ7IqpnfyDH74J5eeQOem/VHRbzERqI=; b=fo3C1Rwr+jC/9N+qeXdgPyNzd3OObxE/pIBruhcFw2M7XT+bxL9wDpGelUI2W5IG9W mchwxCDM7POZpBhik1vfV2qlvuWXqPggUhkaTi4+fKCudOfi4a2N5C+O4EJUMeeYyw5p eTlHwbfq9F7Q2cVcB9yjf6lBFFSZiccH3agn3MjC9bNF3HlRweV2m8HhqYGRkENwKPuG pdXZl27yipDB9hlpxoglg1e7OomZsto942rhyWQwASpETVTcWNahzqJ/m8RBE09qOgU6 vWsZAlmSjDMzJx6hOe87uSQMyVUXDGhVub0v/+dATD8i5GtY9FbRvKCsw6cgeYv1lHei P+Tw== X-Gm-Message-State: ALyK8tJNTbck/C8wbevUQigOYJ45jmM+xCsn1A6bchYD5TccDnwvaPbwPEBH8ptXeEqu8w== X-Received: by 10.36.93.6 with SMTP id w6mr28392034ita.52.1468732456086; Sat, 16 Jul 2016 22:14:16 -0700 (PDT) Original-Received: from zony (206-188-64-44.cpe.distributel.net. [206.188.64.44]) by smtp.googlemail.com with ESMTPSA id j5sm2697072ith.1.2016.07.16.22.14.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 16 Jul 2016 22:14:15 -0700 (PDT) In-Reply-To: <87vcaxc2vo.fsf@web.de> (Michael Heerdegen's message of "Wed, 16 Jan 2013 02:50:35 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.93 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121159 Archived-At: --=-=-= Content-Type: text/plain tags 13455 patch quit Michael Heerdegen writes: > (1) Add the main commands to the Emacs-Lisp -> Profiling menu > (presumably into a new submenu), so that people can find it. It seems this was added in 24.4. > > (2) Missing commentary header. At least say that it's documented in the > elisp manual. There is now a comment pointing to the manual. > > (4) Add a menu for the profiler report. As mentioned by Glenn, this is also present. > > (3) "If a given line has a `+' symbol at the left-hand side, you can > expand that line by typing , in order to see the function(s) called > by the higher-level function. Pressing again will collapse back > to the original state." > > Why not make mouse-1 do this, too? This is still not the case, though it's easy enough to add. Also, I'd like to add mention of prefix arg for profiler-report-toggle-entry, I was about make a feature request for an expand-all command, until I realized this already worked. Here's a patch: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=v1-0001-Make-profiler-a-bit-friendier.patch Content-Description: patch >From c0100625ce2ab45f6980a221a02c7fc106818218 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Sun, 17 Jul 2016 00:21:42 -0400 Subject: [PATCH v1] Make profiler a bit friendier. * doc/lispref/debugging.texi (Profiling): * lisp/profiler.el (profiler-report-toggle-entry): Document use of prefix argument to expand whole call trees. (profiler-report-mode-map): Add mouse-1 binding for profiler-report-toggle-entry (Bug #13455). --- doc/lispref/debugging.texi | 5 +++-- lisp/profiler.el | 4 +++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/doc/lispref/debugging.texi b/doc/lispref/debugging.texi index 98c4705..2f83b40 100644 --- a/doc/lispref/debugging.texi +++ b/doc/lispref/debugging.texi @@ -840,8 +840,9 @@ Profiling absolute and percentage times since profiling started. If a given line has a @samp{+} symbol at the left-hand side, you can expand that line by typing @key{RET}, in order to see the function(s) called by -the higher-level function. Pressing @key{RET} again will collapse -back to the original state. +the higher-level function. Use a prefix argument (@key{C-u RET}) to +see the whole call tree below a function. Pressing @key{RET} again +will collapse back to the original state. Press @kbd{j} or @kbd{mouse-2} to jump to the definition of a function. Press @kbd{d} to view a function's documentation. diff --git a/lisp/profiler.el b/lisp/profiler.el index 401cae5..dac42fe 100644 --- a/lisp/profiler.el +++ b/lisp/profiler.el @@ -534,6 +534,7 @@ profiler-report-mode-map (define-key map "\r" 'profiler-report-toggle-entry) (define-key map "\t" 'profiler-report-toggle-entry) (define-key map "i" 'profiler-report-toggle-entry) + (define-key map [mouse-1] 'profiler-report-toggle-entry) (define-key map "f" 'profiler-report-find-entry) (define-key map "j" 'profiler-report-find-entry) (define-key map [mouse-2] 'profiler-report-find-entry) @@ -692,7 +693,8 @@ profiler-report-collapse-entry (defun profiler-report-toggle-entry (&optional arg) "Expand entry at point if the tree is collapsed, -otherwise collapse." +otherwise collapse. With prefix argument, expand all subentries +below entry at point." (interactive "P") (or (profiler-report-expand-entry arg) (profiler-report-collapse-entry))) -- 2.8.0 --=-=-=--