unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Heerdegen <michael_heerdegen@web.de>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: moralesrodrigo1100@gmail.com, 48659@debbugs.gnu.org
Subject: bug#48659: Escapes are deleted after executing "dired-toggle-read-only" in *Find* buffer
Date: Thu, 27 May 2021 20:49:40 +0200	[thread overview]
Message-ID: <87eedsggfv.fsf@web.de> (raw)
In-Reply-To: <87zgwggpab.fsf@igel.home> (Andreas Schwab's message of "Thu, 27 May 2021 17:38:36 +0200")

Andreas Schwab <schwab@linux-m68k.org> writes:

> wdired-normalize-filename doesn't handle "\\ ".

I have two questions:

(1) Although a comment before `wdired-normalize-filename' tells that
"This code is a copy of some dired-get-filename lines.", the unquoting
stuff seems to be implemented differently than in `dired-get-filename'.
Could we reuse the code from that function?  `dired-get-filename'
doesn't seem to delete the spaces from the file names.

(2) AFAICT your commit (that I had cited above) addressed the comment
from Stefan he had added to the definition of
`wdired-normalize-filename':

   ;; FIXME: shouldn't we check for a `b' argument or somesuch
   ;; before doing such unquoting?  --Stef

Can we delete that comment?  That check is performed now and the
function receives the result as an argument UNQUOTEP now.


Thanks,

Michael.





  parent reply	other threads:[~2021-05-27 18:49 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-25 20:40 bug#48659: Escapes are deleted after executing "dired-toggle-read-only" in *Find* buffer Rodrigo Morales
2021-05-26 12:14 ` Eli Zaretskii
2021-05-26 15:16   ` Rodrigo Morales
2021-05-26 17:18     ` Eli Zaretskii
     [not found]       ` <871r9tdp99.fsf@gmail.com>
2021-05-27  7:04         ` Eli Zaretskii
2021-05-29  6:29           ` Arthur Miller
2021-05-27  9:14       ` Robert Pluim
2021-05-27  9:34         ` Eli Zaretskii
2021-05-27 13:50         ` Michael Heerdegen
2021-05-27 14:01   ` Michael Heerdegen
2021-05-27 14:04     ` Eli Zaretskii
2021-05-27 14:16       ` Michael Heerdegen
2021-05-27 14:48         ` Andreas Schwab
2021-05-27 15:04         ` Andreas Schwab
2021-05-27 15:31           ` Michael Heerdegen
2021-05-27 15:38       ` Andreas Schwab
2021-05-27 15:47         ` Michael Heerdegen
2021-05-27 15:57           ` Andreas Schwab
2021-05-27 15:56         ` Andreas Schwab
2021-05-27 18:49         ` Michael Heerdegen [this message]
2021-05-27 19:11           ` Andreas Schwab
2021-05-27 20:38             ` Michael Heerdegen
2021-05-29 13:39 ` Andreas Schwab
2021-05-29 23:09   ` Michael Heerdegen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eedsggfv.fsf@web.de \
    --to=michael_heerdegen@web.de \
    --cc=48659@debbugs.gnu.org \
    --cc=moralesrodrigo1100@gmail.com \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).