From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#48659: Escapes are deleted after executing "dired-toggle-read-only" in *Find* buffer Date: Thu, 27 May 2021 20:49:40 +0200 Message-ID: <87eedsggfv.fsf@web.de> References: <87mtsi35u2.fsf@gmail.com> <834kepbsji.fsf@gnu.org> <87im3446nm.fsf@web.de> <83sg288e8f.fsf@gnu.org> <87zgwggpab.fsf@igel.home> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17015"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: moralesrodrigo1100@gmail.com, 48659@debbugs.gnu.org To: Andreas Schwab Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 27 20:50:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lmL5B-0004D8-7o for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 27 May 2021 20:50:13 +0200 Original-Received: from localhost ([::1]:56512 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lmL5A-0005fa-8W for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 27 May 2021 14:50:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45378) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lmL50-0005c0-Qv for bug-gnu-emacs@gnu.org; Thu, 27 May 2021 14:50:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41215) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lmL50-0003Y4-Hk for bug-gnu-emacs@gnu.org; Thu, 27 May 2021 14:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lmL50-00086j-D9 for bug-gnu-emacs@gnu.org; Thu, 27 May 2021 14:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 May 2021 18:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48659 X-GNU-PR-Package: emacs Original-Received: via spool by 48659-submit@debbugs.gnu.org id=B48659.162214139231143 (code B ref 48659); Thu, 27 May 2021 18:50:02 +0000 Original-Received: (at 48659) by debbugs.gnu.org; 27 May 2021 18:49:52 +0000 Original-Received: from localhost ([127.0.0.1]:52761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lmL4p-00086F-Qj for submit@debbugs.gnu.org; Thu, 27 May 2021 14:49:51 -0400 Original-Received: from mout.web.de ([212.227.17.11]:45955) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lmL4o-000860-0w for 48659@debbugs.gnu.org; Thu, 27 May 2021 14:49:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1622141381; bh=9GaHePf457PbdT/6o6zr54exWoz4PZz+u3rjElNg2pQ=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=Rw7zlK/DDdgG6tTDpY1RR2vPVDMnVTg2X0Q1BcxYAwu4NC/hH1OipU2+SBnrq7NxR JLgVnxIuoP3pJF04+DEJAx7KYHASzUKcjkATJneOjuC62gc3SE7kKHIhZqPrIn5cvT 7BitSwaknNTJp82WBMMKX99TifhX2mDNykQlI/A8= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([94.218.219.0]) by smtp.web.de (mrweb101 [213.165.67.124]) with ESMTPSA (Nemesis) id 0M8zFx-1lZvQ01Ve9-00CSCE; Thu, 27 May 2021 20:49:41 +0200 In-Reply-To: <87zgwggpab.fsf@igel.home> (Andreas Schwab's message of "Thu, 27 May 2021 17:38:36 +0200") X-Provags-ID: V03:K1:NvncKVVkox9U3w3OyvkKd3LzhcdgdtimAdFI8aNzFHshWEf964l siLi70ZEDQbF0ODmbsTWO0WBXRvs+6VgC/F3a42+IVFnULbwdP1SkOJIquwO/zF4Ajaaq0d lbLouyQKGxEF/J4uRlhfgUnifCvYyKINKxE4kdpau3SEMIbRemoSKdmHrUZLH2zh4BvWTgI GN4JufkPWdcPJSfpsYw/A== X-UI-Out-Filterresults: notjunk:1;V03:K0:/WrHqt74bl4=:t2J38JRrQUFRD2r2rOuSj3 hItDQOV2pS4wG0LI86pxuuBFIT12J1Ek5fwuAVuVrHYw1e55/n8cEjW40OXT61Jh8gL13Wuev gaUdrEWS/LM0/s46eADVjlaX+E+cRZm1zAur1dE5P3R5BlWMzndNrJ7Oqex5giAnU3o52zHX5 E5dMdkzpHf01EBhmqZ5g6wTFeQWGQgCF3N3cIQ1LELAknZa52j1FoUg1qFH41dfhE3fpKD5od sVCPVlkSQUFhUxgbCoPZbtl1h+g6Ah/V0+8V0Llk6Tt2JCX/rQ1GsEZNhb47u+KHevyGNOCjG 60UotSXntFTa4+UPStI1xugdVQxDi9dRoDFB5ch2UA/0JQDqdsLvOqma6llPWakYzWFxVFEvg aH0W1mwy/5ZTCTU0D9baEwk714Z/c0r597F8LJ14CzfGKAbGAyXwaSu8h3fxDCg4OGhrromAr /0gcKI2NcrwiMuPFzrS3GKkhrhBxnLoyrs34N131/1s85/XJr5soCNXzjYS5gjTCYyLgJWG0b lElW7ktn0sx2bLgZ259x4zS1bWsszWtn/BJU8Kn/zPyKg0MXY5PkUdN5Pr4pxTwrr9QnTLQoC SfBpF0Ppbb/tubGqIA0UmKTWqc0T2/UomTCWfTzBw4uxZeF3K69hvH+vnrVcVyj8O5hOYFmVB q9bkPeCbYUVWdsbB66V5tFQfGdT52hDO44sxIFQzjPWBLpA4FEwBe/4hS7pBq4jKDao0nsJIK QvEMARl3bR75mrYM20NiJeyiGWfrtaEhe6WCKL5p99Oc/iBQCUilvtAkWYnLc+zCNPQ+BohV X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207390 Archived-At: Andreas Schwab writes: > wdired-normalize-filename doesn't handle "\\ ". I have two questions: (1) Although a comment before `wdired-normalize-filename' tells that "This code is a copy of some dired-get-filename lines.", the unquoting stuff seems to be implemented differently than in `dired-get-filename'. Could we reuse the code from that function? `dired-get-filename' doesn't seem to delete the spaces from the file names. (2) AFAICT your commit (that I had cited above) addressed the comment from Stefan he had added to the definition of `wdired-normalize-filename': ;; FIXME: shouldn't we check for a `b' argument or somesuch ;; before doing such unquoting? --Stef Can we delete that comment? That check is performed now and the function receives the result as an argument UNQUOTEP now. Thanks, Michael.