bug#4610: 23.1; VC commit buffer should list files to be committed

bug#4610: 23.1; VC commit buffer should list files to be committed

[Tom Tromey]

Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the bug-gnu-emacs@gnu.org mailing list,
and to the gnu.emacs.bug news group.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:


Today I accidentally committed one file but not another one from
*vc-dir*.  That happened because point was on one file, not on the
containing directory as I'd thought.

It would be nice if the VC commit message buffer listed the files that
were going to be committed.  Such a list should automatically be
stripped out before being sent to the underlying command as the commit
message.


If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
/usr/share/emacs/23.1/etc/DEBUG for instructions.


In GNU Emacs 23.1.1 (i386-redhat-linux-gnu, GTK+ Version 2.16.5)
 of 2009-08-26 on x86-2.fedora.phx.redhat.com
Windowing system distributor `The X.Org Foundation', version 11.0.10601901
configured using `configure  '--build=i386-redhat-linux-gnu' '--host=i386-redhat-linux-gnu' '--target=i586-redhat-linux-gnu' '--program-prefix=' '--prefix=/usr' '--exec-prefix=/usr' '--bindir=/usr/bin' '--sbindir=/usr/sbin' '--sysconfdir=/etc' '--datadir=/usr/share' '--includedir=/usr/include' '--libdir=/usr/lib' '--libexecdir=/usr/libexec' '--localstatedir=/var' '--sharedstatedir=/var/lib' '--mandir=/usr/share/man' '--infodir=/usr/share/info' '--with-dbus' '--with-gif' '--with-jpeg' '--with-png' '--with-rsvg' '--with-tiff' '--with-xft' '--with-xpm' '--with-x-toolkit=gtk' 'build_alias=i386-redhat-linux-gnu' 'host_alias=i386-redhat-linux-gnu' 'target_alias=i586-redhat-linux-gnu' 'CFLAGS=-DMAIL_USE_LOCKF -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-bu
 ffer-size=4 -m32 -march=i586 -mtune=generic -fasynchronous-unwind-tables''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: C/l

Minor modes in effect:
  erc-list-mode: t
  erc-menu-mode: t
  erc-autojoin-mode: t
  erc-ring-mode: t
  erc-pcomplete-mode: t
  erc-track-mode: t
  erc-track-minor-mode: t
  erc-match-mode: t
  erc-button-mode: t
  erc-fill-mode: t
  erc-stamp-mode: t
  erc-netsplit-mode: t
  erc-spelling-mode: t
  erc-truncate-mode: t
  shell-dirtrack-mode: t
  diff-auto-refine-mode: t
  flyspell-mode: t
  erc-status-mode: t
  erc-services-mode: t
  erc-networks-mode: t
  erc-irccontrols-mode: t
  erc-noncommands-mode: t
  erc-move-to-prompt-mode: t
  erc-readonly-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t
  abbrev-mode: t

Recent input:
E = M-v M-v q C-l C-u C-u C-n n SPC E q C-l C-u C-n 
C-u C-n p SPC E q n n SPC M-> Q y n n SPC M-> SPC SPC 
2 K i SPC E q C-l SPC M-> Q y SPC 5 0 <return> M-> 
C-u C-p C-p C-p SPC E E S-SPC E S-SPC E S-SPC E S-SPC 
E C-z o <f10> M-v M-> <f10> <f10> <f10> C-z o SPC SPC 
q s M-v M-v M-v M-v M-< C-u C-n p SPC c SPC SPC SPC 
c SPC s z C-c b C-x k <return> C-x k <return> C-l C-z 
o <f10> <f10> <f10> <f10> C-z o M-v <switch-frame> 
<switch-frame> C-x s C-x b * G <tab> <return> M-> C-u 
C-p C-u C-p SPC 5 0 <return> M-> C-p SPC S W <return> 
C-p C-SPC C-n C-n C-n C-w C-n C-n C-k N o t SPC y e 
t , SPC s o r r y SPC a b o u t SPC t h a t <return> 
<backspace> . <return> I SPC w i l l SPC r e a d SPC 
t h e m SPC t o m r r <backspace> <backspace> o r r 
o w . C-f C-k C-c C-c M SPC = C-l q s C-z o C-x b C-g 
C-z o C-x b v a l o p <tab> <return> C-l C-v C-v C-l 
C-z o C-x b C-g C-x k <return> <f10> <f10> <f10> C-x 
b c p - a <tab> <M-backspace> s u p <tab> h <return> 
C-v C-v C-z o M-x r e p o r t - e m <tab> b <tab> <return> 
v c SPC c o m m i t C-g C-x b * V <tab> <tab> C-g M-x 
M-p <return>

Recent messages:
Sending...done
No more articles [2 times]
Expiring articles...done
(No changes need to be saved)
Saving /home/tromey/.newsrc.eld...
Saving file /home/tromey/.newsrc.eld...
Wrote /home/tromey/.newsrc.eld
Saving /home/tromey/.newsrc.eld...done
Quit [3 times]
Making completion list...
Quit
Tom

bug#4610: 23.1; VC commit buffer should list files to be committed

[Dan Nicolaescu]

Tom Tromey <tromey@redhat.com> writes:

  > Today I accidentally committed one file but not another one from
  > *vc-dir*.  That happened because point was on one file, not on the
  > containing directory as I'd thought.
  > 
  > It would be nice if the VC commit message buffer listed the files that
  > were going to be committed.  Such a list should automatically be
  > stripped out before being sent to the underlying command as the commit
  > message.

The list of files to be committed can be seen by using `log-edit-show-files'.
log-edit-hook can be configured to do it automatically.

On the other hand is it clear that showing such a list by default helps?
My personal experience with perforce (where files are listed in the
commit message by default -- and the list is editable) shows that the
same mistake is quite possible (and not infrequent) there.  IMMV...

bug#4610: 23.1; VC commit buffer should list files to be committed

[Lars Ingebrigtsen]

[-- Attachment #1: Type: text/plain, Size: 701 bytes --]

Tom Tromey <tromey@redhat.com> writes:

> Today I accidentally committed one file but not another one from
> *vc-dir*.  That happened because point was on one file, not on the
> containing directory as I'd thought.
>
> It would be nice if the VC commit message buffer listed the files that
> were going to be committed.  Such a list should automatically be
> stripped out before being sent to the underlying command as the commit
> message.

(I'm going through old bug reports that unfortunately weren't resolved
at the time.)

It seems like this was implemented a some point in the years since this
was reported.  By default, Emacs shows the included screenshot now, so
I'm closing this bug report.


[-- Attachment #2: Type: image/png, Size: 58774 bytes --]

[-- Attachment #3: Type: text/plain, Size: 106 bytes --]




-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no