From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.bugs Subject: bug#4610: 23.1; VC commit buffer should list files to be committed Date: Thu, 10 Dec 2009 11:54:53 -0800 (PST) Message-ID: <200912101954.nBAJsrFL014783@godzilla.ics.uci.edu> References: Reply-To: Dan Nicolaescu , 4610@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1260476280 17974 80.91.229.12 (10 Dec 2009 20:18:00 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 10 Dec 2009 20:18:00 +0000 (UTC) Cc: 4610@emacsbugs.donarmstrong.com To: Tom Tromey Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 10 21:17:53 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NIpSR-0005Ww-V4 for geb-bug-gnu-emacs@m.gmane.org; Thu, 10 Dec 2009 21:17:52 +0100 Original-Received: from localhost ([127.0.0.1]:40734 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NIpSR-0000D5-NG for geb-bug-gnu-emacs@m.gmane.org; Thu, 10 Dec 2009 15:17:51 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NIpIW-0005ww-UQ for bug-gnu-emacs@gnu.org; Thu, 10 Dec 2009 15:07:37 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NIpIR-0005oO-Ch for bug-gnu-emacs@gnu.org; Thu, 10 Dec 2009 15:07:36 -0500 Original-Received: from [199.232.76.173] (port=36257 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NIpIR-0005ns-5k for bug-gnu-emacs@gnu.org; Thu, 10 Dec 2009 15:07:31 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:44660) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NIpIQ-000635-BD for bug-gnu-emacs@gnu.org; Thu, 10 Dec 2009 15:07:30 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nBAK7Qdk017353; Thu, 10 Dec 2009 12:07:28 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id nBAK05FA015863; Thu, 10 Dec 2009 12:00:05 -0800 Resent-Date: Thu, 10 Dec 2009 12:00:05 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Dan Nicolaescu Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Thu, 10 Dec 2009 20:00:05 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 4610 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 4610-submit@emacsbugs.donarmstrong.com id=B4610.126047491115543 (code B ref 4610); Thu, 10 Dec 2009 20:00:05 +0000 Original-Received: (at 4610) by emacsbugs.donarmstrong.com; 10 Dec 2009 19:55:11 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from colin-baker-v0.ics.uci.edu (colin-baker-v0.ics.uci.edu [128.195.1.153]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nBAJt9S6015415 for <4610@emacsbugs.donarmstrong.com>; Thu, 10 Dec 2009 11:55:10 -0800 Original-Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by colin-baker-v0.ics.uci.edu (8.13.8/8.13.8) with ESMTP id nBAJsrcC018743 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 10 Dec 2009 11:54:53 -0800 Original-Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id nBAJsrFL014783; Thu, 10 Dec 2009 11:54:53 -0800 (PST) In-Reply-To: (Tom Tromey's message of "Thu, 01 Oct 2009 15:23:50 -0600") Original-Lines: 18 X-ICS-MailScanner-Information: Please send mail to helpdesk@ics.uci.edu or more information X-ICS-MailScanner-ID: nBAJsrcC018743 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Thu, 10 Dec 2009 15:07:36 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:33478 Archived-At: Tom Tromey writes: > Today I accidentally committed one file but not another one from > *vc-dir*. That happened because point was on one file, not on the > containing directory as I'd thought. > > It would be nice if the VC commit message buffer listed the files that > were going to be committed. Such a list should automatically be > stripped out before being sent to the underlying command as the commit > message. The list of files to be committed can be seen by using `log-edit-show-files'. log-edit-hook can be configured to do it automatically. On the other hand is it clear that showing such a list by default helps? My personal experience with perforce (where files are listed in the commit message by default -- and the list is editable) shows that the same mistake is quite possible (and not infrequent) there. IMMV...